Re: completion always appends /
Hello GNU Bash developers! a week ago I've send you a bug report and as follow-up the fix patch below, but so far I did not get any reply, not even an ACK or ticket number that anyone received my mails. I would like to roll out that bug fix and did hope that I'll get a) any reaction and comment on my report and esp. on the patch b) this will be a an official patch before I roll out my new binaries. otherwise I'll have to revert my patch later and apply your (possibly different and better) fix later, resulting in another rollout which I'd like to avoid... anyone reading bash-bug mails these day ? any comments or suggestions/optimizations for this patch ? thanks for any hint! On Aug 15, Harald Koenig wrote: --- --- lib/readline/complete.c~ 2006-07-28 17:35:49.0 +0200 +++ lib/readline/complete.c 2007-08-15 11:14:20.0 +0200 @@ -1528,6 +1528,8 @@ else if (rl_completion_suppress_append == 0 rl_completion_append_character) temp_string[temp_string_index++] = rl_completion_append_character; + rl_completion_append_character = ' '; + temp_string[temp_string_index++] = '\0'; if (rl_filename_completion_desired) --- or --- --- lib/readline/complete.c~ 2006-07-28 17:35:49.0 +0200 +++ lib/readline/complete.c 2007-08-15 11:14:20.0 +0200 @@ -1569,6 +1569,8 @@ rl_insert_text (temp_string); } + rl_completion_append_character = ' '; + return (temp_string_index); } --- Harald Koenig -- I hope to die ___ _ before I *have* to use Microsoft Word., 0--,|/OOO\ Donald E. Knuth, 02-Oct-2001 in Tuebingen._/ / /OOO\ \ \/OOO\ \ O|// Harald Koenig \/\/\/\/\/\/\/\/\/ science+computing ag// / \\ \ [EMAIL PROTECTED]^ ^ -- Vorstand/Board of Management: Dr. Bernd Finkbeiner, Dr. Florian Geyer, Dr. Roland Niemeier, Dr. Arno Steitz, Dr. Ingrid Zech Vorsitzender des Aufsichtsrats/ Chairman of the Supervisory Board: Prof. Dr. Hanns Ruder Sitz/Registered Office: Tuebingen Registergericht/Registration Court: Stuttgart Registernummer/Commercial Register No.: HRB 382196
Re: recalculate LINES and COLUMNS
On Mon, Aug 20, 2007 at 07:40:47AM +0200, thomas wrote: Sometimes I want to change the font of my terminal (urxvt): for instance, I am tired and want a bigger font. I can use a bash alias (or a keyboard shortcut) which runs these two lines: printf '\e]710;%s\007' 'xft:DejaVu Sans Mono:size=10' kill -WINCH $$ Font is changed but the second line seems to have no effect: bash does not recompute the values of COLUMNS and LINES, thus I may type outside urxvt's window. There is a checkwinsize option but it does not seem to help. If I manually resize the window, the problem is fixed. How can I send a WINCH signal to bash so that it recalculates the correct values of LINES and COLUMNS after a font change? It works fine for me using rxvt-unicode 8.1 and bash 3.2.13(1) from ubuntu 7.04. If a urxvt window is maximized or grows large enough to exceed the screen size, then the number of columns changes and $COLUMNS is updated immediately without using any kill command. (If the window is not maximized and remains small enough fit the screen then the number of lines and columns is not changed by the font change escape sequence.) -- Mike Stroyan [EMAIL PROTECTED]
[bashbug] Please include .bash_login in the FILES section of 'man bash'
Configuration Information [Automatically generated, do not change]: Machine: i686 OS: linux-gnu Compiler: gcc Compilation CFLAGS: -DPROGRAM='bash' -DCONF_HOSTTYPE='i686' -DCONF_OSTYPE='linu x-gnu' -DCONF_MACHTYPE='i686-pc-linux-gnu' -DCONF_VENDOR='pc' -DLOCALEDIR='/usr/ share/locale' -DPACKAGE='bash' -DSHELL -DHAVE_CONFIG_H -I. -I. -I./include -I ./lib -march=i686 -O2 -pipe uname output: Linux corvus 2.6.22-fw3 #1 SMP PREEMPT Thu Aug 16 01:14:42 CEST 20 07 i686 Intel(R) Pentium(R) M processor 1.73GHz GenuineIntel GNU/Linux Machine Type: i686-pc-linux-gnu Bash Version: 3.2 Patch Level: 17 Release Status: release Description: '.bash_login' is not included in the FILES section of the 'bash' man page Repeat-By: 'man bash' Fix: Please include a one-liner in the man page. The file is mentioned elsewhere in the manual - however, the FILES section is incomplete in its current form. Many thanks! Gabor
Re: completion always appends /
Harald Koenig wrote: Hello GNU Bash developers! a week ago I've send you a bug report and as follow-up the fix patch below, but so far I did not get any reply, not even an ACK or ticket number that anyone received my mails. I received the mail, but had already fixed the problem several months ago. a) any reaction and comment on my report and esp. on the patch The code fix is in the wrong place; it needs to go into set_completion_defaults(). b) this will be a an official patch before I roll out my new binaries. There may not be an official patch for this; it's a relatively minor issue. Chet -- ``The lyf so short, the craft so long to lerne.'' - Chaucer Live Strong. No day but today. Chet Ramey, ITS, CWRU[EMAIL PROTECTED]http://cnswww.cns.cwru.edu/~chet/
Re: completion always appends /
Hi Chet, thanks for your quick answer! On Aug 22, Chet Ramey wrote: a) any reaction and comment on my report and esp. on the patch The code fix is in the wrong place; it needs to go into set_completion_defaults(). thanks for this pointer! b) this will be a an official patch before I roll out my new binaries. There may not be an official patch for this; it's a relatively minor issue. YMMV. for me and some of my colleagues it's not that minor at all. my typical work week is to login on monday moring and logout every friday evening. during this time I collect multiple xterms with bash each having a directory stack of ~10-30+ and quite often 10++ backgound jobs (so I'm pretty shell based;) loosing the whole context of such a shell is pretty annoying, and with that / appended to every completion it's no fun anymore to work with such a shell... so for some of us this is real issue and one major reason to roll out a new bash version on 200+ machines (10+ different plattforms)... anyway, thanks for your help finding the correct place for this fix, Harald Koenig -- I hope to die ___ _ before I *have* to use Microsoft Word., 0--,|/OOO\ Donald E. Knuth, 02-Oct-2001 in Tuebingen._/ / /OOO\ \ \/OOO\ \ O|// Harald Koenig \/\/\/\/\/\/\/\/\/ science+computing ag// / \\ \ [EMAIL PROTECTED]^ ^ -- Vorstand/Board of Management: Dr. Bernd Finkbeiner, Dr. Florian Geyer, Dr. Roland Niemeier, Dr. Arno Steitz, Dr. Ingrid Zech Vorsitzender des Aufsichtsrats/ Chairman of the Supervisory Board: Prof. Dr. Hanns Ruder Sitz/Registered Office: Tuebingen Registergericht/Registration Court: Stuttgart Registernummer/Commercial Register No.: HRB 382196
