Re: [PATCH] Add active mark, face support; activate mark on paste

> On 2020-04-11 at 18:04 +0200, gentoo_eshoes wrote: >> $ echo ${PS1@A} >> declare -x PS1=$'\\\n---\\n\\\n\\[\\a\\]\\\n\\[\\e[1;37m\ >> \e[42m\\]\\u@\\H\\[\\e[0m\\] \\\n\\[\\033[1;30m\\]$(date "+%Y/%m/%d % >> H:%M:%S")\\[\\033[0m\\] \\\n\\[\\e[0;37m\\]\\s\\V t:\\l j:\\j \\\nd: >> ${SHLVL}

Re: [PATCH] Add active mark, face support; activate mark on paste

On 2020-04-11 at 18:04 +0200, gentoo_eshoes wrote: > $ echo ${PS1@A} > declare -x PS1=$'\\\n---\\n\\\n\\[\\a\\]\\\n\\[\\e[1;37m\ > \e[42m\\]\\u@\\H\\[\\e[0m\\] \\\n\\[\\033[1;30m\\]$(date "+%Y/%m/%d % > H:%M:%S")\\[\\033[0m\\] \\\n\\[\\e[0;37m\\]\\s\\V t:\\l j:\\j \\\nd: > ${SHLVL}

Re: [PATCH] Add active mark, face support; activate mark on paste

On 4/15/20 10:37 AM, gentoo_esh...@tutanota.com wrote: >> This is the expected behavior with bracketed-paste enabled. The pasted text >> is `bracketed' by a start and end sequence -- that's how the face code >> knows what's been pasted and to highlight it -- and any embedded editing >>

Re: [PATCH] Add active mark, face support; activate mark on paste

Apr 14, 2020, 22:53 by chet.ra...@case.edu: > On 4/14/20 4:46 PM, gentoo_esh...@tutanota.com wrote: > >> Another 'face' issue(the 3rd?) I just noticed now: >> if I paste something that has "\n" inside it, like these 3 lines(only the >> first 2 lines have \n, but doesn't matter): >> -bash:

Re: [PATCH] Add active mark, face support; activate mark on paste

On 4/14/20 4:46 PM, gentoo_esh...@tutanota.com wrote: > Another 'face' issue(the 3rd?) I just noticed now: > if I paste something that has "\n" inside it, like these 3 lines(only the > first 2 lines have \n, but doesn't matter): > -bash: mk_add_options: command not found > -bash: mk_add_options:

Re: [PATCH] Add active mark, face support; activate mark on paste

On 4/12/20 11:04 PM, Daniel Colascione wrote: > On 4/12/20 6:23 PM, Chet Ramey wrote: >> On 4/12/20 2:15 PM, gentoo_esh...@tutanota.com wrote: >> >>> There is one more/different 'face' issue: if I paste a line and then >>> press Enter (as opposed to any alphanumeric key or arrow keys) then the >>>

Re: [PATCH] Add active mark, face support; activate mark on paste

Apr 13, 2020, 05:04 by dan...@dancol.org: > > > FWIW, for debugging the kinds of issues we're discussing here, rr(1) is > _incredibly_ helpful. > I can't use 'rr' due to system requirements: https://github.com/mozilla/rr#system-requirements $ sudo sysctl kernel.perf_event_paranoid=1; rr

Re: [PATCH] Add active mark, face support; activate mark on paste

On 4/12/20 6:23 PM, Chet Ramey wrote: On 4/12/20 2:15 PM, gentoo_esh...@tutanota.com wrote: There is one more/different 'face' issue: if I paste a line and then press Enter (as opposed to any alphanumeric key or arrow keys) then the highlight remains(highlighted), possibly because the ^M is

Re: [PATCH] Add active mark, face support; activate mark on paste

On 4/12/20 2:15 PM, gentoo_esh...@tutanota.com wrote: > There is one more/different 'face' issue: if I paste a line and then press > Enter (as opposed to any alphanumeric key or arrow keys) then the highlight > remains(highlighted), possibly because the ^M is echoed and thus moves the > cursor

Re: [PATCH] Add active mark, face support; activate mark on paste

Apr 12, 2020, 19:30 by chet.ra...@case.edu: > > I'm glad it worked, but I think this is a more correct version: > > *** ../bash-20200408/lib/readline/display.c 2020-04-07 14:55:15.0 > -0400 > --- lib/readline/display.c2020-04-12 12:01:22.0 -0400 > *** > ***

Re: [PATCH] Add active mark, face support; activate mark on paste

On 4/12/20 1:04 AM, gentoo_esh...@tutanota.com wrote: > > > > Apr 11, 2020, 23:11 by chet.ra...@case.edu: > >> On 4/11/20 12:04 PM, gentoo_esh...@tutanota.com wrote: >> What's your $PS1? >>> $ echo $PS1 >>> \ ---\n\ \[\a\]\ \[\e[1;37m\e[42m\]\u@\H\[\e[0m\] \ >>>

Re: [PATCH] Add active mark, face support; activate mark on paste

Apr 11, 2020, 23:11 by chet.ra...@case.edu: > On 4/11/20 12:04 PM, gentoo_esh...@tutanota.com wrote: > >>> >>> What's your $PS1? >>> >> $ echo $PS1 >> \ ---\n\ \[\a\]\ \[\e[1;37m\e[42m\]\u@\H\[\e[0m\] \ >> \[\033[1;30m\]$(date "+%Y/%m/%d %H:%M:%S")\[\033[0m\] \ \[\e[0;37m\]\s\V >>

Re: [PATCH] Add active mark, face support; activate mark on paste

On 4/11/20 12:04 PM, gentoo_esh...@tutanota.com wrote: >> >> What's your $PS1? >> > $ echo $PS1 > \ ---\n\ \[\a\]\ \[\e[1;37m\e[42m\]\u@\H\[\e[0m\] \ > \[\033[1;30m\]$(date "+%Y/%m/%d %H:%M:%S")\[\033[0m\] \ \[\e[0;37m\]\s\V t:\l > j:\j \ d:${SHLVL} pp:${PPID} p:$$ ut`cat /proc/uptime |

Re: [PATCH] Add active mark, face support; activate mark on paste

Apr 11, 2020, 17:19 by chet.ra...@case.edu: > On 4/11/20 8:43 AM, gentoo_esh...@tutanota.com wrote: > >> It silently segfaults when pasting a line of text twice(or a long enough >> line once), seems to be length dependent, unsure. >> >> Removing commit

Re: [PATCH] Add active mark, face support; activate mark on paste

On 4/11/20 8:43 AM, gentoo_esh...@tutanota.com wrote: > It silently segfaults when pasting a line of text twice(or a long enough line > once), seems to be length dependent, unsure. > > Removing commit ea31c00845c858098d232bd014bf27b5a63a668b from only the file > lib/readline/display.c  works

Re: [PATCH] Add active mark, face support; activate mark on paste

> On 3/25/20 4:18 PM, Daniel Colascione wrote:> > >> I haven't touched the face > code in display.c. I'd like to find a simpler> >> way to do it: the patch > seems to have a lot of overhead and adds more> >> complexity than I'd like at > a time when I'm trying to make the redisplay> >> code

Re: [PATCH] Add active mark, face support; activate mark on paste

On 3/25/20 4:18 PM, Daniel Colascione wrote: >> I haven't touched the face code in display.c. I'd like to find a simpler >> way to do it: the patch seems to have a lot of overhead and adds more >> complexity than I'd like at a time when I'm trying to make the redisplay >> code simpler. I don't

Re: [PATCH] Add active mark, face support; activate mark on paste

> On 3/25/20 1:14 PM, Daniel Colascione wrote: > >> Ping? Anything I can do to help? > > OK, I sat down and looked at this code, since I'm homebound. I added the > active mark/region features (rl_activate_mark/rl_deactivate_mark/etc.) > and a couple of the smaller pieces (_rl_cr, the so/se

Re: [PATCH] Add active mark, face support; activate mark on paste

On 3/25/20 1:14 PM, Daniel Colascione wrote: > Ping? Anything I can do to help? OK, I sat down and looked at this code, since I'm homebound. I added the active mark/region features (rl_activate_mark/rl_deactivate_mark/etc.) and a couple of the smaller pieces (_rl_cr, the so/se sequences). Can

Re: [PATCH] Add active mark, face support; activate mark on paste

On Fri, Jan 10, 2020 at 5:34 AM Chet Ramey wrote: > > On 1/8/20 2:38 PM, Daniel Colascione wrote: > > On Tue, Sep 24, 2019 at 10:20 PM Daniel Colascione > > wrote: > >> > >> On Mon, Sep 23, 2019 at 6:36 AM Chet Ramey wrote: > >>> > >>> On 9/23/19 7:32 AM, Daniel Colascione wrote: > On

Re: [PATCH] Add active mark, face support; activate mark on paste

On 1/8/20 2:38 PM, Daniel Colascione wrote: On Tue, Sep 24, 2019 at 10:20 PM Daniel Colascione wrote: On Mon, Sep 23, 2019 at 6:36 AM Chet Ramey wrote: On 9/23/19 7:32 AM, Daniel Colascione wrote: On Wed, Jan 9, 2019 at 12:37 PM Chet Ramey wrote: On 1/9/19 2:39 PM, Daniel Colascione

Re: [PATCH] Add active mark, face support; activate mark on paste

On Tue, Sep 24, 2019 at 10:20 PM Daniel Colascione wrote: > > On Mon, Sep 23, 2019 at 6:36 AM Chet Ramey wrote: > > > > On 9/23/19 7:32 AM, Daniel Colascione wrote: > > > On Wed, Jan 9, 2019 at 12:37 PM Chet Ramey wrote: > > >> > > >> On 1/9/19 2:39 PM, Daniel Colascione wrote: > > >>> Any

Re: [PATCH] Add active mark, face support; activate mark on paste

On Mon, Sep 23, 2019 at 6:36 AM Chet Ramey wrote: > > On 9/23/19 7:32 AM, Daniel Colascione wrote: > > On Wed, Jan 9, 2019 at 12:37 PM Chet Ramey wrote: > >> > >> On 1/9/19 2:39 PM, Daniel Colascione wrote: > >>> Any chance we can revive this patch now that Bash 5 is out? (The patch > >>>

Re: [PATCH] Add active mark, face support; activate mark on paste

On 9/23/19 7:32 AM, Daniel Colascione wrote: > On Wed, Jan 9, 2019 at 12:37 PM Chet Ramey wrote: >> >> On 1/9/19 2:39 PM, Daniel Colascione wrote: >>> Any chance we can revive this patch now that Bash 5 is out? (The patch >>> itself, of course, would need to be rebased.) >> >> Yes, I plan to. >

Re: [PATCH] Add active mark, face support; activate mark on paste

On Wed, Jan 9, 2019 at 12:37 PM Chet Ramey wrote: > > On 1/9/19 2:39 PM, Daniel Colascione wrote: > > Any chance we can revive this patch now that Bash 5 is out? (The patch > > itself, of course, would need to be rebased.) > > Yes, I plan to. Have you had a chance to look at the patch?

Re: [PATCH] Add active mark, face support; activate mark on paste

On 1/9/19 2:39 PM, Daniel Colascione wrote: > Any chance we can revive this patch now that Bash 5 is out? (The patch > itself, of course, would need to be rebased.) Yes, I plan to. -- ``The lyf so short, the craft so long to lerne.'' - Chaucer ``Ars longa, vita brevis'' -

Re: [PATCH] Add active mark, face support; activate mark on paste

Any chance we can revive this patch now that Bash 5 is out? (The patch itself, of course, would need to be rebased.) On Fri, Jun 8, 2018 at 9:27 AM Chet Ramey wrote: > > On 6/7/18 10:45 PM, Daniel Colascione wrote: > > Hey. I'd appreciate a quick peek at this patch. The lack of visual feedback >

Re: [PATCH] Add active mark, face support; activate mark on paste

On 6/7/18 10:45 PM, Daniel Colascione wrote: > Hey. I'd appreciate a quick peek at this patch. The lack of visual feedback > on paste is leading people to turn off bracketed paste mode, which is > unfortunate. I've looked at it briefly. I have not had time to put it into the devel branch yet;

Re: [PATCH] Add active mark, face support; activate mark on paste

Hey. I'd appreciate a quick peek at this patch. The lack of visual feedback on paste is leading people to turn off bracketed paste mode, which is unfortunate. On Mon, Mar 19, 2018 at 11:06 AM, Chet Ramey wrote: > On 3/19/18 1:25 PM, Daniel Colascione wrote: > > Ping > > I haven't looked at it

Re: [PATCH] Add active mark, face support; activate mark on paste

On 3/19/18 1:25 PM, Daniel Colascione wrote: > Ping I haven't looked at it closely yet; trying to get bugs and tests done before starting the 5.0-alpha release cycle. Chet -- ``The lyf so short, the craft so long to lerne.'' - Chaucer ``Ars longa, vita brevis'' - Hippocrates

Re: [PATCH] Add active mark, face support; activate mark on paste

Ping On Fri, Mar 9, 2018 at 11:50 PM, Daniel Colascione wrote: > This patch teaches readline about two concepts from Emacs: 1) faces, > and 2) the mark being "active". Both exist in rudimentary form: we > support exactly two faces, normal and "standout", and use standout to >

[PATCH] Add active mark, face support; activate mark on paste

This patch teaches readline about two concepts from Emacs: 1) faces, and 2) the mark being "active". Both exist in rudimentary form: we support exactly two faces, normal and "standout", and use standout to highlight the contents of the region when the mark is active. Readline redisplay is now