Re: [PATCH] fix problem with uconvert

2022-10-25 Thread Isabella Bosia
Dunno if it's "considerably easier", my patch just added 1 sign argument to 1 function and fixed up a couple of call sites. Your way is shorter but it boils down to "if the micro-part is negative it means that the number was in (-1,0)", which for some reason was already being checked for despite

Re: [PATCH] fix problem with uconvert

2022-10-24 Thread Chet Ramey
On 10/22/22 2:58 PM, izabera wrote: if the argument is in the (-1, 0) range, the integer part is zero and multiplying it by -1 has no effect, so the caller can't tell that the argument was negative I suggest that a considerably easier way to solve this is ***

[PATCH] fix problem with uconvert

2022-10-23 Thread izabera
if the argument is in the (-1, 0) range, the integer part is zero and multiplying it by -1 has no effect, so the caller can't tell that the argument was negative --- builtins/read.def | 10 +- examples/loadables/sleep.c | 4 ++-- externs.h | 2 +-