Re: Bash 5.1 fails parallel builds from source
Emanuel Haupt wrote: > On 12/7/20 1:44 PM, Fazal Majid wrote: > >> On Dec 7, 2020, at 15:37, Chet Ramey wrote: > >> > >> Thanks for the report. I've never actually encountered this error. > >> Just lucky, I guess. > > > > It’s a race condition. The machine I run it on has 6 cores and HT, > > so I run it with a `make -j 12`, and even then, it’s not > > consistently reproducible. > > Sure. I run make -j 4 at a minimum, make -j 8 sometimes, and I've > never seen it. Not very reproducible. Shortly after updating the FreeBSD port I received quite a few reports about this. Although I wasn't able to reproduce the error myself it appears that gentoo solved the race condition with this patch: https://gitweb.gentoo.org/repo/gentoo.git/tree/app-shells/bash/files/bash-5.1-parallel_make.patch?id=4c2ebbf4b8bc660beb98cc2d845c73375d6e4f50 It's been confirmed to have solved the issue: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=251755 Emanuel
Re: Bash 5.1 fails parallel builds from source
On 12/7/20 1:44 PM, Fazal Majid wrote: On Dec 7, 2020, at 15:37, Chet Ramey wrote: Thanks for the report. I've never actually encountered this error. Just lucky, I guess. It’s a race condition. The machine I run it on has 6 cores and HT, so I run it with a `make -j 12`, and even then, it’s not consistently reproducible. Sure. I run make -j 4 at a minimum, make -j 8 sometimes, and I've never seen it. Not very reproducible. -- ``The lyf so short, the craft so long to lerne.'' - Chaucer ``Ars longa, vita brevis'' - Hippocrates Chet Ramey, UTech, CWRUc...@case.eduhttp://tiswww.cwru.edu/~chet/
Re: Bash 5.1 fails parallel builds from source
> On Dec 7, 2020, at 15:37, Chet Ramey wrote: > > On 12/7/20 7:31 AM, Fazal Majid wrote: >> I occasionally encounter the error: >> gcc -DPROGRAM='"bash"' -DCONF_HOSTTYPE='"x86_64"' >> -DCONF_OSTYPE='"linux-musl"' -DCONF_MACHTYPE='"x86_64-pc-linux-musl"' >> -DCONF_VENDOR='"pc"' -DLOCALEDIR='"/usr/local/share/locale"' >> -DPACKAGE='"bash"' -DSHELL -DHAVE_CONFIG_H -I. -I. -I./include -I./lib >> -g -O2 -Wno-parentheses -Wno-format-security -c list.c >> bashline.c:65:10: fatal error: builtins/builtext.h: No such file or directory >>65 | #include "builtins/builtext.h" /* for read_builtin */ >> | ^ >> compilation terminated. >> That's because bashline.o does not have a dependency on builtins/builtext.h >> in Makefile, unlike sig,o, subst.o etc > > Thanks for the report. I've never actually encountered this error. Just > lucky, I guess. It’s a race condition. The machine I run it on has 6 cores and HT, so I run it with a `make -j 12`, and even then, it’s not consistently reproducible. -- Fazal Majidwww.majid.info
Re: Bash 5.1 fails parallel builds from source
On 12/7/20 7:31 AM, Fazal Majid wrote: I occasionally encounter the error: gcc -DPROGRAM='"bash"' -DCONF_HOSTTYPE='"x86_64"' -DCONF_OSTYPE='"linux-musl"' -DCONF_MACHTYPE='"x86_64-pc-linux-musl"' -DCONF_VENDOR='"pc"' -DLOCALEDIR='"/usr/local/share/locale"' -DPACKAGE='"bash"' -DSHELL -DHAVE_CONFIG_H -I. -I. -I./include -I./lib-g -O2 -Wno-parentheses -Wno-format-security -c list.c bashline.c:65:10: fatal error: builtins/builtext.h: No such file or directory 65 | #include "builtins/builtext.h" /* for read_builtin */ | ^ compilation terminated. That's because bashline.o does not have a dependency on builtins/builtext.h in Makefile, unlike sig,o, subst.o etc Thanks for the report. I've never actually encountered this error. Just lucky, I guess. -- ``The lyf so short, the craft so long to lerne.'' - Chaucer ``Ars longa, vita brevis'' - Hippocrates Chet Ramey, UTech, CWRUc...@case.eduhttp://tiswww.cwru.edu/~chet/
Bash 5.1 fails parallel builds from source
I occasionally encounter the error: gcc -DPROGRAM='"bash"' -DCONF_HOSTTYPE='"x86_64"' -DCONF_OSTYPE='"linux-musl"' -DCONF_MACHTYPE='"x86_64-pc-linux-musl"' -DCONF_VENDOR='"pc"' -DLOCALEDIR='"/usr/local/share/locale"' -DPACKAGE='"bash"' -DSHELL -DHAVE_CONFIG_H -I. -I. -I./include -I./lib-g -O2 -Wno-parentheses -Wno-format-security -c list.c bashline.c:65:10: fatal error: builtins/builtext.h: No such file or directory 65 | #include "builtins/builtext.h" /* for read_builtin */ | ^ compilation terminated. That's because bashline.o does not have a dependency on builtins/builtext.h in Makefile, unlike sig,o, subst.o etc -- Fazal Majid www.majid.info
