Re: [PATCH] Fix hang if $OLDPWD points to inaccessible directory

2017-10-01 Thread Mikulas Patocka
On Sat, 30 Sep 2017, L A Walsh wrote: > > > Mikulas Patocka wrote: > > I don't set up OLDPWD in /etc/profile. > --- >No one does -- unless someone is trying to cause mischief. It's not > a likely event, but it would be annoying if someone did it. >But, FWIW, -- it seems like not

Re: [PATCH] Fix hang if $OLDPWD points to inaccessible directory

2017-10-01 Thread Chet Ramey
On 9/30/17 4:20 AM, Mikulas Patocka wrote: > Is there some reason why do we need to check if $OLDPWD is a real > directory? dash and ksh accept the $OLDPWD variable, but don't poke it > with the stat syscall. zsh clears $OLDPWD. It makes no sense to inherit it if it doesn't name a directory

Bash should reset OLDPWD upon login, *only*.

2017-10-01 Thread L A Walsh
Mikulas Patocka wrote: The problem occurs even in non-login shells - the chrome browser is started from a bash script, on some distributions firefox is also started from a bash script, mail daemon may start a script specified in user's ".forward" file. And these scripts also poke $OLDPWD

Re: RFE & RFC: testing executability

2017-10-01 Thread Pierre Gaston
On Sun, Oct 1, 2017 at 7:31 AM, L A Walsh wrote: > I was looking at a script that tested command for execute before > executing them. > The script used: > > cmd=$(PATH=/stdpath type -p cmd) > > and later tested executability with "-x $cmd", raising 2 problems. The > first was