On Sun, Mar 4, 2018 at 5:15 AM, don fong wrote:
> admittedly this is a very minor point, but i am curious. this has to do
> with coding standards for bash source.
>
> consider an if statement in C (or bash, for that matter). which is form is
> better?
>
> Form (A):
>
> if (flag)
> X
On 3/2/18 4:45 PM, don fong wrote:
> Chet, thanks for the explanation about CHANGES. i am not familiar with the
> bash release process.
>
> as for this:
>
>> I didn't think the tests were necessary.
>
> what standard are you using to judge whether tests are necessary? does the
> bash project
On 3/4/18 7:43 AM, Clark Wang wrote:
>> i submitted a patch with code in form (A). it was added to the code base
>> in form (B). was there a good reason for this mutation?
>>
>
> I believe the main reason is to keep consistent with existing code.
That, plus the final change was smaller and sim
On 3/3/18 2:23 AM, Robert Elz wrote:
> Date:Fri, 2 Mar 2018 14:43:02 -0500
> From:Chet Ramey
> Message-ID: <4502a0e5-0600-d294-9af2-4e9eeb0a0...@case.edu>
>
> My final comments on this subject:
Mine, too.
>
> | Perhaps. But bash has never done this. Not from day
Configuration Information [Automatically generated, do not change]:
Machine: x86_64
OS: darwin16.7.0
Compiler: clang
Compilation CFLAGS: -DPROGRAM='bash' -DCONF_HOSTTYPE='x86_64'
-DCONF_OSTYPE='darwin16.7.0' -DCONF_MACHTYPE='x86_64-apple-darwin16.7.0'
-DCONF_VENDOR='apple'
-DLOCALEDIR='/usr/local/
Clark, thanks for your answer.
I use ``if (flag)'' only when `flag' is a boolean.
but in this case, it *is* a boolean, as i stated, and as can be seen in
subst.c:
+{
+ if (check_nullness)
+ report_error (_("%s: parameter null or not set"), name);
+ else
+ report_
On 3/4/18 6:15 PM, Zach Hadgraft wrote:
> Bash Version: 4.4
> Patch Level: 19
> Release Status: release
>
> Description:
> global variable assignments fail when part of a sequence that
> includes read and begins with a function invoked by command substitution
> read can be invoked
On Mon, Mar 5, 2018 at 9:13 AM, don fong wrote:
> Clark, thanks for your answer.
>
> I use ``if (flag)'' only when `flag' is a boolean.
>
>
> but in this case, it *is* a boolean, as i stated, and as can be seen in
> subst.c:
>
> +{
> + if (check_nullness)
> + report_error (_("%s
