Re: bash: Correct usage of F_SETFD

2010-11-23 Thread Sukadev Bhattiprolu
Eric Blake [ebl...@redhat.com] wrote: | | So if bash is the one creating its file descriptors, there's no need to | use R/M/W since it knows what the state of them are. | | No, bash cannot reasonably know what the implementation's default bit | state is, and blindly setting all other bits to

Re: bash: Correct usage of F_SETFD

2010-11-23 Thread Matthew Wilcox
On Mon, Nov 22, 2010 at 04:04:46PM -0800, Sukadev Bhattiprolu wrote: Eric Blake [ebl...@redhat.com] wrote: | On 11/22/2010 03:16 PM, Chet Ramey wrote: | include/filecntl.h in bash-4.1 has following: | | #define SET_CLOSE_ON_EXEC(fd) (fcntl ((fd), F_SETFD, FD_CLOEXEC)) | | Is that

Re: bash: Correct usage of F_SETFD

2010-11-22 Thread Chet Ramey
include/filecntl.h in bash-4.1 has following: #define SET_CLOSE_ON_EXEC(fd) (fcntl ((fd), F_SETFD, FD_CLOEXEC)) Is that really the correct/intended usage of F_SETFD ? F_SETFDSet the close-on-exec flag associated with fildes to the low order bit of

Re: bash: Correct usage of F_SETFD

2010-11-22 Thread Eric Blake
On 11/22/2010 03:16 PM, Chet Ramey wrote: include/filecntl.h in bash-4.1 has following: #define SET_CLOSE_ON_EXEC(fd) (fcntl ((fd), F_SETFD, FD_CLOEXEC)) Is that really the correct/intended usage of F_SETFD ? F_SETFDSet the close-on-exec flag associated with fildes to