[Bug binutils/22829] objcopy/strip removes PT_GNU_RELRO from lld binaries

2020-02-24 Thread ngg at tresorit dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=22829 --- Comment #13 from NGG --- (In reply to Fangrui Song from comment #12) > The lld issue was introduced by https://reviews.llvm.org/rL291523 > and was fixed by https://reviews.llvm.org/D56828 . > It affected lld [4.0,8.0). Before 8.0, lld

[Bug binutils/22829] objcopy/strip: PT_GNU_RELRO is removed when it's not placed before read-only section

2018-02-12 Thread ngg at tresorit dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=22829 --- Comment #9 from NGG --- The second patch works in all the cases I've tried, thanks! -- You are receiving this mail because: You are on the CC list for the bug. ___ bug-binutils mailing list

[Bug binutils/22829] objcopy/strip: PT_GNU_RELRO is removed when it's not placed before read-only section

2018-02-11 Thread ngg at tresorit dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=22829 --- Comment #7 from NGG --- Thank you for the quick response and patch proposal. Sorry for overreacting. I assigned it to critical due to its possible security implications and because of the wide range of products it might affect. I should

[Bug binutils/22829] objcopy/strip: PT_GNU_RELRO is removed when it's not placed before read-only section

2018-02-11 Thread ngg at tresorit dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=22829 --- Comment #5 from NGG --- This is not an enhancement request, it is clearly a bug. The ELF header is perfectly valid the way lld creates it, and strip reduces its security. This is why Chromium on Android switched to elfutils strip (see

[Bug binutils/22829] objcopy/strip: PT_GNU_RELRO is removed when it's not at the beginning of a PT_LOAD area

2018-02-10 Thread ngg at tresorit dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=22829 --- Comment #2 from NGG --- Created attachment 10802 --> https://sourceware.org/bugzilla/attachment.cgi?id=10802=edit sample binary created with lld This sample was generated with clang and lld (version 5.0.1) like this: clang

[Bug binutils/22829] objcopy/strip: PT_GNU_RELRO is removed when it's not at the beginning of a PT_LOAD area

2018-02-10 Thread ngg at tresorit dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=22829 NGG changed: What|Removed |Added CC||ngg at tresorit dot com -- You are receiving

[Bug binutils/22829] New: objcopy/strip: PT_GNU_RELRO is removed when it's not at the beginning of a PT_LOAD area

2018-02-10 Thread ngg at tresorit dot com
: UNCONFIRMED Severity: critical Priority: P2 Component: binutils Assignee: unassigned at sourceware dot org Reporter: ngg at tresorit dot com Target Milestone: --- The assign_file_positions_for_non_load_sections() function in bfd/elf.c removes

[Bug gold/17704] icf doesn't respect section alignment

2016-01-17 Thread ngg at tresorit dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=17704 NGG changed: What|Removed |Added CC||ngg at tresorit dot com -- You are receiving

[Bug gold/18865] ICF --keep-unique doesn't work correctly

2016-01-17 Thread ngg at tresorit dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=18865 NGG changed: What|Removed |Added CC||ngg at tresorit dot com -- You are receiving

[Bug gold/17704] icf doesn't respect section alignment

2016-01-17 Thread ngg at tresorit dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=17704 --- Comment #2 from NGG --- Created attachment 8906 --> https://sourceware.org/bugzilla/attachment.cgi?id=8906=edit Patch for icf section alignment bug I think this patch solves this bug, the provided examples work and gn works too in the