[Bug binutils/23107] 'ar t' doesn't display object file offsets

2018-05-30 Thread ant.bikineev at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=23107

--- Comment #8 from ant.bikineev at gmail dot com  ---
> Thanks for taking the time to push this enhancement through.
My pleasure, thanks for reviewing this!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug binutils/23107] 'ar t' doesn't display object file offsets

2018-05-30 Thread nickc at redhat dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=23107

Nick Clifton  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #7 from Nick Clifton  ---
Hi Ant,

  Sorry for taking so long to get around to reviewing your patch.  I have
  now gone through it, found no problems and committed it to the repository.

  Thanks for taking the time to push this enhancement through.

Cheers
  Nick

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug binutils/23107] 'ar t' doesn't display object file offsets

2018-05-30 Thread cvs-commit at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=23107

--- Comment #6 from cvs-commit at gcc dot gnu.org  ---
The master branch has been updated by Nick Clifton :

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=1869e86f2eb13a9e1d1c42b97cdb98fef88afd83

commit 1869e86f2eb13a9e1d1c42b97cdb98fef88afd83
Author: Ant Bikeneev 
Date:   Wed May 30 17:06:26 2018 +0100

Add option to ar's 't' command to display the offset of elements within the
archive.

PR 23107
* ar.c (display_offsets): New variable.
(usage): Add description of 'O' operator.
(decode_option): Handle 'O' operator.
(print_descr): Pass display_offsets to print_arelt_descr.
* arsup.c: Update call to printy_arelt_descr.
* objdump.c: Likewise.
* bucomm.c (print_arelt_descr): If offsets parameter is true then
display offset of archive element within the archive.
* bucomm.h: Update prototype for print_arelt_descr.
* doc/binutils.texi: Update description of ar command.
* NEWS: Mention the new feature.
* testsuite/binutils-all/ar.exp: Add text of new feature.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug binutils/23107] 'ar t' doesn't display object file offsets

2018-05-22 Thread nickc at redhat dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=23107

--- Comment #5 from Nick Clifton  ---
Hi Ant,

> --- Comment #4 from ant.bikineev at gmail dot com  com> ---
> ping...

Sorry - I am on vacation at the moment - but I will look at your new patch as
soon as I get back

Cheers
  Nick

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug binutils/23107] 'ar t' doesn't display object file offsets

2018-05-21 Thread ant.bikineev at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=23107

--- Comment #4 from ant.bikineev at gmail dot com  ---
ping...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug binutils/23107] 'ar t' doesn't display object file offsets

2018-05-18 Thread ant.bikineev at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=23107

ant.bikineev at gmail dot com  changed:

   What|Removed |Added

  Attachment #10972|0   |1
is obsolete||
 CC||ant.bikineev at gmail dot com

--- Comment #3 from ant.bikineev at gmail dot com  ---
Created attachment 11027
  --> https://sourceware.org/bugzilla/attachment.cgi?id=11027&action=edit
The newer patch

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug binutils/23107] 'ar t' doesn't display object file offsets

2018-05-18 Thread ant.bikineev at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=23107

--- Comment #2 from ant.bikineev at gmail dot com  ---
Hi Nick!

> Would you care to update your patch to do this ?

Sure, I've just updated the changes in accordance with your notes. Thanks for
them.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils



[Bug binutils/23107] 'ar t' doesn't display object file offsets

2018-05-17 Thread nickc at redhat dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=23107

Nick Clifton  changed:

   What|Removed |Added

 CC||nickc at redhat dot com

--- Comment #1 from Nick Clifton  ---
Hi Ant,

  [Sorry for the long delay in responding to this PR].

> I was looking for a way to display offsets of the object files in an archive
> using ar, but apparently there is none the tool provides. I've prepared and
> attached a patch that fixes it, yet I'm not sure that offsets should be
> displayed in the non-verbose mode.
> 
> What do you think?

I like the idea, but I think that it should be controlled by a new command
line option, which would be off by default.  Would you care to update your 
patch to do this ?  Note - doing so no only involves changing the code, but
also updating the documentation (binutils/doc/binutils.texi), the NEWS file
(binutils/NEWS) and, ideally, adding a binutils test as well
(binutils/testsuite/binutils-all/).

Cheers
  Nick

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils