[Bug binutils/26082] infinite loop in windmc
https://sourceware.org/bugzilla/show_bug.cgi?id=26082 Nick Clifton changed: What|Removed |Added Resolution|--- |FIXED Status|REOPENED|RESOLVED --- Comment #17 from Nick Clifton --- Patch applied. -- You are receiving this mail because: You are on the CC list for the bug.
[Bug binutils/26082] infinite loop in windmc
https://sourceware.org/bugzilla/show_bug.cgi?id=26082 --- Comment #16 from cvs-commit at gcc dot gnu.org --- The master branch has been updated by Nick Clifton : https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=25065fcd192d9958c03e107985aea41d651e4a16 commit 25065fcd192d9958c03e107985aea41d651e4a16 Author: Ralf Habacker Date: Wed Jun 10 10:07:26 2020 +0100 Fix the windmc program to conform to the behaviour of mc.exe by rejecting lines that reach end-of-file without a terminating newline character. PR 26082 * mclex.c (yylex): Reject lines that reach end-of-file without a terminating newline character. -- You are receiving this mail because: You are on the CC list for the bug.
[Bug binutils/26082] infinite loop in windmc
https://sourceware.org/bugzilla/show_bug.cgi?id=26082 --- Comment #15 from Ralf Habacker --- Created attachment 12609 --> https://sourceware.org/bugzilla/attachment.cgi?id=12609=edit 0001-windmc-Reject-EOF-without-line-break.patch Converted attachment 12605 to a git formatted patch. BTW: attachment 12605 was not tagged as patch, so I cannot tag it as "superseeded" -- You are receiving this mail because: You are on the CC list for the bug.
[Bug binutils/26082] infinite loop in windmc
https://sourceware.org/bugzilla/show_bug.cgi?id=26082 Ralf Habacker changed: What|Removed |Added Blocks||26088 Referenced Bugs: https://sourceware.org/bugzilla/show_bug.cgi?id=26088 [Bug 26088] windmc reports incorrect line numbers -- You are receiving this mail because: You are on the CC list for the bug.
[Bug binutils/26082] infinite loop in windmc
https://sourceware.org/bugzilla/show_bug.cgi?id=26082 --- Comment #14 from Ralf Habacker --- (In reply to Nick Clifton from comment #12) > Created attachment 12605 [details] Hi Nick, looks good to me, except on spelling error in a comment 326-: /* Skip characters in input_stram_pos up to and including a newline 326+: /* Skip characters in input_stream_pos up to and including a newline -- You are receiving this mail because: You are on the CC list for the bug.
[Bug binutils/26082] infinite loop in windmc
https://sourceware.org/bugzilla/show_bug.cgi?id=26082 --- Comment #13 from Joel Anderson --- I think that patch looks great! It is more readable than the current HEAD, the intent is much clearer, and it is consistent with mc.exe behavior in both scenarios. -- You are receiving this mail because: You are on the CC list for the bug.
[Bug binutils/26082] infinite loop in windmc
https://sourceware.org/bugzilla/show_bug.cgi?id=26082 Nick Clifton changed: What|Removed |Added Assignee|unassigned at sourceware dot org |nickc at redhat dot com Ever confirmed|0 |1 Last reconfirmed||2020-06-09 Status|RESOLVED|REOPENED Resolution|FIXED |--- --- Comment #12 from Nick Clifton --- Created attachment 12605 --> https://sourceware.org/bugzilla/attachment.cgi?id=12605=edit Proposed patch Hi Ralfm Hi Joel, OK, so let me see if I have this right - windmc should reject "." or any line that reaches end-of-file without having a terminating newline character ? If that is right - they what do you think of this reformatted patch ? It is made from the previous two patches, but changed to reject ".". Is this what you had in mind ? Cheers Nick -- You are receiving this mail because: You are on the CC list for the bug.
[Bug binutils/26082] infinite loop in windmc
https://sourceware.org/bugzilla/show_bug.cgi?id=26082 --- Comment #11 from Ralf Habacker --- (In reply to Joel Anderson from comment #10) > this suggests that this has been the > functionality for at least a very long time. Thanks for this info. > Considering this hasn't been allowed in mc.exe for quite a while (since > Windows 7) and resulted in an infinite loop on windmc until this patch, > suspect there aren't many projects relying on it? I agree, thanks for your work. -- You are receiving this mail because: You are on the CC list for the bug.
[Bug binutils/26082] infinite loop in windmc
https://sourceware.org/bugzilla/show_bug.cgi?id=26082 Ralf Habacker changed: What|Removed |Added Attachment #12595|0 |1 is obsolete|| -- You are receiving this mail because: You are on the CC list for the bug.
[Bug binutils/26082] infinite loop in windmc
https://sourceware.org/bugzilla/show_bug.cgi?id=26082 --- Comment #10 from Joel Anderson --- (In reply to Ralf Habacker from comment #8) > Can you say from which version on this behavior was changed ? I just tested with the executable packaged with the Windows SDK for Windows 7 (7.1) and found that it rejects the attached EOF sample. I don't have the time to go farther back, but this suggests that this has been the functionality for at least a very long time. > This change means that projects using the old style would have to adjust the > corresponding files, which for example requires additional maintenance work > for the Mingw maintainers at opensuse to patch all affected packages and > report this change to the corresponding projects. Considering this hasn't been allowed in mc.exe for quite a while (since Windows 7) and resulted in an infinite loop on windmc until this patch, I suspect there aren't many projects relying on it? Unless I have unintentionally broken something which was previously working, in which case I do apologize. -- You are receiving this mail because: You are on the CC list for the bug.
[Bug binutils/26082] infinite loop in windmc
https://sourceware.org/bugzilla/show_bug.cgi?id=26082 Ralf Habacker changed: What|Removed |Added Blocks|26088 | Referenced Bugs: https://sourceware.org/bugzilla/show_bug.cgi?id=26088 [Bug 26088] windmc reports incorrect line numbers -- You are receiving this mail because: You are on the CC list for the bug.
[Bug binutils/26082] infinite loop in windmc
https://sourceware.org/bugzilla/show_bug.cgi?id=26082 Ralf Habacker changed: What|Removed |Added Attachment #12596|0 |1 is obsolete|| --- Comment #9 from Ralf Habacker --- Comment on attachment 12596 --> https://sourceware.org/bugzilla/attachment.cgi?id=12596 0002-Fix-catching-EOF-in-the-Windows-resource-parser.patch Need to be updated -- You are receiving this mail because: You are on the CC list for the bug.
[Bug binutils/26082] infinite loop in windmc
https://sourceware.org/bugzilla/show_bug.cgi?id=26082 --- Comment #8 from Ralf Habacker --- (In reply to Joel Anderson from comment #7) > I do think that it is important to note that the two new patches alter > windmc behavior to accept a file where the period is immediately followed by > a EOF instead of a newline or carriage return and newline. Thanks for this pointer. > These types of files are rejected by current versions of mc.exe, Can you say from which version on this behavior was changed ? > which is what I was using the 'premature EOF' attachment to test against > myself. This change means that projects using the old style would have to adjust the corresponding files, which for example requires additional maintenance work for the Mingw maintainers at opensuse to patch all affected packages and report this change to the corresponding projects. > While the new patches are more forgiving to the user and perhaps a better > way to handle the scenario, they do not match mc.exe behavior. > I can see arguments for both cases, but just want to make sure that it is a > deliberate choice to deviate windmc's behavior from that of mc.exe. I think the best would be to extend windmc with an additional command line option to require exact mc compatibility. Projects can use this switch to make sure that only input files compatible to mc are usable. Without this switch, the "windmc" specific extensions would be enabled by default, but a warning is displayed that these files may not be compatible with mc. Project maintainers can then decide whether or not to modify these files accordingly. -- You are receiving this mail because: You are on the CC list for the bug.
[Bug binutils/26082] infinite loop in windmc
https://sourceware.org/bugzilla/show_bug.cgi?id=26082 --- Comment #7 from Joel Anderson --- I do think that it is important to note that the two new patches alter windmc behavior to accept a file where the period is immediately followed by a EOF instead of a newline or carriage return and newline. These types of files are rejected by current versions of mc.exe, which is what I was using the 'premature EOF' attachment to test against myself. While the new patches are more forgiving to the user and perhaps a better way to handle the scenario, they do not match mc.exe behavior. I can see arguments for both cases, but just want to make sure that it is a deliberate choice to deviate windmc's behavior from that of mc.exe. -- You are receiving this mail because: You are on the CC list for the bug.
[Bug binutils/26082] infinite loop in windmc
https://sourceware.org/bugzilla/show_bug.cgi?id=26082 Ralf Habacker changed: What|Removed |Added Blocks||26088 Referenced Bugs: https://sourceware.org/bugzilla/show_bug.cgi?id=26088 [Bug 26088] windmc reports incorrect line numbers -- You are receiving this mail because: You are on the CC list for the bug.
[Bug binutils/26082] infinite loop in windmc
https://sourceware.org/bugzilla/show_bug.cgi?id=26082 --- Comment #6 from Ralf Habacker --- Created attachment 12596 --> https://sourceware.org/bugzilla/attachment.cgi?id=12596=edit 0002-Fix-catching-EOF-in-the-Windows-resource-parser.patch This patch fixes the remaining, not catched EOF conditions. -- You are receiving this mail because: You are on the CC list for the bug.
[Bug binutils/26082] infinite loop in windmc
https://sourceware.org/bugzilla/show_bug.cgi?id=26082 Ralf Habacker changed: What|Removed |Added CC||ralf.habacker at freenet dot de --- Comment #5 from Ralf Habacker --- Created attachment 12595 --> https://sourceware.org/bugzilla/attachment.cgi?id=12595=edit 0001-Fix-parse-error-in-the-Windows-resource-parser.patch Patch which fixes the remaining parse error. It was initial added to https://bugzilla.opensuse.org/show_bug.cgi?id=920134 -- You are receiving this mail because: You are on the CC list for the bug.
[Bug binutils/26082] infinite loop in windmc
https://sourceware.org/bugzilla/show_bug.cgi?id=26082 Nick Clifton changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED CC||nickc at redhat dot com --- Comment #4 from Nick Clifton --- Hi Joel, Thanks for reporting this bug - and for supplying a fix. I have checked in your patch so I hope that this issue is now resolved. Cheers Nick -- You are receiving this mail because: You are on the CC list for the bug.
[Bug binutils/26082] infinite loop in windmc
https://sourceware.org/bugzilla/show_bug.cgi?id=26082 --- Comment #3 from cvs-commit at gcc dot gnu.org --- The master branch has been updated by Nick Clifton : https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=8affa48ac7c55ade04713654a22f1c56319b1195 commit 8affa48ac7c55ade04713654a22f1c56319b1195 Author: Joel Anderson Date: Fri Jun 5 11:11:03 2020 +0100 Fix a potential infinite loop in the Windows resource parser. PR 26082 * mclex.c (yylex): Add test for an empty input stream. -- You are receiving this mail because: You are on the CC list for the bug.
[Bug binutils/26082] infinite loop in windmc
https://sourceware.org/bugzilla/show_bug.cgi?id=26082 --- Comment #2 from Joel Anderson --- Created attachment 12592 --> https://sourceware.org/bugzilla/attachment.cgi?id=12592=edit proposed patch -- You are receiving this mail because: You are on the CC list for the bug.
[Bug binutils/26082] infinite loop in windmc
https://sourceware.org/bugzilla/show_bug.cgi?id=26082 --- Comment #1 from Joel Anderson --- Created attachment 12591 --> https://sourceware.org/bugzilla/attachment.cgi?id=12591=edit message with premature EOF -- You are receiving this mail because: You are on the CC list for the bug.
