[Bug libctf/25120] Portability issues in binutils 2.33 due to libctf
https://sourceware.org/bugzilla/show_bug.cgi?id=25120 Harald van Dijk changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #22 from Harald van Dijk --- binutils 2.35 is out now and I can confirm that the fix works here, it builds fine without the workarounds I needed with 2.33 and 2.34. Thanks! -- You are receiving this mail because: You are on the CC list for the bug.
[Bug libctf/25120] Portability issues in binutils 2.33 due to libctf
https://sourceware.org/bugzilla/show_bug.cgi?id=25120 --- Comment #20 from cvs-commit at gcc dot gnu.org --- The master branch has been updated by Nick Alcock : https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=866706584c6622bd7f9f595c307422771ce1d564 commit 866706584c6622bd7f9f595c307422771ce1d564 Author: Nick Alcock Date: Fri Dec 13 14:54:09 2019 + libctf: work with compilers not supporting GNU C attributes The obvious fallback __attribute__ stanza was missing. Thanks to Harald van Dijk. PR 25120 libctf/ * ctf-impl.h (_libctf_printflike_): Add non-GNU-C fallback. (_libctf_unlikely_): Likewise. (_libctf_unused): Likewise. (_libctf_malloc_): Likewise. -- You are receiving this mail because: You are on the CC list for the bug.
[Bug libctf/25120] Portability issues in binutils 2.33 due to libctf
https://sourceware.org/bugzilla/show_bug.cgi?id=25120 --- Comment #21 from cvs-commit at gcc dot gnu.org --- The master branch has been updated by Nick Alcock : https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=e755667f94f2579056fb5210eed525dafebb96f3 commit e755667f94f2579056fb5210eed525dafebb96f3 Author: Nick Alcock Date: Fri Dec 13 15:19:17 2019 + libctf, elfcpp, gold: do not assume that contains bswap_* At least one C library (uclibc-ng) defines some of these only when the compiler is GCC. We might as well test for all three cases and handle any of them being missing. Very similar code exists in libctf and split between elfcpp and gold: fix both. (Also sync up elfcpp with a change made to libctf swap.h a few months ago: since there is no out-of-line definition of the bswap replacements, they should be declared static inline, not just inline, to prevent the linker generating out-of-line references to them.) PR libctf/25120 libctf/ * configure.ac: Check for bswap_16, bswap_32, and bswap_64 decls. * swap.h (bswap_16): Do not assume that presence of means this is declared. (bswap_32): Likewise. (bswap_64): Likewise. (bswap_identity_64): Remove, unused. * configure: Regenerated. * config.h.in: Likewise. gold/ * configure.ac: Check for bswap_16, bswap_32, and bswap_64 decls. * configure: Regenerated. * config.h.in: Likewise. elfcpp/ * elfcpp_swap.h (bswap_16): Do not assume that presence of means this is declared. Make static inline, matching recent change to libctf, since there is no non-inline definition of these functions. (bswap_32): Likewise. (bswap_64): Likewise. -- You are receiving this mail because: You are on the CC list for the bug.
[Bug libctf/25120] Portability issues in binutils 2.33 due to libctf
https://sourceware.org/bugzilla/show_bug.cgi?id=25120 --- Comment #19 from Nick Alcock --- Sent rebased-and-tested series for review. -- You are receiving this mail because: You are on the CC list for the bug.
[Bug libctf/25120] Portability issues in binutils 2.33 due to libctf
https://sourceware.org/bugzilla/show_bug.cgi?id=25120 --- Comment #18 from Nick Alcock --- I am not dead (and am in fact working on nothing but libctf). Sorry, I fell behind while doing piles of linker dedup work: it was a pain, with at least two designs that fell apart at the last minute, but it's more or less working now, and I'll be getting the terrifying pile of patches that resulted (and this lot, too) into shape after I've knocked the last niggles out of it. -- You are receiving this mail because: You are on the CC list for the bug.
[Bug libctf/25120] Portability issues in binutils 2.33 due to libctf
https://sourceware.org/bugzilla/show_bug.cgi?id=25120 --- Comment #17 from Michael Forney --- Any updates on this? -- You are receiving this mail because: You are on the CC list for the bug.
[Bug libctf/25120] Portability issues in binutils 2.33 due to libctf
https://sourceware.org/bugzilla/show_bug.cgi?id=25120 --- Comment #16 from Nick Alcock --- Clearly I should get back to this. Sorry for the near-complete absence: I've been digging away at obstinate bugs in the CTF deduplicator... -- You are receiving this mail because: You are on the CC list for the bug.
[Bug libctf/25120] Portability issues in binutils 2.33 due to libctf
https://sourceware.org/bugzilla/show_bug.cgi?id=25120 --- Comment #15 from Harald van Dijk --- This became a slightly bigger problem in 2.34: this hits the code that uses __thread in cases where it did not in 2.33, now causing extra problems in environments when __thread is syntactically accepted (gcc) but an attempt to use it fails at run time (x86 uclibc-ng). Linker calls that worked in 2.33 spit out an error in 2.34. -- You are receiving this mail because: You are on the CC list for the bug.
[Bug libctf/25120] Portability issues in binutils 2.33 due to libctf
https://sourceware.org/bugzilla/show_bug.cgi?id=25120 --- Comment #14 from Nick Alcock --- CTF is not ELF-specific. The only intrinsically ELF-specific portion of libctf is the machinery which associates symbol table entries with CTF entries, and that isn't even fully implemented yet (because I haven't got to it). Some things are only implemented for ELF but are perfectly implementable for other executable formats, notably ctf_open() and ctf_fdopen(), and the sharing of strings with the executable's string table. A fix for this is going through review and should probably be applied soon. -- You are receiving this mail because: You are on the CC list for the bug.
[Bug libctf/25120] Portability issues in binutils 2.33 due to libctf
https://sourceware.org/bugzilla/show_bug.cgi?id=25120 Tamar Christina changed: What|Removed |Added CC||tnfchris at sourceware dot org --- Comment #13 from Tamar Christina --- Can we also disable `libctf` for non-elf targets my default? I can't seem to build binutils on Windows (mingw-w64) without hacking libctf out of the source code because of similar issues reported here. But also CTF seems ELF specific so should only be enabled for ELF targets. -- You are receiving this mail because: You are on the CC list for the bug.
[Bug libctf/25120] Portability issues in binutils 2.33 due to libctf
https://sourceware.org/bugzilla/show_bug.cgi?id=25120 Nick Alcock changed: What|Removed |Added Component|binutils|libctf -- You are receiving this mail because: You are on the CC list for the bug.
