Re: finding misplaced changes with git

2008-07-22 Thread Andreas Schwab
Ralf Wildenhues [EMAIL PROTECTED] writes: Hi Jim, all, in a recent commit you write | * HACKING: describe how to find a misplaced change-set | --- a/HACKING | +++ b/HACKING | @@ -360,6 +360,22 @@ Miscellaneous useful git commands |you an interface with which you can reorder

Re: [PATCH] Again, do not change the mode of all directories below $HOME.

2008-07-22 Thread Philip Rowlands
On Tue, 22 Jul 2008, Ralf Wildenhues wrote: * tests/CuTmpdir.pm (chmod_tree): Do not run chmod on undefined argument, can happen when the build path contains spaces. That sounds wrong - there's no magic to unusual characters in filenames other than avoiding passing them unquoted through an

Re: [PATCH] Again, do not change the mode of all directories below $HOME.

2008-07-22 Thread Jim Meyering
Philip Rowlands [EMAIL PROTECTED] wrote: On Tue, 22 Jul 2008, Ralf Wildenhues wrote: * tests/CuTmpdir.pm (chmod_tree): Do not run chmod on undefined argument, can happen when the build path contains spaces. That sounds wrong - there's no magic to unusual characters in filenames other than

Re: [PATCH] ls - colorize files with capabilities

2008-07-22 Thread Kamil Dudka
On Monday 21 July 2008 17:43:52 you wrote: Kamil Dudka [EMAIL PROTECTED] wrote: Don't pessimize your code because doing it cleanly might not work. Have no fear ;-), and do it cleanly. The documentation (man cap_to_text) appears to guarantee the required semantics, so it ought to work. If in

Re: [PATCH] Again, do not change the mode of all directories below $HOME.

2008-07-22 Thread Jim Meyering
Ralf Wildenhues [EMAIL PROTECTED] wrote: * tests/CuTmpdir.pm (chmod_tree): Do not run chmod on undefined argument, can happen when the build path contains spaces. --- this fixes a regression of make check when source and build tree live in a directory with spaces in the name. The regression

Re: [PATCH] ls - colorize files with capabilities

2008-07-22 Thread Kamil Dudka
Changed tests/ls/capability file mode to 0755 in patch - sorry for that mistake, I am new to git... Kamil From 4f14f5e39d7687ddb252f5a7560724179635c944 Mon Sep 17 00:00:00 2001 From: Kamil Dudka [EMAIL PROTECTED] Date: Tue, 22 Jul 2008 12:53:00 +0200 Subject: [PATCH] --color now highlights files

Re: [PATCH] ls - colorize files with capabilities

2008-07-22 Thread Jim Meyering
Kamil Dudka [EMAIL PROTECTED] wrote: From 4f14f5e39d7687ddb252f5a7560724179635c944 Mon Sep 17 00:00:00 2001 From: Kamil Dudka [EMAIL PROTECTED] Date: Tue, 22 Jul 2008 12:53:00 +0200 Subject: [PATCH] --color now highlights files with capabilities, too Please make the first line of the log

Re: [PATCH] Again, do not change the mode of all directories below $HOME.

2008-07-22 Thread Ralf Wildenhues
Hi Jim, * Jim Meyering wrote on Tue, Jul 22, 2008 at 01:17:20PM CEST: Ralf Wildenhues [EMAIL PROTECTED] wrote: this fixes a regression of make check when source and build tree live in a directory with spaces in the name. The regression was introduced some time after I posted a fix for the

Re: [PATCH] Again, do not change the mode of all directories below $HOME.

2008-07-22 Thread Jim Meyering
Ralf Wildenhues [EMAIL PROTECTED] wrote: Look at it as an incentive not to use directories with names containing meta-characters ;-) Well, *I* am doing it for fun. Others use /c/My Files/... because yet others thought requiring users to cope with such names would be a cool idea. The

Re: Suggestion: try ~/.dircolors

2008-07-22 Thread Reuben Thomas
On Sat, 19 Jul 2008, Jim Meyering wrote: Reuben Thomas [EMAIL PROTECTED] wrote: On Sat, 19 Jul 2008, Jim Meyering wrote: Reuben Thomas [EMAIL PROTECTED] wrote: It would both be logical, and help with testing (where one wouldn't have to change one's login script) if dircolors tried to load