Re: [PATCH] New fallocate module

2009-05-28 Thread Bruno Haible
Pádraig Brady wrote: Take 2 attached. Take 2 review: +#ifdef REPLACE_FALLOCATE The generated fcntl.h should be maximally standalone. Can you better use #if @REPLACE_FALLOCATE@ and use an AC_SUBSTed variable REPLACE_FALLOCATE instead of one defined in config.h? +# undef fallocate Why the

Re: [PATCH] New fallocate module

2009-05-28 Thread Pádraig Brady
Bruno Haible wrote: Pádraig Brady wrote: Take 2 attached. Take 2 review: +#ifdef REPLACE_FALLOCATE The generated fcntl.h should be maximally standalone. Can you better use #if @REPLACE_FALLOCATE@ and use an AC_SUBSTed variable REPLACE_FALLOCATE instead of one defined in config.h? I

Re: [PATCH] chroot specify user/group feature

2009-05-28 Thread Giuseppe Scrivano
Hi Jim, Jim Meyering j...@meyering.net writes: setuidgid appears to be subsumed by chroot with the new options. If we can remove setuidgid.c, that code is no longer duplicated, so there's less (no?) motivation to move it into gnulib. If you want to remove setuidgid then I don't see any

Re: [PATCH] chroot specify user/group feature

2009-05-28 Thread Eric Blake
Giuseppe Scrivano gscrivano at gnu.org writes: setuidgid appears to be subsumed by chroot with the new options. If we can remove setuidgid.c, that code is no longer duplicated, so there's less (no?) motivation to move it into gnulib. If you want to remove setuidgid then I don't see any

Re: [PATCH] Add ability to print ACL's from ls

2009-05-28 Thread David Bartley
On Sun, May 10, 2009 at 6:32 AM, James Youngman j...@gnu.org wrote: On Sat, May 9, 2009 at 11:59 AM, David Bartley dtbar...@csclub.uwaterloo.ca wrote: I considered this. There are at least 3 different variants of ACL's (POSIX, NFSv4 and MacOS X) and they are generally incompatible. UMich

Re: [PATCH] chroot specify user/group feature

2009-05-28 Thread Giuseppe Scrivano
Eric Blake e...@byu.net writes: The point is that setuidgid is not installed. It exists only for the purposes of the testsuite. If it were an installed app, then yes it would make sense to keep it around, although perhaps rewritten as a wrapper around the new chroot functionality.

feature request for tail program - allow directories in watch list for -f

2009-05-28 Thread John Macdonald
One feature that has long been a component of the xtail program that has not yet been added to GNU tail is following directories. The command: xtail -f dir acts much like xtail -f dir/* except that it watches the directory and when a new file is created the new file is added to the list

Re: [PATCH] sort: Add --threads option, which parallelizes internal sort.

2009-05-28 Thread Jim Meyering
Glen Lenker wrote: On Thu, Mar 26, 2009 at 09:50:08PM +, Ralf Wildenhues wrote: Hi Paul, all, Paul Eggert writes: This patch is by Glen Lenker, Matt Pham, Benjamin Nuernberger, Sky Lin, TaeSung Roh, and Paul Eggert. It adds support for parallelism within an internal sort. On our

Coreutils needs a man page

2009-05-28 Thread jesse wilson
The man pages for the various coreutils do not mention the -- method of delimiting the options list. Someone who finds a directory on their system named -whatever will not be able to figure out how to inspect it using ls or cd into it just by reading the manpages for those utilities. The rm

Re: Coreutils needs a man page

2009-05-28 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to jesse wilson on 5/28/2009 6:16 PM: deleting it. Since -- is a common option of the coreutils, More than that, it is a common option required by POSIX of almost all apps (although not all apps follow POSIX, and there are a few