bug#5958: Sort-8.4 bug

2010-04-20 Thread Alan Curry
A full investigation has revealed: This bug was introduced between coreutils 7.1 and 7.2, here: commit 224a69b56b716f57e3a018af5a9b9379f32da3fc Author: Pádraig Brady p...@draigbrady.com Date: Tue Feb 24 08:37:18 2009 + sort: Fix two bugs with determining the end of field *

bug#5958: Sort-8.4 bug

2010-04-20 Thread Pádraig Brady
On 20/04/10 09:37, Alan Curry wrote: A full investigation has revealed: This bug was introduced between coreutils 7.1 and 7.2, here: commit 224a69b56b716f57e3a018af5a9b9379f32da3fc Author: Pádraig Brady p...@draigbrady.com Date: Tue Feb 24 08:37:18 2009 + sort: Fix two bugs

bug#5958: Sort-8.4 bug

2010-04-20 Thread Pádraig Brady
On 20/04/10 09:37, Alan Curry wrote: --- coreutils-8.4.orig/src/sort.c 2010-04-20 02:45:35.0 -0500 +++ coreutils-8.4/src/sort.c 2010-04-20 03:12:57.0 -0500 @@ -1460,9 +1460,6 @@ char *ptr = line-text, *lim = ptr + line-length - 1; size_t eword = key-eword, echar =

bug#5958: Sort-8.4 bug

2010-04-20 Thread Jim Meyering
Pádraig Brady wrote: I've changed it around in the attached patch so that we consistently use zero based limits throughout the code. I'll push this later on tonight unless there are objections. ... This regression was introduced in commit 224a69b5, 2009-02-24, sort: Fix two bugs with

bug#5987: ready for 8.5?

2010-04-20 Thread Jim Meyering
With today's sort fix, in spite of it being for the obsolete option format, I'm inclined to release coreutils-8.5. Do any of you know of pending problems you'd like to see fixed in 8.5?

bug#5987: ready for 8.5?

2010-04-20 Thread Pádraig Brady
On 20/04/10 17:58, Jim Meyering wrote: With today's sort fix, in spite of it being for the obsolete option format, I'm inclined to release coreutils-8.5. Do any of you know of pending problems you'd like to see fixed in 8.5? No bugs outstanding for me and nothing seems pending at:

bug#5991: [bug#5958 PATCH] docs: document translation of obsolete sort syntax

2010-04-20 Thread Eric Blake
* doc/coreutils.texi (sort invocation): Mention the conversion. --- How about this followup, copying the comment from Pádraig's patch into our documentation? doc/coreutils.texi |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/doc/coreutils.texi b/doc/coreutils.texi

bug#5987: ready for 8.5?

2010-04-20 Thread Eric Blake
On 04/20/2010 04:17 PM, Pádraig Brady wrote: On 20/04/10 17:58, Jim Meyering wrote: With today's sort fix, in spite of it being for the obsolete option format, I'm inclined to release coreutils-8.5. Do any of you know of pending problems you'd like to see fixed in 8.5? No bugs outstanding

bug#5987: ready for 8.5?

2010-04-20 Thread Chen Guo
Hi Padraig, I'm sitting on features, some done, all mostly done, so perhaps now is a good time to stabilize before throwing those into the mix. If those features include my work on sort and split, I'm down to help you out with cleaning up stuff if you need it. Just let me know.