bug#11424: coreutils: split tests hang on /dev/zero on GNU/Hurd

2012-05-06 Thread Samuel Thibault
Hello, Since some time, coreutils fails in split tests on GNU/Hurd. More precisely, these two: split/filter:55 split --filter="head -c1 >/dev/null" -n 1 /dev/zero split/l-chunk:39 split -n l/2 /dev/zero It seems that these two tests assume that split will stop by itself when given /dev/zero as

bug#11100: Racy code in copy.c

2012-05-06 Thread Jim Meyering
Pádraig Brady wrote: > I can't think of any issue with this. > Code looks good. > Test triggers the new condition. Thanks for the review. I've squashed the test-adding commit onto the fix, added this sentence to NEWS: With NFS attribute caching, the condition was particularly easy to tr

bug#11100: Racy code in copy.c

2012-05-06 Thread Pádraig Brady
I can't think of any issue with this. Code looks good. Test triggers the new condition. +1 cheers, Pádraig.

bug#11100: Racy code in copy.c

2012-05-06 Thread Jim Meyering
Jim Meyering wrote: > Philipp Thomas wrote: >> * Jim Meyering (j...@meyering.net) [20120328 18:09]: >> >>> At first glance, that might be reasonable: the additional open >>> is incurred only after a failed stat. >>> I'll look more closely in a week or two if no one else investigates. >> >> Ping, it