bug#13391: dd silently ignores lseek error

2013-01-09 Thread Philip Rowlands
From ea524ab7388bb35e591dcdb0fc7f7989d61143ae Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?P=C3=A1draig=20Brady?= p...@draigbrady.com Date: Wed, 9 Jan 2013 00:42:38 + Subject: [PATCH] dd: add [io]flag=seekable to verify file support for lseek * src/dd.c: Add the new O_SEEKABLE flag. (main):

bug#13391: dd silently ignores lseek error

2013-01-09 Thread Pádraig Brady
On 01/09/2013 07:36 AM, Bernhard Voelker wrote: why not check input_seekable where it is set - ~60 lines above? I was trying to keep related code together. Thanks for all the reviews, which I've fixed locally. To provide an argument for why this shouldn't go in, the following is equivalent:

bug#13394: Misalignment for seq -w

2013-01-09 Thread Marcel Böhme
Dear all, There are the following problems with the -w parameter of the seq tool: $seq -w -1 1.0 0 -1.0 0.0 1.0 But it should print: -1.0 00.0 01.0 A similar problem is observable for: $seq -w 10 -.1 1 | head Best regards, Marcel

bug#13394: Misalignment for seq -w

2013-01-09 Thread Bernhard Voelker
On 01/09/2013 11:14 AM, Marcel Böhme wrote: Dear all, There are the following problems with the -w parameter of the seq tool: $seq -w -1 1.0 0 -1.0 0.0 1.0 But it should print: -1.0 00.0 01.0 Hmm, according to the TEXI manual, the FIRST number should also use a fixed point decimal

bug#13394: Misalignment for seq -w

2013-01-09 Thread Erik Auerswald
Hi, On 01/09/2013 11:34 AM, Bernhard Voelker wrote: On 01/09/2013 11:14 AM, Marcel Böhme wrote: There are the following problems with the -w parameter of the seq tool: [...] Hmm, according to the TEXI manual, the FIRST number should also use a fixed point decimal representation when the -w

bug#13394: Misalignment for seq -w

2013-01-09 Thread Pádraig Brady
On 01/09/2013 11:01 AM, Erik Auerswald wrote: Hi, On 01/09/2013 11:34 AM, Bernhard Voelker wrote: On 01/09/2013 11:14 AM, Marcel Böhme wrote: There are the following problems with the -w parameter of the seq tool: [...] Hmm, according to the TEXI manual, the FIRST number should also use a

bug#13394: Misalignment for seq -w

2013-01-09 Thread Erik Auerswald
On 01/09/2013 01:05 PM, Pádraig Brady wrote: On 01/09/2013 11:01 AM, Erik Auerswald wrote: Hi, On 01/09/2013 11:34 AM, Bernhard Voelker wrote: On 01/09/2013 11:14 AM, Marcel Böhme wrote: There are the following problems with the -w parameter of the seq tool: [...] Hmm, according to the

bug#13394: Misalignment for seq -w

2013-01-09 Thread Bernhard Voelker
On 01/09/2013 01:05 PM, Pádraig Brady wrote: Looks like a bug. I'll fix with: diff --git a/src/seq.c b/src/seq.c index e1b467c..3eb53f8 100644 --- a/src/seq.c +++ b/src/seq.c @@ -332,6 +332,8 @@ get_default_format (operand first, operand step, operand last) last_width--;