bug#64540: [PATCH] od: exit out on failure to write to stdout

2023-07-17 Thread Paul Eggert
On 2023-07-17 10:12, Pádraig Brady wrote: Right. In headers though, the traditional "static inline" idiom Ah, I forgot that it was in system.h. At some point we should have system.h use _GL_INLINE but that can wait.

bug#64540: [PATCH] od: exit out on failure to write to stdout

2023-07-17 Thread Pádraig Brady
On 17/07/2023 18:04, Paul Eggert wrote: On 2023-07-17 03:31, Pádraig Brady wrote: static inline void As a general rule, there's no need for 'static inline' in C, as nowadays compilers figure out inlining just fine for static functions and plain 'static' should be good enough. There are

bug#64540: [PATCH] od: exit out on failure to write to stdout

2023-07-17 Thread Paul Eggert
On 2023-07-17 03:31, Pádraig Brady wrote: static inline void As a general rule, there's no need for 'static inline' in C, as nowadays compilers figure out inlining just fine for static functions and plain 'static' should be good enough. There are exceptions but 'write_error' doesn't look

bug#64540: [PATCH] od: exit out on failure to write to stdout

2023-07-17 Thread Pádraig Brady
On 17/07/2023 07:35, Bernhard Voelker wrote: On 7/15/23 23:08, Pádraig Brady wrote: The attached patch-set addresses two classes of issue: 1. Doubled error messages upon write errors 2. Continued processing upon write errors (the orig problem reported). Nice work! Patch 1: > ---

bug#64540: [PATCH] od: exit out on failure to write to stdout

2023-07-17 Thread Bernhard Voelker
On 7/15/23 23:08, Pádraig Brady wrote: The attached patch-set addresses two classes of issue: 1. Doubled error messages upon write errors 2. Continued processing upon write errors (the orig problem reported). Nice work! Patch 1: > --- /dev/null > +++ b/tests/misc/write-errors.sh > @@ -0,0