[PATCH]: nl: deprecate --page-increment in favour of --line-increment

2009-08-18 Thread Giuseppe Scrivano
Subject: [PATCH] nl: deprecate --page-increment in favour of --line-increment * NEWS: Mention the change. * doc/coreutils.texi: Document the --line-increment option. * src/nl.c (struct option): Add --line-increment, (usage): Describe it, (main): Use it. --- NEWS |5 + doc

Re: [PATCH]: nl: deprecate --page-increment in favour of --line-increment

2009-08-18 Thread Kamil Dudka
Hello Giuseppe, On Tue August 18 2009 12:47:06 Giuseppe Scrivano wrote: diff --git a/src/nl.c b/src/nl.c index 2deb314..ea7ebe6 100644 --- a/src/nl.c +++ b/src/nl.c @@ -150,7 +150,9 @@ static struct option const longopts[] = {body-numbering, required_argument, NULL, 'b'},

Re: [PATCH]: nl: deprecate --page-increment in favour of --line-increment

2009-08-18 Thread Giuseppe Scrivano
Thanks Kamil, yes, CHAR_MAX + 1 looks like a better choice. Are there other comments? Giuseppe Kamil Dudka kdu...@redhat.com writes: Hello Giuseppe, On Tue August 18 2009 12:47:06 Giuseppe Scrivano wrote: diff --git a/src/nl.c b/src/nl.c index 2deb314..ea7ebe6 100644 --- a/src/nl.c +++

Re: [PATCH]: nl: deprecate --page-increment in favour of --line-increment

2009-08-18 Thread Jim Meyering
Giuseppe Scrivano wrote: --page-increment seems the wrong name for this option, --line-increment is clearer. what do you think of this change? Good catch. Thanks for the patch. I wonder if anyone has ever used that option ;-) ... diff --git a/NEWS b/NEWS ... +** Deprecated options + + nl

Re: [PATCH]: nl: deprecate --page-increment in favour of --line-increment

2009-08-18 Thread Giuseppe Scrivano
From 8dc27341e8ed57e790a71d4b61df44e908bc73cd Mon Sep 17 00:00:00 2001 From: Giuseppe Scrivano gscriv...@gnu.org Date: Tue, 18 Aug 2009 12:22:37 +0200 Subject: [PATCH] nl: deprecate --page-increment in favour of --line-increment * NEWS: Mention the change. * doc/coreutils.texi: Document the --line