Hi Pádraig,
thank you for review!
On Tuesday 24 March 2009 02:05:33 Pádraig Brady wrote:
Kamil Dudka wrote:
Hello,
promissed patch for ls to disable hard links highlighting is attached.
A simple test case is included.
This is better, but dircolors still outputs the hl=44;37 code
and
Kamil Dudka wrote:
dirvish users can simply disable it if they really want to. If somebody is
not
interested in hard links highlighting it is not enough reason to disable it
by default. Yes, it is strong reason to make it optionally. That's my
opinion.
I'm still not convinced, but let's
:00:00 2001
From: Kamil Dudka kdu...@redhat.com
Date: Tue, 24 Mar 2009 12:16:20 +0100
Subject: [PATCH] ls: make possible to disable hard links highlighting
* src/ls.c (print_color_indicator): Skip hard link checking if not colored.
* tests/ls/hardlink: Add test case for disabled hard link
Kamil Dudka wrote:
On Tuesday 24 March 2009 12:05:21 Pádraig Brady wrote:
Kamil Dudka wrote:
p.s. you forgot the '* ' on front of the filenames in the changelog
Good catch. Thanks!
Could you resubmit a patch with an addition to NEWS \** Changes in
behavior that mentions one can disable
kdu...@redhat.com
Date: Mon, 23 Mar 2009 19:29:41 +0100
Subject: [PATCH] ls: make possible to disable hard links highlighting
src/ls.c (print_color_indicator): Skip hard link checking if not colored.
tests/ls/hardlink: Add test case for disabled hard link highlighting.
---
src/ls.c |2
Kamil Dudka wrote:
Hello,
promissed patch for ls to disable hard links highlighting is attached.
A simple test case is included.
This is better, but dircolors still outputs the hl=44;37 code
and so this will still be enabled by default.
This should be disabled by default, and IMHO
the number
