bug#16532: Test Fail: tests/chown/separator

2014-01-24 Thread Pádraig Brady
On 01/24/2014 07:43 AM, Bernhard Voelker wrote: On 01/24/2014 04:09 AM, Pádraig Brady wrote: On 01/24/2014 02:46 AM, Assaf Gordon wrote: $ getent group | grep ^users users:x:100: users:x:1000:www-data,XXX,YYY === Oh right, grep ^$id_gn: it is so. Note we can't rely on getent(1) being

bug#16532: Test Fail: tests/chown/separator

2014-01-24 Thread Bernhard Voelker
On 01/24/2014 01:19 PM, Pádraig Brady wrote: On 01/24/2014 07:43 AM, Bernhard Voelker wrote: On 01/24/2014 04:09 AM, Pádraig Brady wrote: Oh right, grep ^$id_gn: it is so. Note we can't rely on getent(1) being available (as noted in bug 9987), but the failure in that edge case is still a

bug#16532: Test Fail: tests/chown/separator

2014-01-24 Thread Assaf Gordon
On 01/24/2014 07:46 AM, Bernhard Voelker wrote: On 01/24/2014 04:09 AM, Pádraig Brady wrote: Oh right, grep ^$id_gn: it is so. BTW: I'd change the skip_ message to reflect the above mentioned corner case where getent is not available, something like: - skip_ multiple IDs for group '$id_gn':

bug#16532: Test Fail: tests/chown/separator

2014-01-24 Thread Pádraig Brady
On 01/24/2014 04:58 PM, Assaf Gordon wrote: On 01/24/2014 07:46 AM, Bernhard Voelker wrote: On 01/24/2014 04:09 AM, Pádraig Brady wrote: Oh right, grep ^$id_gn: it is so. BTW: I'd change the skip_ message to reflect the above mentioned corner case where getent is not available, something

bug#16532: Test Fail: tests/chown/separator

2014-01-23 Thread Assaf Gordon
Hello, Testing the latest coreutils (v8.22.16-be97f) on an old Ubuntu server, results in a test failure tests/chown/separator (log + strace below). System is: $ uname -a Linux club 2.6.32-24-server #43-Ubuntu SMP Thu Sep 16 16:05:42 UTC 2010 x86_64 GNU/Linux $ cat /etc/issue Ubuntu

bug#16532: Test Fail: tests/chown/separator

2014-01-23 Thread Bernhard Voelker
tag 16532 + moreinfo thanks On 01/23/2014 07:41 PM, Assaf Gordon wrote: Hello, welcome back! Testing the latest coreutils (v8.22.16-be97f) on an old Ubuntu server, results in a test failure tests/chown/separator (log + strace below). $ strace ../src/chown 34574:users . 21 | grep -A 5 -B 5

bug#16532: Test Fail: tests/chown/separator

2014-01-23 Thread Assaf Gordon
On 01/23/2014 06:20 PM, Bernhard Voelker wrote: On 01/23/2014 07:41 PM, Assaf Gordon wrote: $ strace ../src/chown 34574:users . 21 | grep -A 5 -B 5 chown fchownat(AT_FDCWD, ., 34574, 100, 0) = -1 EPERM (Operation not permitted) ++ id -g + id_g=1000 + chown 34574:users . chown:

bug#16532: Test Fail: tests/chown/separator

2014-01-23 Thread Pádraig Brady
On 01/23/2014 11:41 PM, Assaf Gordon wrote: On 01/23/2014 06:20 PM, Bernhard Voelker wrote: On 01/23/2014 07:41 PM, Assaf Gordon wrote: $ strace ../src/chown 34574:users . 21 | grep -A 5 -B 5 chown fchownat(AT_FDCWD, ., 34574, 100, 0) = -1 EPERM (Operation not permitted) ++ id -g +

bug#16532: Test Fail: tests/chown/separator

2014-01-23 Thread Assaf Gordon
This patch makes the test skip on my server (did not test it on other systems). On 01/23/2014 08:09 PM, Pádraig Brady wrote: On 01/23/2014 11:41 PM, Assaf Gordon wrote: So I guess this is not a bug, and can be closed. I'll just ignore this failure on this system. It is a false failure

bug#16532: Test Fail: tests/chown/separator

2014-01-23 Thread Pádraig Brady
On 01/24/2014 01:38 AM, Assaf Gordon wrote: This patch makes the test skip on my server (did not test it on other systems). On 01/23/2014 08:09 PM, Pádraig Brady wrote: On 01/23/2014 11:41 PM, Assaf Gordon wrote: So I guess this is not a bug, and can be closed. I'll just ignore this

bug#16532: Test Fail: tests/chown/separator

2014-01-23 Thread Pádraig Brady
On 01/24/2014 01:43 AM, Pádraig Brady wrote: On 01/24/2014 01:38 AM, Assaf Gordon wrote: This patch makes the test skip on my server (did not test it on other systems). On 01/23/2014 08:09 PM, Pádraig Brady wrote: On 01/23/2014 11:41 PM, Assaf Gordon wrote: So I guess this is not a bug,

bug#16532: Test Fail: tests/chown/separator

2014-01-23 Thread Assaf Gordon
On 01/23/2014 09:32 PM, Pádraig Brady wrote: Actually I messed up the login in the suggestion. I think the above should be s/!=/=/ which I've done in the attached patch. If you could confirm it was skipped on your system it would be great. I'll push soon anyway. Please don't push yet - it

bug#16532: Test Fail: tests/chown/separator

2014-01-23 Thread Assaf Gordon
On 01/23/2014 09:46 PM, Assaf Gordon wrote: On 01/23/2014 09:32 PM, Pádraig Brady wrote: If you could confirm it was skipped on your system it would be great. Please don't push yet - it doesn't work, but for un-expected reason: On my strange system For completeness, attached is the test

bug#16532: Test Fail: tests/chown/separator

2014-01-23 Thread Pádraig Brady
On 01/24/2014 02:46 AM, Assaf Gordon wrote: On 01/23/2014 09:32 PM, Pádraig Brady wrote: Actually I messed up the login in the suggestion. I think the above should be s/!=/=/ which I've done in the attached patch. If you could confirm it was skipped on your system it would be great. I'll