Re: coreutils-5.92 - dd skip option completely broken

2005-11-02 Thread Jim Meyering
Paul Eggert [EMAIL PROTECTED] wrote: That's an embarrassing bug! Thanks for reporting it. I installed this patch into CVS coreutils (main branch). We should add a test case but I'm not offhand sure which file it should go into. Jim, advice? I'd prefer that it go in tests/dd/skip-seek,

Re: coreutils-5.92 - dd skip option completely broken

2005-11-02 Thread Paul Eggert
Jim Meyering [EMAIL PROTECTED] writes: I'd prefer that it go in tests/dd/skip-seek, partly because the name fits, and also because I want to move away from bourne-shell-based tests -- at least when it's easy to do so. OK. However, I can't easily see how to modify that file to do the test I

Re: coreutils-5.92 - dd skip option completely broken

2005-11-02 Thread Jim Meyering
Paul Eggert [EMAIL PROTECTED] wrote: Jim Meyering [EMAIL PROTECTED] writes: I'd prefer that it go in tests/dd/skip-seek, partly because the name fits, and also because I want to move away from bourne-shell-based tests -- at least when it's easy to do so. OK. However, I can't easily see how

Re: coreutils-5.92 - dd skip option completely broken

2005-11-02 Thread Paul Eggert
Jim Meyering [EMAIL PROTECTED] writes: Here's the shell-command test I'd like to run: test `echo abc | dd bs=1 skip=1 | cat` = bc where the output of dd is a pipe. I think you mean `input', there. Yes, sorry. Anyway, thanks for stepping in and doing the work.

Re: coreutils-5.92 - dd skip option completely broken

2005-11-02 Thread Andreas Schwab
Jim Meyering [EMAIL PROTECTED] writes: @@ -61,6 +61,13 @@ my @Tests = {OUT= 01234567 abcdefghij }, {ERR= 2+1 records in\n0+1 records out\n1 truncated record\n}, ], + [ + # Before fileutils-5.93, this would output just c\n. ITYM coreutils-5.93.

Re: coreutils-5.92 - dd skip option completely broken

2005-11-02 Thread Jim Meyering
Andreas Schwab [EMAIL PROTECTED] wrote: Jim Meyering [EMAIL PROTECTED] writes: @@ -61,6 +61,13 @@ my @Tests = {OUT= 01234567 abcdefghij }, {ERR= 2+1 records in\n0+1 records out\n1 truncated record\n}, ], + [ + # Before fileutils-5.93, this would

Re: coreutils-5.92 - dd skip option completely broken

2005-10-31 Thread Theodoros V. Kalamatianos
On Mon, 31 Oct 2005, Theodoros V. Kalamatianos wrote: It seems that it just reads and drops one more record than it should. I have verified with `wc' that the characters are indeed dropped end not e.g. replaced with a null. I'll see if I can trace this bug, but it may take some time. Ok,

Re: coreutils-5.92 - dd skip option completely broken

2005-10-31 Thread Paul Eggert
That's an embarrassing bug! Thanks for reporting it. I installed this patch into CVS coreutils (main branch). We should add a test case but I'm not offhand sure which file it should go into. Jim, advice? 2005-10-31 Paul Eggert [EMAIL PROTECTED] * src/dd.c (skip): Fix off-by-one

coreutils-5.92 - dd skip option completely broken

2005-10-30 Thread Theodoros V. Kalamatianos
While trying to implement the per-block seek/skip options I suggested I stumbled on yet another bug in coreutils-5.92. This time it affects dd and I believe it is major enough to consider coreutils-5.92 unusable and pull that release back. Initially I thought that the dd skip= option drops 2 *