bug#11787: Potential use after free bug in coreutils 8.17

2012-06-26 Thread Pádraig Brady
On 06/26/2012 06:01 AM, Xu Zhongxing wrote: In Coreutils 8.17, csplit.c, static bool load_buffer (void) On line 503 and 511, b is passed to free_buffer() twice. This could lead to a use-after-free bug in free_buffer(): struct line *n = l-next;, where buf-line_start is freed in the first

bug#10305: coreutils-8.14, rm -r fails with EBADF

2012-06-26 Thread Joachim Schmitz
From: Paul Eggert [mailto:egg...@cs.ucla.edu] Sent: Sunday, January 15, 2012 7:01 AM To: Joachim Schmitz Cc: 10...@debbugs.gnu.org; bug-gnu...@gnu.org; 'Eric Blake'; 'Jim Meyering' Subject: Re: bug#10305: coreutils-8.14, rm -r fails with EBADF On 01/14/2012 08:27 AM, Joachim Schmitz wrote:

bug#10305: coreutils-8.14, rm -r fails with EBADF

2012-06-26 Thread Bruno Haible
Joachim Schmitz wrote: Also 2 small fixes for C99 Thanks for these. Indeed, the 'argp' and 'regex' modules use strcasecmp() and should therefore depend 'strcase' (already done) and include strings.h (done through patch below). 2012-06-26 Bruno Haible br...@clisp.org argp, regex:

bug#10305: coreutils-8.14, rm -r fails with EBADF

2012-06-26 Thread Paul Eggert
Shouldn't regex be avoiding strcasecmp entirely? That is, couldn't there be a weird locale that considers the lower-case equivalent of U to be uu, or something weird like that? For this particular case c-strcase seems overkill, so how about the following further patch? diff --git a/lib/regcomp.c

bug#11794: Bug is 'ls -k' command

2012-06-26 Thread Joseph Felps
When I use the -k switch with ls, like 'ls -lk' it used to show all the file sizes in kibibytes. Now the switch, -k or --kibibytes has no effect at all. This is with coreutils 8.17.

bug#11794: Bug is 'ls -k' command

2012-06-26 Thread Eric Blake
tag 11794 notabug thanks On 06/26/2012 02:11 PM, Joseph Felps wrote: When I use the -k switch with ls, like 'ls -lk' it used to show all the file sizes in kibibytes. Now the switch, -k or --kibibytes has no effect at all. This is with coreutils 8.17. Thanks for the report. However, from

bug#10305: strcasecmp in regex

2012-06-26 Thread Bruno Haible
Hi Paul, Shouldn't regex be avoiding strcasecmp entirely? That is, couldn't there be a weird locale that considers the lower-case equivalent of U to be uu, or something weird like that? In such a locale, strcasecmp would not consider U and uu as being equivalent; only mbscasecmp would do

bug#10305: coreutils-8.14, rm -r fails with EBADF

2012-06-26 Thread Paul Eggert
On 06/26/2012 09:38 AM, Joachim Schmitz wrote: Let me know what you think and where/how you'd do it differently. The changes mostly look good. The trivial ones we've incorporated already. I have some comments on the nontrivial ones (please see below). But before we get into it too much