On 26/10/15 07:11, Bernhard Voelker wrote:
> On 10/26/2015 02:51 AM, Pádraig Brady wrote:
>> From 5e3d017e7bc66cf6f666160f774944c2ff52d1ae Mon Sep 17 00:00:00 2001
>> From: =?UTF-8?q?P=C3=A1draig=20Brady?= <p...@draigbrady.com>
>> Date: Mon, 26 Oct 2015 01:26:04 +0000
>> Subject: [PATCH] md5sum: quote all printed file names
>>
>> This is especially significant when using --check
>> with files generated on a windows system, where the \r
>> characters produce corrupted and confusing error messages.
>> This also ensures status messages are output on a single line.
>>
>> * src/md5sum.c: Use quote() for printed file names.
>> * tests/misc/md5sum.pl: Adjust accordingly.
>> * NEWS: Mention the change in behavior.
>> Fixes http://bugs.gnu.org/21757
>
> tests/misc/sha1sum.pl now fails; you forgot to adjust the ERR
> messages in there.
Pushed with that fix.
> Otherwise, the patch looks good to me.
> Thanks.
>
> BTW: I was quite surprised to see that the other utilities -
> sha{224,256,384,512}sum - don't have a single negative test.
> I mean, there should be at least one case for each of these
> utilities to check whether an invalid checksum leads to an
> error message and an exit status != 0.
Maybe, though it would only be testing the same logic
as they share the same source as sha1sum?
thanks for the review,
Pádraig.
