bug#35291: [PATCH] split: fix incorrect suffix length computation

2019-06-08 Thread Pádraig Brady
On 15/04/19 19:05, Johannes Altmanninger wrote: > * src/split.c (set_suffix_length): suffix_needed is now computed > to be the equivalent of ceil(log(n_units_end) / log(alphabet_len)). > Previously, it would give the floor of above logarithm if the number > of units is divisible by the length of

bug#35291: [PATCH] split: fix incorrect suffix length computation

2019-06-08 Thread Paul Eggert
Johannes Altmanninger wrote: Does anyone have time to review this? I think it's an evident bug. I can try to improve the clarity of the patch if needed. It's not clarity that needs fixing, it's also correctness. A quick look suggests that the proposed fix can go into an infinite loop due to