bug#36831: enhance 'directory not empty' message

2019-08-01 Thread Assaf Gordon
On Thu, Aug 01, 2019 at 03:58:51PM -0700, Paul Eggert wrote: > Thanks, that's better, but we're still missing some opportunities for > improvement. > > > mv: cannot move 'A' to 'B/A': Target directory not empty > > This should be "Destination" not "Target". [...] > You meant "mv" not

bug#36887: coreutils-8.31: printf chokes on \u0041

2019-08-01 Thread Paul Eggert
Ulrich Mueller wrote: Except for the surrogates U+D800...U+DFFF, it looks like an arbitrary restriction It's not entirely arbitrary. Because of the restriction, coreutils printf doesn't have to worry about what this command should do: printf '\u0025d\n' 1 2 Does this print a single line

bug#36887: coreutils-8.31: printf chokes on \u0041

2019-08-01 Thread Ulrich Mueller
> On Thu, 01 Aug 2019, Pádraig Brady wrote: > I agree this is a bit surprising. Indeed, it most certainly violates the principle of least surprise. Especially, it means that a shell script that will run in bash won't run in a shell that doesn't have a built-in printf. > The full manual

bug#36887: coreutils-8.31: printf chokes on \u0041

2019-08-01 Thread Pádraig Brady
On 01/08/19 12:02, Ulrich Mueller wrote: > [Forwarding bug https://bugs.gentoo.org/680244 as requested by the > Gentoo package maintainer.] > > According to printf(1): > >Interpreted sequences are: >[...] > >\u Unicode (ISO/IEC 10646) character with hex value (4 digits)

bug#36887: coreutils-8.31: printf chokes on \u0041

2019-08-01 Thread Ulrich Mueller
[Forwarding bug https://bugs.gentoo.org/680244 as requested by the Gentoo package maintainer.] According to printf(1): Interpreted sequences are: [...] \u Unicode (ISO/IEC 10646) character with hex value (4 digits) \U Unicode character with hex value

bug#36831: enhance 'directory not empty' message

2019-08-01 Thread Assaf Gordon
Hello, On Wed, Jul 31, 2019 at 08:03:45PM -0700, Paul Eggert wrote: > Assaf Gordon wrote: > > An explicit error explicitly saying "cannot move", and mention the source > > and > > destination, and also "blames" the target directory seems the most > > user-friendly and least ambiguous. > > Sure,

bug#36831: enhance 'directory not empty' message

2019-08-01 Thread Erik Auerswald
Hi, On Wed, Jul 31, 2019 at 04:05:05PM -0600, Assaf Gordon wrote: > On Mon, Jul 29, 2019 at 06:50:46PM -0500, Paul Eggert wrote: > > On 7/29/19 1:28 AM, Assaf Gordon wrote: > > > + if (rename_errno == ENOTEMPTY || rename_errno == EEXIST) > > > +{ > > > + error (0, 0,