bug#41001: mkdir: cannot create directory ‘test’: File exists

2020-05-02 Thread Paul Eggert
On 5/2/20 3:41 PM, Jonny Grant wrote: > Is a more accurate strerror considered unreliable? > > Current: > mkdir: cannot create directory ‘test’: File exists > > Proposed: > mkdir: cannot create directory ‘test’: Is a directory I don't understand this comment. As I understand it you're proposing

bug#41001: mkdir: cannot create directory ‘test’: File exists

2020-05-02 Thread Jonny Grant
On 02/05/2020 20:47, Paul Eggert wrote: On 5/2/20 6:26 AM, Jonny Grant wrote: If developers have race conditions in their shell scripts I've personally fixed a bug in the GNU mkdir command that was triggered by such races. Core utilities should be reliable even when these races are

bug#41001: mkdir: cannot create directory ‘test’: File exists

2020-05-02 Thread Paul Eggert
On 5/2/20 6:26 AM, Jonny Grant wrote: > If developers have race conditions in their shell scripts I've personally fixed a bug in the GNU mkdir command that was triggered by such races. Core utilities should be reliable even when these races are happening.

bug#41001: mkdir: cannot create directory ‘test’: File exists

2020-05-02 Thread Jonny Grant
On 01/05/2020 21:32, Paul Eggert wrote: On 5/1/20 1:21 PM, Jonny Grant wrote: yes, the fix pretty trivial for mkdir as you highlight EISDIR: stat(), S_ISDIR(sb.st_mode), and set errno to EISDIR or output strerror(EISDIR) That would introduce a race condition, and wouldn't behave correctly