bug#50972: src/ls.c fails to build when __GNUC_PREREQ is not defined (e.g., OpenBSD)

2021-10-03 Thread Brian Callahan
On 10/03/2021 01:42 PM, Paul Eggert wrote: On 10/2/21 8:14 PM, Brian Callahan wrote: I can send you a build log offlist if you'd like to see what the 7.0 build looks like. It sounds like the more-recent clang has fixed most of the false alarms. It'd probably be a more-efficient use of our t

bug#50972: src/ls.c fails to build when __GNUC_PREREQ is not defined (e.g., OpenBSD)

2021-10-03 Thread Paul Eggert
On 10/2/21 8:14 PM, Brian Callahan wrote: I can send you a build log offlist if you'd like to see what the 7.0 build looks like. It sounds like the more-recent clang has fixed most of the false alarms. It'd probably be a more-efficient use of our time for us to wait until 7.0 is out, so that

bug#50972: src/ls.c fails to build when __GNUC_PREREQ is not defined (e.g., OpenBSD)

2021-10-03 Thread Paul Eggert
On 10/3/21 4:38 AM, Pádraig Brady wrote: I'm confused as to why some functions need _Noreturn and some don't. Yes, it's a bit of a pain. _Noreturn is useful on extern functions, since otherwise GCC typically won't know the function doesn't return. On static functions, though, _Noreturn genera

bug#50972: src/ls.c fails to build when __GNUC_PREREQ is not defined (e.g., OpenBSD)

2021-10-03 Thread Brian Callahan
Hi Paul -- On 10/02/2021 10:07 PM, Paul Eggert wrote: The first patch listed above should fix the problem you mentioned; you might want to look at the other patches as well. Much appreciated. Can confirm the tip of the tree builds OOTB now. By the way, how do you deal with all those false p

bug#50972: src/ls.c fails to build when __GNUC_PREREQ is not defined (e.g., OpenBSD)

2021-10-03 Thread Pádraig Brady
On 03/10/2021 03:07, Paul Eggert wrote: On 10/2/21 7:44 AM, Brian Callahan wrote: Once this fix is done, the rest of coreutils-9.0 builds and works OK. Thanks for letting us know, as it's been a while since I tried building coreutils on OpenBSD. I just now tried it on OpenBSD 6.9 and found som