bug#11100: Racy code in copy.c

2021-11-18 Thread Jim Meyering
On Thu, Nov 18, 2021 at 8:38 AM Paul Eggert wrote: > I spotted a SELinux security-context race introduced by the circa-2012 > fix for Bug#11100, and installed the attached patch into coreutils > master. This also gets rid of a label and goto (which is what led me to > find the issue). Nice!

bug#50714: OS X, one failure: tests/tail-2/pipe-f.sh

2021-09-20 Thread Jim Meyering
Uname -v reports this: Darwin Kernel Version 20.6.0: Mon Aug 30 06:12:21 PDT 2021; root:xnu-7195.141.6~3/RELEASE_X86_64 Sorry, I don't have time to delve into this, but here's the log from the sole test failure: pipe-f.log Description: Binary data

bug#50611: one-byte (write) heap-buffer-underrun

2021-09-15 Thread Jim Meyering
Thanks for all your recent changes! I built+tested with ASAN on Fedora 34: Configure and build as usual, then "make clean" and do this: > san='-fsanitize-address-use-after-scope -fsanitize=address -static-libasan'; > ASAN_OPTIONS=detect_leaks=0 , CFLAGS='-O -ggdb3' AM_CFLAGS="$san" >

bug#50167: fixes for "fmt - -" etc.

2021-08-25 Thread Jim Meyering
On Wed, Aug 25, 2021, 4:37 PM Bernhard Voelker wrote: > On 8/25/21 10:38 AM, Jim Meyering wrote: > > * cfg.mk (exclude_file_name_regexp--sc_system_h_headers): > > Add find-mount-point.h to the regexp. > > +1 > even better, thanks. > Thanks. Pushed. >

bug#50167: fixes for "fmt - -" etc.

2021-08-25 Thread Jim Meyering
On Tue, Aug 24, 2021 at 11:10 PM Paul Eggert wrote: > On 8/24/21 12:42 PM, Bernhard Voelker wrote: > > Was there a particular reason to include stdlib.h? > > It's needed to declare 'free', which is used by _GL_ATTRIBUTE_DEALLOC_FREE. > > I added "#include " so that find-mount-point.h would be an

bug#49741: basenc --base64url decoding bug

2021-08-17 Thread Jim Meyering
On Tue, Aug 17, 2021 at 2:02 AM Pádraig Brady wrote: > On 16/08/2021 22:17, Assaf Gordon wrote: > > Hello Emil and all, > > > > Thanks for the clear and easily reproducible bug report. > > > > Attached a suggested fix. > > Comments very welcomed, > > minor nit in NEWS: > s/silently

bug#45093: Character 149 causing ASCII BEL output to console in Windoze port of Gnu CoreUtils

2020-12-07 Thread Jim Meyering
tags 45093 notabug close 45093 stop On Mon, Dec 7, 2020 at 9:11 AM Paul Eggert wrote: > On 12/6/20 8:23 PM, Robert S. Kissel wrote: > > I'm pretty sure this is a bug in the Windoze port of head and tail, > > You should have better luck writing directly to the people who prepared that > port, as

bug#44235: [PATCH] dd: drop old workaround for lseek() bug in Linux kernel

2020-10-26 Thread Jim Meyering
On Mon, Oct 26, 2020 at 6:13 AM Pádraig Brady wrote: > On 26/10/2020 10:44, Kamil Dudka wrote: > > The workaround triggers warnings with new kernel versions in case > > a user does not have sufficient privileges for the MTIOCGET ioctl. > > > > * src/dd.c (skip_via_lseek): Drop wrapper function no

bug#39364: [PATCH] rmdir: fix clobbered errno

2020-02-03 Thread Jim Meyering
On Mon, Feb 3, 2020 at 5:28 AM Pádraig Brady wrote: ... > Actually I think the key issue is not errno handling, > but a logic error fixed with: > > @@ -102,7 +102,7 @@ ignorable_failure (int error_number, char const *dir) > return (ignore_fail_on_non_empty > &&

bug#39364: [PATCH] rmdir: fix clobbered errno

2020-02-02 Thread Jim Meyering
On Sun, Feb 2, 2020 at 5:11 AM Bernhard Voelker wrote: > On 2020-02-02 07:32, Jim Meyering wrote: > > FTR, here's a minimal test addition that exercises the bug. Succeeds > > on 6.10, fails on 6.11: > > Minor tweak for the test ... > > -rmdir --ignore-fail-on-non-empty

bug#39364: [PATCH] rmdir: fix clobbered errno

2020-02-01 Thread Jim Meyering
Nice find and thank you for the patch. That's a 12-year-old bug I introduced. I confirm: with 6.10, running this: mkdir -p a/b && chmod a-w a && rmdir --ignore a/b prints this and exits nonzero: rmdir: failed to remove `a/b': Permission denied With 6.11 and newer, it silently succeeds. On

bug#38627: uniq -c gets wrong count with non-ascii strings

2019-12-17 Thread Jim Meyering
es the equivalent of strcmp (byte comparison). Since the two > lines compare equal in your locale, GNU 'uniq' says there's just one line. > > The GNU 'uniq' behavior appears to be a consequence of this commit: > > commit 545c2323d493c7ed9c770d9b8e45a15db6f615bc > Author: Jim Meyering

bug#36831: enhance 'directory not empty' message

2019-07-29 Thread Jim Meyering
On Sun, Jul 28, 2019 at 11:29 PM Assaf Gordon wrote: ... > What do others think? If this is a desired improvement, I'll finish the > patch with news/tests/etc. ... > [PATCH] mv: improve ENOTEMPTY/EEXIST error message > > Suggested by Alex Mantel in > https://bugs.gnu.org/36831 . > > $ mkdir

bug#34239: build failure on Android, due to S_MAGIC_* symbols

2019-02-16 Thread Jim Meyering
On Tue, Jan 29, 2019 at 9:01 PM Pádraig Brady wrote: > On 28/01/19 19:19, Bruno Haible wrote: > > Hi, > > > > Compiling coreutils on Android produces this error: > > > > CC src/tail.o > > In file included from ../src/tail.c:63: > > ../src/fs-is-local.h: In function 'is_local_fs_type': > >

bug#30963: ls -fA -> still . and ..

2018-03-27 Thread Jim Meyering
On Tue, Mar 27, 2018 at 3:06 PM, Paul Eggert wrote: > On 03/27/2018 10:27 AM, Karl Berry wrote: >> >> ls -aA also shows . and ..; maybe it shouldn't? > > You're right, it shouldn't. This was a bug I introduced in 2004 and I think > you're the first to report it (!). In my

bug#29961: [PATCH] mv: document the missing atomicity of 'mv -n'

2018-01-03 Thread Jim Meyering
On Wed, Jan 3, 2018 at 8:27 AM, Kamil Dudka wrote: > On Wednesday, January 3, 2018 4:08:51 PM CET Pádraig Brady wrote: >> Eep, Seems like we should use RENAME_NOREPLACE in this case, >> rather than document the caveat? Good catch/fix. Thanks to both of you.

bug#21760: timeout: Feature Request: --verbose ==> output if timeout

2017-11-23 Thread Jim Meyering
On Thu, Nov 23, 2017 at 2:35 PM, Pádraig Brady wrote: ... >> So I'm leaning towards supporting --verbose which would output something >> like: >> >> timeout: aborting command 'blah' with signal SIGTERM >> timeout: aborting command 'blah' with signal SIGKILL +

bug#29259: tail does not seek to the end of block device

2017-11-13 Thread Jim Meyering
On Mon, Nov 13, 2017 at 12:03 AM, Pádraig Brady wrote: > On 12/11/17 22:21, Pádraig Brady wrote: >> On 12/11/17 21:52, Paul Eggert wrote: >>> Why doesn't lseek work for this? >> >> Good call, it probably would. >> Something like the following is more acceptable >> since it

bug#29164: Scratch this bug report

2017-11-06 Thread Jim Meyering
tags 29164 notabug thanks On Mon, Nov 6, 2017 at 12:21 AM, Thomas Deutschmann wrote: > please ignore this bug report. This is caused by Gentoo's sandbox in > portage and no problem in coreutils. Sorry for wasting your time :/ Closing and marking as notabug

bug#29038: df hangs on fifos/named pipes

2017-10-29 Thread Jim Meyering
On Sun, Oct 29, 2017 at 3:34 PM, Pádraig Brady wrote: ... >> That was discovered by Martijn Dekker, CCed, when looking for a >> portable way to identify the file system of an arbitrary file. > > Yes we shouldn't hang. > > RE side effects, open() is a fairly innocuous

bug#28859: Segmentation fault with NULL pointer dereference in 'stty'

2017-10-17 Thread Jim Meyering
On Tue, Oct 17, 2017 at 12:37 AM, Pádraig Brady <p...@draigbrady.com> wrote: > On 16/10/17 10:49, Jim Meyering wrote: >> On Mon, Oct 16, 2017 at 2:30 AM, Pádraig Brady <p...@draigbrady.com> wrote: >>> On 15/10/17 18:07, Jaeseung Choi wrote: >>>> Dear G

bug#28859: Segmentation fault with NULL pointer dereference in 'stty'

2017-10-16 Thread Jim Meyering
On Mon, Oct 16, 2017 at 2:30 AM, Pádraig Brady wrote: > On 15/10/17 18:07, Jaeseung Choi wrote: >> Dear GNU team, >> >> While testing coreutils for a research purpose, we found the following >> crash in 'stty'. Running stty with the command-line "stty eol -F AA" >> raises a

bug#28506: coreutils 8.28 test suite hangs on APFS filesystem

2017-09-25 Thread Jim Meyering
On Sun, Sep 24, 2017 at 10:34 AM, Jack Howarth wrote: > On Sun, Sep 24, 2017 at 1:16 PM, Jack Howarth < ... > Attached are the tests/touch/trailing-slash.log and > tests/touch/trailing-slash.trs files generated from a build on an APFS > volume running 10.13

bug#28506: coreutils 8.28 test suite hangs on APFS filesystem

2017-09-21 Thread Jim Meyering
On Wed, Sep 20, 2017 at 10:20 PM, Pádraig Brady <p...@draigbrady.com> wrote: > On 18/09/17 18:07, Jack Howarth wrote: >> On Mon, Sep 18, 2017 at 7:40 PM, Jim Meyering <j...@meyering.net> wrote: >> >>> On Mon, Sep 18, 2017 at 4:26 PM, Jack Howarth >>

bug#28506: coreutils 8.28 test suite hangs on APFS filesystem

2017-09-18 Thread Jim Meyering
On Mon, Sep 18, 2017 at 4:26 PM, Jack Howarth <howarth.mailing.li...@gmail.com> wrote: > On Mon, Sep 18, 2017 at 5:08 PM, Jim Meyering <j...@meyering.net> wrote: ... >> Is there any chance your failing test was via a python2 framework? I'm >> asking (on Pádraig's behal

bug#28506: coreutils 8.28 test suite hangs on APFS filesystem

2017-09-18 Thread Jim Meyering
On Mon, Sep 18, 2017 at 1:18 PM, Jack Howarth wrote: > The coreutils 8.28 release, when built on macOS 10.13 under the new APFS > filesystem, produces a hang during the test suite run. The hang appears to > occur in the execution of

bug#28461: erreurs

2017-09-17 Thread Jim Meyering
On Sat, Sep 16, 2017 at 11:27 PM, Assaf Gordon wrote: ... > Attached an updated patch with all instances of 'parameter' > changed to 'argument'. Looks fine. Thank you! I marked the issue as "done".

bug#28461: erreurs

2017-09-15 Thread Jim Meyering
On Fri, Sep 15, 2017 at 8:37 PM, Pádraig Brady wrote: ... > That's a good improvement! Indeed! > > I'd change: > > s/missing more parameters after/missing parameter after/ Or, perhaps use wording similar to what test does: ..._("missing argument after %s")

bug#28054: coreutils 8.27 test failure on x86_64-foxkit-linux-musl

2017-08-13 Thread Jim Meyering
On Sun, Aug 13, 2017 at 1:07 AM, Pádraig Brady wrote: > On 11/08/17 11:49, A. Wilcox wrote: > >> FAIL: tests/misc/csplit-io-err >> == > This was due to an inconsistency in the errors output by seq. > A fix for that buglet is attached. > >> FAIL:

bug#27368: Minor concern: Confusing tail warning

2017-06-17 Thread Jim Meyering
On Sat, Jun 17, 2017 at 3:57 PM, Pádraig Brady <p...@draigbrady.com> wrote: > On 17/06/17 14:30, Pádraig Brady wrote: >> On 17/06/17 07:35, Jim Meyering wrote: >>> In this new function, please move the declaration of "i" into the for-loop: >>> >>

bug#27368: Minor concern: Confusing tail warning

2017-06-17 Thread Jim Meyering
On Sat, Jun 17, 2017 at 1:32 AM, Pádraig Brady wrote: ... > Two proposed patches for this are attached. Nice fixes. Thank you! In the NEWS addition: tail -f will now exit immediately if the output is piped and the reader of the pipe terminates. + tail -f will no

bug#25680: maint: tweaks so syntax tests pass for previous commit

2017-02-15 Thread Jim Meyering
On Wed, Feb 15, 2017 at 11:46 AM, Paul Eggert wrote: > I see some problems with this followup patch: > > http://git.savannah.gnu.org/cgit/coreutils.git/commit/?id=bd4bb42d65aac6591277066739ca42d1ddcc2d0e > > in that it will make force-link.c and force-link.h harder to move to

bug#25041: Bugs in TAC and TAIL for closed stdin

2016-11-27 Thread Jim Meyering
On Sun, Nov 27, 2016 at 7:40 AM, Pádraig Brady wrote: > I'll push the attached later Thanks to both of you. That patch looks fine, modulo a formatting nit: the second line is indented one space too far: + f->ignore = ! (reopen_inaccessible_files +

bug#25004: Bug in OD utility

2016-11-23 Thread Jim Meyering
On Wed, Nov 23, 2016 at 5:16 PM, Marcel Böhme wrote: > Hi Pádraig, > >> On 24 Nov 2016, at 8:45 AM, Pádraig Brady wrote: >> >> I can't reproduce the issue here BTW with ASAN and running in a tight >> loop for a few minutes. So perhaps it has been

bug#25003: Bug in SPLIT utility

2016-11-23 Thread Jim Meyering
On Wed, Nov 23, 2016 at 4:21 PM, Pádraig Brady <p...@draigbrady.com> wrote: > On 23/11/16 22:16, Pádraig Brady wrote: >> On 23/11/16 17:30, Jim Meyering wrote: >>> On Wed, Nov 23, 2016 at 5:22 AM, Marcel Böhme <boehme.mar...@gmail.com> >>> wrote: >>&

bug#25003: Bug in SPLIT utility

2016-11-23 Thread Jim Meyering
On Wed, Nov 23, 2016 at 5:22 AM, Marcel Böhme wrote: > Dear all, > > We are running small 1h fuzzing sessions with AFLFast, a fork of AFL. > We’ll be reporting each found bug separately. > > On Coreutils v8.25 and trunk, the following input crashes. > Option -n was

bug#24874: dd: misleading parsing of hex numbers

2016-11-04 Thread Jim Meyering
On Fri, Nov 4, 2016 at 12:03 PM, Pádraig Brady wrote: > On 04/11/16 16:20, Pádraig Brady wrote: >> On 04/11/16 11:19, Stephan Bauroth wrote: >>> Dear coreutils team :) >>> >>> I encountered a buglike behaviour of dd when handling skip and count >>> parameters that are encoded

bug#24604: Add '--no-preserve-roots' flag to 'rm' for better safety

2016-10-04 Thread Jim Meyering
On Tue, Oct 4, 2016 at 5:54 AM, Pádraig Brady wrote: > On 04/10/16 12:38, Pádraig Brady wrote: >> On 04/10/16 03:21, Mohammed Sadiq wrote: >>> '--no-preserve-root' that can be used to ignore if the path is root when >>> using >>> the 'rm' command. >>> >>> But as the most of

bug#24232: [PATCH] ls: postpone installation of signal handlers

2016-09-06 Thread Jim Meyering
On Tue, Sep 6, 2016 at 10:05 AM, Paul Eggert wrote: > On 09/06/2016 08:59 AM, Pádraig Brady wrote: >> >> Will push later. > > > Before pushing, can you please change the name of "sigs" back to "sig"? I > prefer the old name, as "sig[i]" clearly means "signal i", whereas

bug#24251: Potential cp bug: directories created with --parents and --no-preserve=mode retain original mode bits don't match ~umask

2016-08-18 Thread Jim Meyering
On Thu, Aug 18, 2016 at 5:57 AM, Pádraig Brady wrote: > On 17/08/16 12:42, Mark Mitchell wrote: >> Hi, >> >> I'm writing to report a potential bug with cp. I don't think the mode bits >> always get properly set on directories created when using the --parents >> option

bug#23825: maint: avoid md5sum.c warning from bleeding-edge gcc's -Wstrict-overflow

2016-06-23 Thread Jim Meyering
On Thu, Jun 23, 2016 at 7:26 AM, Pádraig Brady wrote: > On 23/06/16 08:13, Paul Eggert wrote: >> Incidentally, 'yes' has a different bug: it mishandles the case where >> 'write' succeeds but returns a value less than the buffer size. I'll try >> to look into that too.

bug#23825: maint: avoid md5sum.c warning from bleeding-edge gcc's -Wstrict-overflow

2016-06-22 Thread Jim Meyering
um.c:870:3: error: assuming signed overflow does not occur \ when simplifying conditional to constant [-Werror=strict-overflow] * src/md5sum.c (main): Use an unsigned variable as the loop index, rather than optind. From 8912aa7c6dc7acb76d2de648e89098943bfe149a Mon Sep 17 00:00:00 2001

bug#23537: timeout test gets false-positive for duration of -1.189731495357231765e+4932

2016-05-15 Thread Jim Meyering
tags 23537 notabug stop On Sun, May 15, 2016 at 8:06 AM, Jim Meyering <j...@meyering.net> wrote: > On Sun, May 15, 2016 at 4:21 AM, Pádraig Brady <p...@draigbrady.com> wrote: >> Has up to date centos6 the bug? >> I didn't see it with glibc-2.12-1.166.el6_7.7.x86

bug#23537: timeout test gets false-positive for duration of -1.189731495357231765e+4932

2016-05-15 Thread Jim Meyering
On Sun, May 15, 2016 at 4:21 AM, Pádraig Brady wrote: > Has up to date centos6 the bug? > I didn't see it with glibc-2.12-1.166.el6_7.7.x86_64 Yes. I am surprised that you don't see it and I do: $ rpm -q glibc glibc-2.12-1.166.el6_7.7.x86_64 $ src/timeout 0.1 sleep

bug#23537: timeout test gets false-positive for duration of -1.189731495357231765e+4932

2016-05-14 Thread Jim Meyering
On systems with recent glibc, this abuse of timeout elicits the expected error: $ src/timeout -- -1.189731495357231765e+4932 sleep 0 src/timeout: invalid time interval ‘-1.189731495357231765e+4932’ Try 'src/timeout --help' for more information. But with glibc-2.12's strtod, that input maps

bug#23442: [PATCH] maint: avoid new warning from gcc (GCC) 7.0.0 20160503 (experimental)

2016-05-05 Thread Jim Meyering
On Thu, May 5, 2016 at 1:54 AM, Bernhard Voelker <m...@bernhard-voelker.de> wrote: > On 05/04/2016 05:08 PM, Jim Meyering wrote: >> Subject: [PATCH] maint: avoid new warning from gcc (GCC) 7.0.0 20160503 >> (experimental) >> >> * src/id.c (main): When conf

bug#23442: [PATCH] maint: avoid new warning from gcc (GCC) 7.0.0 20160503 (experimental)

2016-05-04 Thread Jim Meyering
On Wed, May 4, 2016 at 12:40 AM, Bernhard Voelker <m...@bernhard-voelker.de> wrote: > On 05/04/2016 05:59 AM, Jim Meyering wrote: >> - bool default_format = (just_user + just_group + just_group_list >> + bool default_format = (0U + just_user + just_gr

bug#23073: wc reports wrong byte counts when using '--from-files0=-'

2016-03-21 Thread Jim Meyering
On Sun, Mar 20, 2016 at 5:59 PM, William R. Fraser wrote: > When wc gets its list of files by reading from stdin, using the argument > '--from-files0=-', it reuses the same fstatus struct for each file. > > The problem is that the 'wc' function checks the 'failed' member of

bug#22931: tests/split/filter.sh fails on an XFS file system

2016-03-08 Thread Jim Meyering
On Sun, Mar 6, 2016 at 7:36 PM, Jim Meyering <j...@meyering.net> wrote: > The split/filter.sh test would fail like this: > > $ make check TESTS=tests/split/filter.sh VERBOSE=yes SUBDIRS=. > + truncate -s9223372036854775807 zero.in > + timeout 10 sh -c 'split --filter=&qu

bug#22931: tests/split/filter.sh fails on an XFS file system

2016-03-06 Thread Jim Meyering
On Sun, Mar 6, 2016 at 7:36 PM, Jim Meyering <j...@meyering.net> wrote: > The split/filter.sh test would fail like this: > > $ make check TESTS=tests/split/filter.sh VERBOSE=yes SUBDIRS=. > + truncate -s9223372036854775807 zero.in > + timeout 10 sh -c 'split --filter=&qu

bug#22931: tests/split/filter.sh fails on an XFS file system

2016-03-06 Thread Jim Meyering
he commit log with the issue URL as soon as it's assigned] From 889415ab359c943ee4c358f8c5fb07bca95a4ead Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyer...@fb.com> Date: Sun, 6 Mar 2016 16:38:01 -0800 Subject: [PATCH] tests: avoid false-failure of split/filter.sh on XFS * tests/split/filter.sh: Use OFF_

bug#22909: [PATCH] test: Document that -a and -o are undesirable

2016-03-04 Thread Jim Meyering
On Fri, Mar 4, 2016 at 9:50 AM, Jim Meyering <j...@meyering.net> wrote: > On Fri, Mar 4, 2016 at 9:12 AM, Pádraig Brady <p...@draigbrady.com> wrote: >> On 04/03/16 08:55, Eric Blake wrote: > ... >>> +NOTE: Use of binary -a and -o create inherently ambiguous situati

bug#22909: [PATCH] test: Document that -a and -o are undesirable

2016-03-04 Thread Jim Meyering
On Fri, Mar 4, 2016 at 9:12 AM, Pádraig Brady wrote: > On 04/03/16 08:55, Eric Blake wrote: ... >> +NOTE: Use of binary -a and -o create inherently ambiguous situations. I like that, too. Thanks. One nit: s/create/creates/

bug#22698: ls output changes considered unacceptable

2016-02-17 Thread Jim Meyering
On Wed, Feb 17, 2016 at 8:46 AM, Mike Hodson wrote: >>On Tue, Feb 16, 2016 at 6:45 AM, Bernhard Voelker >>wrote: >>> On 02/16/2016 11:50 AM, Jason A. Donenfeld wrote: >>> [...] We don't want those single quotes. >> >> >> Who exactly is "we"? >> >> I

bug#22042: don't say K bytes on both head and tail's man pages

2015-11-30 Thread Jim Meyering
On Mon, Nov 30, 2015 at 6:52 AM, Pádraig Brady wrote: > On 29/11/15 23:35, Bernhard Voelker wrote: >> On 11/29/2015 12:16 AM, Pádraig Brady wrote: >>> I remember having slight reservations about K too. >>> http://lists.gnu.org/archive/html/bug-coreutils/2009-05/msg00279.html

bug#15604: [coreutils] [PATCH] md5sum: Add option to ignore non-existant files

2015-11-23 Thread Jim Meyering
On Mon, Nov 23, 2015 at 2:20 PM, Pádraig Brady wrote: >> I'll push a bit later today. > > Pushed at > http://git.sv.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=v8.24-91-g9fd0662 > Marking http://bugs.gnu.org/15604 done Given how this warns/fails when using --check does

bug#15604: [coreutils] [PATCH] md5sum: Add option to ignore non-existant files

2015-11-23 Thread Jim Meyering
On Mon, Nov 23, 2015 at 5:24 PM, Pádraig Brady <p...@draigbrady.com> wrote: > On 23/11/15 16:05, Jim Meyering wrote: >> On Mon, Nov 23, 2015 at 2:20 PM, Pádraig Brady <p...@draigbrady.com> wrote: >>>> I'll push a bit later today. >>> >>> Pushed at

bug#15604: [coreutils] [PATCH] md5sum: Add option to ignore non-existant files

2015-11-23 Thread Jim Meyering
On Mon, Nov 23, 2015 at 6:24 PM, Pádraig Brady <p...@draigbrady.com> wrote: > On 23/11/15 16:41, Jim Meyering wrote: >> I think a common expected usage of --ignore-missing would be >> the case of an SHA1SUM file listing all possibly-verified files for >> which it is co

bug#21356: BUG: split shorter version of '--numeric-suffixes' give error

2015-08-31 Thread Jim Meyering
On Mon, Aug 31, 2015 at 10:13 AM, Pádraig Brady wrote: > I'll apply the attached later. Nice. Thanks to both of you.

bug#20998: Out of bounds global read in shred / genpattern()

2015-07-06 Thread Jim Meyering
On Mon, Jul 6, 2015 at 5:45 PM, Pádraig Brady p...@draigbrady.com wrote: On 07/07/15 00:29, Hanno Böck wrote: Hi, There is an out of bounds read error in the function genpattern() in shred (coreutils 8.23). This issue only appears randomly. To test: a) recompile coreutils 8.23 with address

bug#20923: mgetgroups.c vs getgrouplist warning on OS X

2015-06-30 Thread Jim Meyering
On Tue, Jun 30, 2015 at 9:36 AM, Paul Eggert egg...@cs.ucla.edu wrote: Jim Meyering wrote: same result as before: OK, let's give up on this approach and try something more direct. I installed the attached patch; does it work on OS X? Perfect. I made latest coreutils use latest from gnulib

bug#20923: mgetgroups.c vs getgrouplist warning on OS X

2015-06-29 Thread Jim Meyering
On Sun, Jun 28, 2015 at 11:48 PM, Paul Eggert egg...@cs.ucla.edu wrote: Jim Meyering wrote: I compiled the just-published snapshot on OS X configured with --enable-gcc-warnings, and saw this: lib/mgetgroups.c: In function 'mgetgroups': lib/mgetgroups.c:90:45: error: pointer targets

bug#20923: mgetgroups.c vs getgrouplist warning on OS X

2015-06-29 Thread Jim Meyering
On Mon, Jun 29, 2015 at 2:01 PM, Jim Meyering j...@meyering.net wrote: On Mon, Jun 29, 2015 at 11:39 AM, Paul Eggert egg...@cs.ucla.edu wrote: Jim Meyering wrote: the first variant compiled just fine here (and probably everywhere), so HAVE_GETGROUPLIST_WITH_INT was not defined. Yes, well

bug#20923: mgetgroups.c vs getgrouplist warning on OS X

2015-06-29 Thread Jim Meyering
On Mon, Jun 29, 2015 at 7:19 PM, Paul Eggert egg...@cs.ucla.edu wrote: Jim Meyering wrote: Darn it. I see that I mistakenly pushed one of your patches when I pushed the linkat.m4 fix, Paul. Sorry about that. Happy to revert, if you'd like that. Let me know. No problem. I installed

bug#20923: mgetgroups.c vs getgrouplist warning on OS X

2015-06-28 Thread Jim Meyering
I compiled the just-published snapshot on OS X configured with --enable-gcc-warnings, and saw this: lib/mgetgroups.c: In function 'mgetgroups': lib/mgetgroups.c:90:45: error: pointer targets in passing argument 3 of 'getgrouplist' differ in signedness [-Werror=pointer-sign] ng =

bug#20536: avoid new gcc warning: ENOTSUP vs EOPNOTSUPP

2015-05-10 Thread Jim Meyering
On Sun, May 10, 2015 at 7:17 AM, Paul Eggert egg...@cs.ucla.edu wrote: Jim Meyering wrote: + return err == EOPNOTSUPP +#if ENOTSUP != EOPNOTSUPP +|| err == ENOTSUP +#endif +; Would the following work instead? It's a bit cleaner to avoid #if: return err == EOPNOTSUPP

bug#20536: avoid new gcc warning: ENOTSUP vs EOPNOTSUPP

2015-05-09 Thread Jim Meyering
Building with very new gcc-from-git, I encountered 3 new warnings. Here's a patch to address them: Without this change, very recent gcc (e.g., version 6.0.0 20150509) would print the following when configured with --enable-gcc-warnings: src/copy.c:165:30: error: logical 'or' of equal

bug#20354: [feature request] ln with command line arguments in reverse order

2015-04-19 Thread Jim Meyering
On Sun, Apr 19, 2015 at 8:27 AM, Ma Jiehong ma.jieh...@gmail.com wrote: The translation in the help message is not wrong, and TARGET and LINK_NAME are used. The issue simply is with the mental model made when approaching the ln command. In French, the usual way to say when creating a link is:

bug#20214: Nohup input redirection inconsistent with documentation

2015-03-29 Thread Jim Meyering
On Fri, Mar 27, 2015 at 7:14 PM, Jim Meyering j...@meyering.net wrote: On Fri, Mar 27, 2015 at 3:11 PM, Paul Eggert egg...@cs.ucla.edu wrote: Isaac Schwabacher wrote: This is confusing at best Yes, at the very least the documentation should be improved. I installed the attached patch

bug#20214: Nohup input redirection inconsistent with documentation

2015-03-27 Thread Jim Meyering
On Fri, Mar 27, 2015 at 3:11 PM, Paul Eggert egg...@cs.ucla.edu wrote: Isaac Schwabacher wrote: This is confusing at best Yes, at the very least the documentation should be improved. I installed the attached patch to try to do that. Is it really better for a read on stdin to fail with

bug#20114: tr does not support multibyte characters in the first argument

2015-03-17 Thread Jim Meyering
On Mon, Mar 16, 2015 at 5:15 AM, Pádraig Brady p...@draigbrady.com wrote: ... Yes you're right Bruno. Multi-byte support in coreutils in general has languished, but we hope to start improving support in the next major release (9?) after the current imminent 8.24 stable release. To that end

bug#19969: problem: wc -c doesn't read actual # of bytes in file

2015-03-02 Thread Jim Meyering
On Mon, Mar 2, 2015 at 1:29 PM, Linda Walsh coreut...@tlinx.org wrote: Jim Meyering wrote: As root: # cd /proc # find -H [^0-9]* -name self -prune -o -name thread-self -prune -o -type f ! -name kmsg ! -name kcore ! -name kpagecount ! -name kpageflags -print0|wc -c --files0-from=- |sort

bug#19969: problem: wc -c doesn't read actual # of bytes in file

2015-03-02 Thread Jim Meyering
On Sat, Feb 28, 2015 at 12:59 AM, Linda Walsh coreut...@tlinx.org wrote: (coreutils-8.21-7.7.7) wc -c(bytes) doesn't seem to reliably read the number of bytes in a file. I was wanting to find out what the largest data-source files in '/proc' and '/sys' (didn't get around to trying /sys,

bug#19503: most translations of proper names aren't being used

2015-01-04 Thread Jim Meyering
On Sun, Jan 4, 2015 at 7:53 AM, Pádraig Brady p...@draigbrady.com wrote: ... Also there is the more general point about how correct it is to attribute a program to author(s) in any case, as that tracked to a much more accurate level of detail by git blame etc. Should we be removing output of

bug#19503: most translations of proper names aren't being used

2015-01-04 Thread Jim Meyering
On Sun, Jan 4, 2015 at 9:43 AM, Pádraig Brady p...@draigbrady.com wrote: ... BTW, it might have been nice to have the initial git commits for these tools attributed to the original author. Hindsight and all that :) It would have been nice, indeed. When I agreed to do the job of maintaining the

bug#19456: GNU coreutils - touch / add -v, --verbose option

2014-12-28 Thread Jim Meyering
On Sun, Dec 28, 2014 at 12:33 AM, Jari Aalto jari.aa...@cante.net wrote: It would be nice to see progress of touched files. Please add option[1]: Hi Jari, My preference is to avoid adding the --verbose option to programs like touch. Here is some explanation for why I have seriously considered

bug#19377: bug#19378: [PATCH 3/4] cat, chcon, chgrp, chmod, chown, cp, du, head: support wildcards on OS/2

2014-12-18 Thread Jim Meyering
On Mon, Dec 15, 2014 at 9:11 PM, KO Myung-Hun kom...@gmail.com wrote: Jim Meyering wrote: On Mon, Dec 15, 2014 at 8:35 PM, KO Myung-Hun kom...@gmail.com wrote: Paul Eggert wrote: KO Myung-Hun wrote: /* Redirection and wildcarding when done by the utility itself. Generally a noop

bug#19377: bug#19378: [PATCH 3/4] cat, chcon, chgrp, chmod, chown, cp, du, head: support wildcards on OS/2

2014-12-15 Thread Jim Meyering
On Mon, Dec 15, 2014 at 12:57 AM, Pádraig Brady p...@draigbrady.com wrote: On 15/12/14 01:15, KO Myung-Hun wrote: Pádraig Brady wrote: forcemerge 19378 19377 stop On 14/12/14 03:47, KO Myung-Hun wrote: And ln,ls,mv,rm,tail. * src/cat.c (main): Expand wildcards on OS/2. * src/chcon.c

bug#19377: bug#19378: [PATCH 3/4] cat, chcon, chgrp, chmod, chown, cp, du, head: support wildcards on OS/2

2014-12-15 Thread Jim Meyering
On Mon, Dec 15, 2014 at 8:35 PM, KO Myung-Hun kom...@gmail.com wrote: Paul Eggert wrote: KO Myung-Hun wrote: /* Redirection and wildcarding when done by the utility itself. Generally a noop, but used in particular for native VMS. */ #ifndef initialize_main -# define

bug#19377: bug#19376: [PATCH 4/4] build: use -pi.bak instead of -pi

2014-12-14 Thread Jim Meyering
On Sun, Dec 14, 2014 at 5:25 AM, Pádraig Brady p...@draigbrady.com wrote: forcemerge 19376 19377 stop On 14/12/14 03:47, KO Myung-Hun wrote: This fixes the following error. - Can't do inplace edit without backup. - * Makefile.am (dist-hook): Use -pi.bak instead of -pi. *

bug#18621: [BUG] wc -c incorrectly counts bytes in /sys

2014-10-07 Thread Jim Meyering
On Tue, Oct 7, 2014 at 5:36 PM, Pádraig Brady p...@draigbrady.com wrote: On 10/08/2014 12:51 AM, Paul Eggert wrote: Paul Eggert wrote: The attached patch still needs a changelog entry and test cases. I wrote those up and pushed the attached patch; this should fix the bug so I'm closing the

bug#18621: [BUG] wc -c incorrectly counts bytes in /sys

2014-10-03 Thread Jim Meyering
On Fri, Oct 3, 2014 at 9:48 AM, Pádraig Brady p...@draigbrady.com wrote: On 10/03/2014 03:47 PM, George Shuklin wrote: ... I'm not sure where the above code comes from, by coreutils trunk has the same behavior with these files. We could avoid it with the following patch. Note in the case

bug#17833: coreutils 8.22 df

2014-07-11 Thread Jim Meyering
On Thu, Jul 10, 2014 at 4:28 PM, Pádraig Brady p...@draigbrady.com wrote: The attached should handle this by giving precedence to displaying real device nodes. Thanks. That looks fine. I'd add an s to that NEWS entry: s/give/gives/ + df now give precedence to displaying real device nodes in

bug#7320: [PATCH] 'id' prints incorrectly groups for the session

2014-06-26 Thread Jim Meyering
On Thu, Jun 26, 2014 at 3:23 AM, Pádraig Brady p...@draigbrady.com wrote: -g=$(id -u $NON_ROOT_USERNAME) || framework_failure_ +u=$(id -u $NON_ROOT_USERNAME) || framework_failure_ +g=u This will work better :-) g=$u

bug#17495: chgrp: mention of being a member of the target group

2014-06-19 Thread Jim Meyering
Looks fine. Two nits barely worth mentioning: one in the .texi file: s/group in/group of/ one in the log: s/\*man/* man/ Also, in the relative formality of documentation, it's slightly better to write It is than It's

bug#17590: [PATCH] build: libstdbuf.so: avoid new OS X link failure

2014-05-26 Thread Jim Meyering
On Mon, May 26, 2014 at 1:25 AM, Pádraig Brady p...@draigbrady.com wrote: On 05/25/2014 11:19 PM, Jim Meyering wrote: On Sun, May 25, 2014 at 1:31 PM, Pádraig Brady p...@draigbrady.com wrote: On 05/25/2014 08:48 PM, Jim Meyering wrote: Without the attached patch, I'd get this new link failure

bug#17590: [PATCH] build: libstdbuf.so: avoid new OS X link failure

2014-05-25 Thread Jim Meyering
Without the attached patch, I'd get this new link failure on OS X: Undefined symbols for architecture x86_64: _libintl_gettext, referenced from: _apply_mode in src_libstdbuf_so-libstdbuf.o ld: symbol(s) not found for architecture x86_64 collect2: error: ld returned 1 exit status make[2]:

bug#17590: [PATCH] build: libstdbuf.so: avoid new OS X link failure

2014-05-25 Thread Jim Meyering
On Sun, May 25, 2014 at 1:31 PM, Pádraig Brady p...@draigbrady.com wrote: On 05/25/2014 08:48 PM, Jim Meyering wrote: Without the attached patch, I'd get this new link failure on OS X: Undefined symbols for architecture x86_64: _libintl_gettext, referenced from: _apply_mode

bug#17455: [PATCH] shred: fix overflow checking of command-line options

2014-05-10 Thread Jim Meyering
On Sat, May 10, 2014 at 11:42 AM, Paul Eggert egg...@cs.ucla.edu wrote: * src/shred.c (main): Limit -n (number of passes) value to ULONG_MAX, not to UINT32_MAX, since the vars are unsigned long. Limit the -s (file size) value to OFF_T_MAX. --- src/shred.c | 9 + 1 file changed, 5

bug#16171: ptx: heap buffer overrun, when run with two file arguments

2014-04-28 Thread Jim Meyering
On Mon, Apr 28, 2014 at 6:52 AM, Pádraig Brady p...@draigbrady.com wrote: ... I see it here too (as the only failure in make check with -fsanitize=address The attached should address this. Thanks for taking the time to address that. The patch looks fine, modulo what looks like an

bug#17035: [PATCH] chmod -c -R produces errors with special permissions

2014-03-18 Thread Jim Meyering
On Tue, Mar 18, 2014 at 11:45 AM, Pádraig Brady p...@draigbrady.com wrote: diff --git a/tests/chmod/c-option.sh b/tests/chmod/c-option.sh ... +# This should never warn, but in did when special +# bits are set on b (the common case under test) +chmod -c -R g+w a 2err +test -s err fail=1

bug#17010: Bug#739752: coreutils: ln segfaults when run with --relative and an empty target

2014-03-14 Thread Jim Meyering
On Fri, Mar 14, 2014 at 4:49 AM, Pádraig Brady p...@draigbrady.com wrote: ... Hence since c_f_m() can validly fail even with CAN_MISSING, I agree your patch is correct. Please push. Done.

bug#17010: Bug#739752: coreutils: ln segfaults when run with --relative and an empty target

2014-03-13 Thread Jim Meyering
... Thank you for the bug report! That also affected the very latest code in git. Here is a patch: From a6d2db8b6dfe15344aba4aefe9545eb3a4876d45 Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@fb.com Date: Thu, 13 Mar 2014 17:05:04 -0700 Subject: [PATCH] ln: with -sr, don't segfault for a TARGET

bug#17010: Bug#739752: coreutils: ln segfaults when run with --relative and an empty target

2014-03-13 Thread Jim Meyering
On Thu, Mar 13, 2014 at 7:22 PM, Pádraig Brady p...@draigbrady.com wrote: On 03/14/2014 01:42 AM, Jim Meyering wrote: From a6d2db8b6dfe15344aba4aefe9545eb3a4876d45 Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@fb.com Date: Thu, 13 Mar 2014 17:05:04 -0700 Subject: [PATCH] ln: with -sr

bug#16578: Wish: Support for non-native endianness in od

2014-02-08 Thread Jim Meyering
On Sat, Feb 8, 2014 at 2:01 PM, Pádraig Brady p...@draigbrady.com wrote: + if (input_swap sizeof(T) 1) \ +{ \ + int j;\

bug#16171: ptx: heap buffer overrun, when run with two file arguments

2013-12-16 Thread Jim Meyering
Hi, I built like this using just-built 4.9.0 20131216 (but it probably would work as well with 4.8.x): make check AM_CFLAGS='-ggdb3 -static-libasan -fsanitize=address' AM_LDFLAGS='-fsanitize=address -static-libasan -lpthread -ldl' and then I ran this, echo a a echo b b ./ptx

bug#15970: [Bug-tar] Crash in gettext() after fork() on Mac OS X

2013-11-26 Thread Jim Meyering
Hi Pádraig, Thanks for dealing with that. Your patch looks correct. Did you consider using inttostr in place of that first part of async_safe_error?

bug#15926: RFE: unlink command already uses 'unlink' call; make 'rm' use 'remove' call

2013-11-21 Thread Jim Meyering
On Wed, Nov 20, 2013 at 4:03 PM, Bernhard Voelker m...@bernhard-voelker.de wrote: On 11/20/2013 02:44 PM, Eric Blake wrote: On 11/19/2013 11:45 PM, Bernhard Voelker wrote: Maybe cannot remove directory is a bit weak - it's more like refusing to remove dot|dot-dot|root directory. Indeed, a

bug#15926: RFE: unlink command already uses 'unlink' call; make 'rm' use 'remove' call

2013-11-21 Thread Jim Meyering
On Thu, Nov 21, 2013 at 8:18 AM, Bernhard Voelker m...@bernhard-voelker.de wrote: On 11/21/2013 04:06 PM, Eric Blake wrote: Hard to say that it is considerable bloat without seeing a patch; we already know when the top-level arguments are directories thanks to 'rm -d'. Here's a draft - not

bug#15926: RFE: unlink command already uses 'unlink' call; make 'rm' use 'remove' call

2013-11-21 Thread Jim Meyering
On Thu, Nov 21, 2013 at 5:39 AM, Eric Blake ebl...@redhat.com wrote: On 11/21/2013 12:12 AM, Bernhard Voelker wrote: ... But that's not what Linda is asking for. She is not asking to pull . out of under her feet. Instead, she wants a command that will recursively remove the children of .,

  1   2   3   4   5   6   7   8   9   10   >