bug#19377: bug#19378: [PATCH 3/4] cat, chcon, chgrp, chmod, chown, cp, du, head: support wildcards on OS/2
On Mon, Dec 15, 2014 at 9:11 PM, KO Myung-Hun kom...@gmail.com wrote: Jim Meyering wrote: On Mon, Dec 15, 2014 at 8:35 PM, KO Myung-Hun kom...@gmail.com wrote: Paul Eggert wrote: KO Myung-Hun wrote: /* Redirection and wildcarding when done by the utility itself. Generally a noop, but used in particular for native VMS. */ #ifndef initialize_main -# define initialize_main(ac, av) +# ifndef __OS2__ +# define initialize_main(ac, av) +# else What happened to VMS? The comment doesn't seem to match the code, and I don't know of VMS. Do you mean to change comments for OS/2 ? this suggests that the code should be moved to wherever VMS does its thing. Where is it ? I didn't find initialize_main() or others for VMS. It was never defined in any version-controlled file, so please just update the comment, replacing VMS with OS/2. Ok. Fixed. Thanks. Pushed with minor grammar fixes in the commit log.
bug#19375: closed (Re: bug#19377: bug#19378: [PATCH 3/4] cat, chcon, chgrp, chmod, chown, cp, du, head: support wildcards on OS/2)
GNU bug Tracking System wrote: Your bug report #19377: [PATCH 1/4] doc: add $(EXEEXT) suffix to the executables which was filed against the coreutils package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 19...@debbugs.gnu.org. #19375 was closed without applied. Any problem ? [..] Subject: [PATCH 1/4] doc: add $(EXEEXT) suffix to the executables From: KO Myung-Hun kom...@gmail.com Date: 14-12-14 12:47 오후 To: bug-coreutils@gnu.org To: bug-coreutils@gnu.org * man/local.mk: Add $(EXEEXT) suffix to the executables. --- man/local.mk | 217 ++- 1 file changed, 109 insertions(+), 108 deletions(-) diff --git a/man/local.mk b/man/local.mk index 24cdce0..6687502 100644 --- a/man/local.mk +++ b/man/local.mk @@ -58,112 +58,112 @@ else # Most prog.1 man pages depend on src/prog. List the exceptions: # Note that dir and vdir are exceptions only if you consider the name # of the .c file upon which they depend: ls.c. -man/arch.1: src/uname -man/dir.1: src/dir -man/install.1: src/ginstall -man/vdir.1: src/vdir - -man/base64.1:src/base64 -man/basename.1: src/basename -man/cat.1: src/cat -man/chcon.1: src/chcon -man/chgrp.1: src/chgrp -man/chmod.1: src/chmod -man/chown.1: src/chown -man/chroot.1:src/chroot -man/cksum.1: src/cksum -man/comm.1: src/comm -man/coreutils.1: src/coreutils -man/cp.1:src/cp -man/csplit.1:src/csplit -man/cut.1: src/cut -man/date.1: src/date -man/dd.1:src/dd -man/df.1:src/df -man/dircolors.1: src/dircolors -man/dirname.1: src/dirname -man/du.1:src/du -man/echo.1: src/echo -man/env.1: src/env -man/expand.1:src/expand -man/expr.1: src/expr -man/factor.1:src/factor -man/false.1: src/false -man/fmt.1: src/fmt -man/fold.1: src/fold -man/groups.1:src/groups -man/head.1: src/head -man/hostid.1:src/hostid -man/hostname.1: src/hostname -man/id.1:src/id -man/join.1: src/join -man/kill.1: src/kill -man/link.1: src/link -man/ln.1:src/ln -man/logname.1: src/logname -man/ls.1:src/ls -man/md5sum.1:src/md5sum -man/mkdir.1: src/mkdir -man/mkfifo.1:src/mkfifo -man/mknod.1: src/mknod -man/mktemp.1:src/mktemp -man/mv.1:src/mv -man/nice.1: src/nice -man/nl.1:src/nl -man/nohup.1: src/nohup -man/nproc.1: src/nproc -man/numfmt.1:src/numfmt -man/od.1:src/od -man/paste.1: src/paste -man/pathchk.1: src/pathchk -man/pinky.1: src/pinky -man/pr.1:src/pr -man/printenv.1: src/printenv -man/printf.1:src/printf -man/ptx.1: src/ptx -man/pwd.1: src/pwd -man/readlink.1: src/readlink -man/realpath.1: src/realpath -man/rm.1:src/rm -man/rmdir.1: src/rmdir -man/runcon.1:src/runcon -man/seq.1: src/seq -man/sha1sum.1: src/sha1sum -man/sha224sum.1: src/sha224sum -man/sha256sum.1: src/sha256sum -man/sha384sum.1: src/sha384sum -man/sha512sum.1: src/sha512sum -man/shred.1: src/shred -man/shuf.1: src/shuf -man/sleep.1: src/sleep -man/sort.1: src/sort -man/split.1: src/split -man/stat.1: src/stat -man/stdbuf.1:src/stdbuf -man/stty.1: src/stty -man/sum.1: src/sum -man/sync.1: src/sync -man/tac.1: src/tac -man/tail.1: src/tail -man/tee.1: src/tee -man/test.1: src/test -man/timeout.1: src/timeout -man/touch.1: src/touch -man/tr.1:src/tr -man/true.1: src/true -man/truncate.1: src/truncate -man/tsort.1: src/tsort -man/tty.1: src/tty -man/uname.1: src/uname -man/unexpand.1: src/unexpand -man/uniq.1: src/uniq -man/unlink.1:src/unlink -man/uptime.1:src/uptime -man/users.1: src/users -man/wc.1:src/wc -man/who.1: src/who -man/whoami.1:src/whoami -man/yes.1: src/yes +man/arch.1: src/uname$(EXEEXT) +man/dir.1: src/dir$(EXEEXT) +man/install.1: src/ginstall$(EXEEXT) +man/vdir.1: src/vdir$(EXEEXT) + +man/base64.1:src/base64$(EXEEXT) +man/basename.1: src/basename$(EXEEXT) +man/cat.1: src/cat$(EXEEXT) +man/chcon.1: src/chcon$(EXEEXT) +man/chgrp.1: src/chgrp$(EXEEXT) +man/chmod.1: src/chmod$(EXEEXT) +man/chown.1: src/chown$(EXEEXT) +man/chroot.1:src/chroot$(EXEEXT) +man/cksum.1: src/cksum$(EXEEXT) +man/comm.1: src/comm$(EXEEXT) +man/coreutils.1: src/coreutils$(EXEEXT) +man/cp.1:src/cp$(EXEEXT) +man/csplit.1:src/csplit$(EXEEXT) +man/cut.1: src/cut$(EXEEXT) +man/date.1: src/date$(EXEEXT) +man/dd.1:src/dd$(EXEEXT) +man/df.1:src/df$(EXEEXT) +man/dircolors.1: src/dircolors$(EXEEXT)
bug#19375: closed (Re: bug#19377: bug#19378: [PATCH 3/4] cat, chcon, chgrp, chmod, chown, cp, du, head: support wildcards on OS/2)
reopen 19377 stop On 19/12/14 01:13, KO Myung-Hun wrote: GNU bug Tracking System wrote: Your bug report #19377: [PATCH 1/4] doc: add $(EXEEXT) suffix to the executables which was filed against the coreutils package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 19...@debbugs.gnu.org. #19375 was closed without applied. Any problem ? Jim wasn't aware I'd merged all these bugs to 19377 (which was the top level summary mail), as having separate bugs per patch was confusing and overkill. Anyway don't worry, we'll apply all that's appropriate. I've just now applied this particular patch as it's fine. thanks! Pádraig.
bug#19375: closed (Re: bug#19377: bug#19378: [PATCH 3/4] cat, chcon, chgrp, chmod, chown, cp, du, head: support wildcards on OS/2)
Pádraig Brady wrote: reopen 19377 stop On 19/12/14 01:13, KO Myung-Hun wrote: GNU bug Tracking System wrote: Your bug report #19377: [PATCH 1/4] doc: add $(EXEEXT) suffix to the executables which was filed against the coreutils package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 19...@debbugs.gnu.org. #19375 was closed without applied. Any problem ? Jim wasn't aware I'd merged all these bugs to 19377 (which was the top level summary mail), as having separate bugs per patch was confusing and overkill. Anyway don't worry, we'll apply all that's appropriate. I've just now applied this particular patch as it's fine. Thanks a lot!!! ^^ -- KO Myung-Hun Using Mozilla SeaMonkey 2.7.2 Under OS/2 Warp 4 for Korean with FixPak #15 In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM Korean OS/2 User Community : http://www.ecomstation.co.kr
bug#19377: bug#19378: [PATCH 3/4] cat, chcon, chgrp, chmod, chown, cp, du, head: support wildcards on OS/2
On 15/12/14 01:15, KO Myung-Hun wrote: Pádraig Brady wrote: forcemerge 19378 19377 stop On 14/12/14 03:47, KO Myung-Hun wrote: And ln,ls,mv,rm,tail. * src/cat.c (main): Expand wildcards on OS/2. * src/chcon.c (main): Likewise. * src/chgrp.c (main): Likewise. * src/chmod.c (main): Likewise. * src/chown.c (main): Likewise. * src/cp.c (main): Likewise. * src/du.c (main): Likewise. * src/head.c (main): Likewise. * src/ln.c (main): Likewise. * src/ls.c (main): Likewise. * src/mv.c (main): Likewise. * src/rm.c (main): Likewise. * src/tail.c (main): Likewise. Patches from coreutils 8.8 by Paul Smedley. diff --git a/src/cat.c b/src/cat.c index c7bb7e1..0138114 100644 --- a/src/cat.c +++ b/src/cat.c @@ -544,6 +544,10 @@ main (int argc, char **argv) bool show_tabs = false; int file_open_mode = O_RDONLY; +#ifdef __OS2__ + _wildcard (argc, argv); +#endif + Interesing, the OS/2 shell doesn't doe the globbing. Ported unixy shells(sh) support it, but OS/2 default shell(CMD) does not. I'm wondering about the scalability of this. Are there any facilities for dealing with arbitrary numbers of files, like with xargs for example? No. It always processes all files. What are the practical limits of the number of files? It's up to a free memory. Does _wildcard() exit with an error in this case? Call exit(255) with printing an error message. While the adjustment is small, it would be better to avoid the ifdef in all programs. I think there is a -Zwildcard option to auto enable for all programs? Also is there an option to disable this expansion at runtime (which should be documented if available). For example to allow deleting a file called '*', which seems like a more likely occurrence on this platform. thanks, Pádraig.
bug#19377: bug#19378: [PATCH 3/4] cat, chcon, chgrp, chmod, chown, cp, du, head: support wildcards on OS/2
On Mon, Dec 15, 2014 at 12:57 AM, Pádraig Brady p...@draigbrady.com wrote: On 15/12/14 01:15, KO Myung-Hun wrote: Pádraig Brady wrote: forcemerge 19378 19377 stop On 14/12/14 03:47, KO Myung-Hun wrote: And ln,ls,mv,rm,tail. * src/cat.c (main): Expand wildcards on OS/2. * src/chcon.c (main): Likewise. * src/chgrp.c (main): Likewise. * src/chmod.c (main): Likewise. * src/chown.c (main): Likewise. * src/cp.c (main): Likewise. * src/du.c (main): Likewise. * src/head.c (main): Likewise. * src/ln.c (main): Likewise. * src/ls.c (main): Likewise. * src/mv.c (main): Likewise. * src/rm.c (main): Likewise. * src/tail.c (main): Likewise. Patches from coreutils 8.8 by Paul Smedley. diff --git a/src/cat.c b/src/cat.c index c7bb7e1..0138114 100644 --- a/src/cat.c +++ b/src/cat.c @@ -544,6 +544,10 @@ main (int argc, char **argv) bool show_tabs = false; int file_open_mode = O_RDONLY; +#ifdef __OS2__ + _wildcard (argc, argv); +#endif + Interesing, the OS/2 shell doesn't doe the globbing. Ported unixy shells(sh) support it, but OS/2 default shell(CMD) does not. I'm wondering about the scalability of this. Are there any facilities for dealing with arbitrary numbers of files, like with xargs for example? No. It always processes all files. What are the practical limits of the number of files? It's up to a free memory. Does _wildcard() exit with an error in this case? Call exit(255) with printing an error message. While the adjustment is small, it would be better to avoid the ifdef in all programs. I think there is a -Zwildcard option to auto enable for all programs? Also is there an option to disable this expansion at runtime (which should be documented if available). For example to allow deleting a file called '*', which seems like a more likely occurrence on this platform. It would be better still not to modify so many programs directly. Can you instead add one occurrence of that ifdef in system.h, to change the definition of the initialize_main macro that is already used from every main program?
bug#19377: bug#19378: [PATCH 3/4] cat, chcon, chgrp, chmod, chown, cp, du, head: support wildcards on OS/2
Pádraig Brady wrote: On 15/12/14 01:15, KO Myung-Hun wrote: Pádraig Brady wrote: forcemerge 19378 19377 stop On 14/12/14 03:47, KO Myung-Hun wrote: And ln,ls,mv,rm,tail. * src/cat.c (main): Expand wildcards on OS/2. * src/chcon.c (main): Likewise. * src/chgrp.c (main): Likewise. * src/chmod.c (main): Likewise. * src/chown.c (main): Likewise. * src/cp.c (main): Likewise. * src/du.c (main): Likewise. * src/head.c (main): Likewise. * src/ln.c (main): Likewise. * src/ls.c (main): Likewise. * src/mv.c (main): Likewise. * src/rm.c (main): Likewise. * src/tail.c (main): Likewise. Patches from coreutils 8.8 by Paul Smedley. diff --git a/src/cat.c b/src/cat.c index c7bb7e1..0138114 100644 --- a/src/cat.c +++ b/src/cat.c @@ -544,6 +544,10 @@ main (int argc, char **argv) bool show_tabs = false; int file_open_mode = O_RDONLY; +#ifdef __OS2__ + _wildcard (argc, argv); +#endif + Interesing, the OS/2 shell doesn't doe the globbing. Ported unixy shells(sh) support it, but OS/2 default shell(CMD) does not. I'm wondering about the scalability of this. Are there any facilities for dealing with arbitrary numbers of files, like with xargs for example? No. It always processes all files. What are the practical limits of the number of files? It's up to a free memory. Does _wildcard() exit with an error in this case? Call exit(255) with printing an error message. While the adjustment is small, it would be better to avoid the ifdef in all programs. I think there is a -Zwildcard option to auto enable for all programs? Good guess. -Zargs-wild. Also is there an option to disable this expansion at runtime (which should be documented if available). What do you mean by 'at runtime' ? On command line ? Or a function opposite to _wildcard() ? In the former, escaping like unixy shells is used. In the latter, no functions. For example to allow deleting a file called '*', which seems like a more likely occurrence on this platform. both '*' and '?' are illegal for a filename on OS/2. -- KO Myung-Hun Using Mozilla SeaMonkey 2.7.2 Under OS/2 Warp 4 for Korean with FixPak #15 In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM Korean OS/2 User Community : http://www.ecomstation.co.kr
bug#19377: bug#19378: [PATCH 3/4] cat, chcon, chgrp, chmod, chown, cp, du, head: support wildcards on OS/2
KO Myung-Hun wrote: /* Redirection and wildcarding when done by the utility itself. Generally a noop, but used in particular for native VMS. */ #ifndef initialize_main -# define initialize_main(ac, av) +# ifndef __OS2__ +# define initialize_main(ac, av) +# else What happened to VMS? The comment doesn't seem to match the code, and this suggests that the code should be moved to wherever VMS does its thing.
bug#19377: bug#19378: [PATCH 3/4] cat, chcon, chgrp, chmod, chown, cp, du, head: support wildcards on OS/2
Paul Eggert wrote: KO Myung-Hun wrote: /* Redirection and wildcarding when done by the utility itself. Generally a noop, but used in particular for native VMS. */ #ifndef initialize_main -# define initialize_main(ac, av) +# ifndef __OS2__ +# define initialize_main(ac, av) +# else What happened to VMS? The comment doesn't seem to match the code, and I don't know of VMS. Do you mean to change comments for OS/2 ? this suggests that the code should be moved to wherever VMS does its thing. Where is it ? I didn't find initialize_main() or others for VMS. -- KO Myung-Hun Using Mozilla SeaMonkey 2.7.2 Under OS/2 Warp 4 for Korean with FixPak #15 In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM Korean OS/2 User Community : http://www.ecomstation.co.kr
bug#19377: bug#19378: [PATCH 3/4] cat, chcon, chgrp, chmod, chown, cp, du, head: support wildcards on OS/2
On Mon, Dec 15, 2014 at 8:35 PM, KO Myung-Hun kom...@gmail.com wrote: Paul Eggert wrote: KO Myung-Hun wrote: /* Redirection and wildcarding when done by the utility itself. Generally a noop, but used in particular for native VMS. */ #ifndef initialize_main -# define initialize_main(ac, av) +# ifndef __OS2__ +# define initialize_main(ac, av) +# else What happened to VMS? The comment doesn't seem to match the code, and I don't know of VMS. Do you mean to change comments for OS/2 ? this suggests that the code should be moved to wherever VMS does its thing. Where is it ? I didn't find initialize_main() or others for VMS. It was never defined in any version-controlled file, so please just update the comment, replacing VMS with OS/2.
bug#19377: bug#19378: [PATCH 3/4] cat, chcon, chgrp, chmod, chown, cp, du, head: support wildcards on OS/2
Jim Meyering wrote:
On Mon, Dec 15, 2014 at 8:35 PM, KO Myung-Hun kom...@gmail.com wrote:
Paul Eggert wrote:
KO Myung-Hun wrote:
/* Redirection and wildcarding when done by the utility itself.
Generally a noop, but used in particular for native VMS. */
#ifndef initialize_main
-# define initialize_main(ac, av)
+# ifndef __OS2__
+# define initialize_main(ac, av)
+# else
What happened to VMS? The comment doesn't seem to match the code, and
I don't know of VMS. Do you mean to change comments for OS/2 ?
this suggests that the code should be moved to wherever VMS does its thing.
Where is it ? I didn't find initialize_main() or others for VMS.
It was never defined in any version-controlled file,
so please just update the comment, replacing VMS with OS/2.
Ok. Fixed.
--
KO Myung-Hun
Using Mozilla SeaMonkey 2.7.2
Under OS/2 Warp 4 for Korean with FixPak #15
In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM
Korean OS/2 User Community : http://www.ecomstation.co.kr
From de8bd295137f170571ac20b198bebdd7b8ce701c Mon Sep 17 00:00:00 2001
From: KO Myung-Hun k...@chollian.net
Date: Tue, 16 Dec 2014 11:27:28 +0900
Subject: [PATCH] build: expand a response file and a wildcard on OS/2
OS/2 traditional shells(cmd) does not expand a response file(@file)
and a wildcard. Expand them in an utility itself.
* src/system.h (initialize_main): Define on OS/2. Expand a response
file and a wildcard.
---
src/system.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/system.h b/src/system.h
index 8b3f768..2d2635a 100644
--- a/src/system.h
+++ b/src/system.h
@@ -135,9 +135,10 @@ enum
#include inttypes.h
/* Redirection and wildcarding when done by the utility itself.
- Generally a noop, but used in particular for native VMS. */
+ Generally a noop, but used in particular for OS/2. */
#ifndef initialize_main
-# define initialize_main(ac, av)
+# define initialize_main(ac, av) \
+do { _wildcard(ac, av); _response(ac, av); } while (0)
#endif
#include stat-macros.h
--
1.8.5.2
bug#19377: bug#19378: [PATCH 3/4] cat, chcon, chgrp, chmod, chown, cp, du, head: support wildcards on OS/2
forcemerge 19378 19377 stop On 14/12/14 03:47, KO Myung-Hun wrote: And ln,ls,mv,rm,tail. * src/cat.c (main): Expand wildcards on OS/2. * src/chcon.c (main): Likewise. * src/chgrp.c (main): Likewise. * src/chmod.c (main): Likewise. * src/chown.c (main): Likewise. * src/cp.c (main): Likewise. * src/du.c (main): Likewise. * src/head.c (main): Likewise. * src/ln.c (main): Likewise. * src/ls.c (main): Likewise. * src/mv.c (main): Likewise. * src/rm.c (main): Likewise. * src/tail.c (main): Likewise. Patches from coreutils 8.8 by Paul Smedley. diff --git a/src/cat.c b/src/cat.c index c7bb7e1..0138114 100644 --- a/src/cat.c +++ b/src/cat.c @@ -544,6 +544,10 @@ main (int argc, char **argv) bool show_tabs = false; int file_open_mode = O_RDONLY; +#ifdef __OS2__ + _wildcard (argc, argv); +#endif + Interesing, the OS/2 shell doesn't doe the globbing. I'm wondering about the scalability of this. Are there any facilities for dealing with arbitrary numbers of files, like with xargs for example? What are the practical limits of the number of files? Does _wildcard() exit with an error in this case? thanks, Pádraig
bug#19377: bug#19378: [PATCH 3/4] cat, chcon, chgrp, chmod, chown, cp, du, head: support wildcards on OS/2
Pádraig Brady wrote: forcemerge 19378 19377 stop On 14/12/14 03:47, KO Myung-Hun wrote: And ln,ls,mv,rm,tail. * src/cat.c (main): Expand wildcards on OS/2. * src/chcon.c (main): Likewise. * src/chgrp.c (main): Likewise. * src/chmod.c (main): Likewise. * src/chown.c (main): Likewise. * src/cp.c (main): Likewise. * src/du.c (main): Likewise. * src/head.c (main): Likewise. * src/ln.c (main): Likewise. * src/ls.c (main): Likewise. * src/mv.c (main): Likewise. * src/rm.c (main): Likewise. * src/tail.c (main): Likewise. Patches from coreutils 8.8 by Paul Smedley. diff --git a/src/cat.c b/src/cat.c index c7bb7e1..0138114 100644 --- a/src/cat.c +++ b/src/cat.c @@ -544,6 +544,10 @@ main (int argc, char **argv) bool show_tabs = false; int file_open_mode = O_RDONLY; +#ifdef __OS2__ + _wildcard (argc, argv); +#endif + Interesing, the OS/2 shell doesn't doe the globbing. Ported unixy shells(sh) support it, but OS/2 default shell(CMD) does not. I'm wondering about the scalability of this. Are there any facilities for dealing with arbitrary numbers of files, like with xargs for example? No. It always processes all files. What are the practical limits of the number of files? It's up to a free memory. Does _wildcard() exit with an error in this case? Call exit(255) with printing an error message. -- KO Myung-Hun Using Mozilla SeaMonkey 2.7.2 Under OS/2 Warp 4 for Korean with FixPak #15 In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM Korean OS/2 User Community : http://www.ecomstation.co.kr
