bug#36831: Enhance directory move. (was Re: bug#36831: enhance 'directory not empty' message)

2019-08-02 Thread Assaf Gordon
Hello, On 2019-08-02 9:56 p.m., L A Walsh wrote: On 2019/08/02 19:47, Assaf Gordon wrote: Can new merging features be added to 'mv'? yes. But it seems to me these would be better suited for 'higher level' programs (e.g. a GUI file manager). --- But neither the person who posted the

bug#36831: Enhance directory move. (was Re: bug#36831: enhance 'directory not empty' message)

2019-08-02 Thread L A Walsh
On 2019/08/02 19:47, Assaf Gordon wrote: > Can new merging features be added to 'mv'? yes. > But it seems to me these would be better suited for 'higher level' > programs (e.g. a GUI file manager). --- But neither the person who posted the original bug on this nor I are using a GUI, we

bug#36831: Enhance directory move. (was Re: bug#36831: enhance 'directory not empty' message)

2019-08-02 Thread Assaf Gordon
Hello, On Fri, Aug 02, 2019 at 02:41:31AM -0700, L A Walsh wrote: > On 2019/07/28 23:28, Assaf Gordon wrote: > > > > > > $ mkdir A B B/A > > $ touch A/bar B/A/foo > > $ mv A B > > mv: cannot move 'A' to 'B/A': Directory not empty > > > > And the reason (as you've found out) is

bug#36831: Enhance directory move. (was Re: bug#36831: enhance 'directory not empty' message)

2019-08-02 Thread L A Walsh
On 2019/07/28 23:28, Assaf Gordon wrote: > > > $ mkdir A B B/A > $ touch A/bar B/A/foo > $ mv A B > mv: cannot move 'A' to 'B/A': Directory not empty > > And the reason (as you've found out) is that the target directory 'B/A' > is not empty (has the 'foo' file in it). > Had this

bug#36831: enhance 'directory not empty' message

2019-08-01 Thread Assaf Gordon
On Thu, Aug 01, 2019 at 03:58:51PM -0700, Paul Eggert wrote: > Thanks, that's better, but we're still missing some opportunities for > improvement. > > > mv: cannot move 'A' to 'B/A': Target directory not empty > > This should be "Destination" not "Target". [...] > You meant "mv" not

bug#36831: enhance 'directory not empty' message

2019-08-01 Thread Assaf Gordon
Hello, On Wed, Jul 31, 2019 at 08:03:45PM -0700, Paul Eggert wrote: > Assaf Gordon wrote: > > An explicit error explicitly saying "cannot move", and mention the source > > and > > destination, and also "blames" the target directory seems the most > > user-friendly and least ambiguous. > > Sure,

bug#36831: enhance 'directory not empty' message

2019-08-01 Thread Erik Auerswald
Hi, On Wed, Jul 31, 2019 at 04:05:05PM -0600, Assaf Gordon wrote: > On Mon, Jul 29, 2019 at 06:50:46PM -0500, Paul Eggert wrote: > > On 7/29/19 1:28 AM, Assaf Gordon wrote: > > > + if (rename_errno == ENOTEMPTY || rename_errno == EEXIST) > > > +{ > > > + error (0, 0,

bug#36831: enhance 'directory not empty' message

2019-07-31 Thread Paul Eggert
Assaf Gordon wrote: An explicit error explicitly saying "cannot move", and mention the source and destination, and also "blames" the target directory seems the most user-friendly and least ambiguous. Sure, but that handles only the ENOTEMPTY/EEXIST case. How would you handle the EDQUOT,

bug#36831: enhance 'directory not empty' message

2019-07-31 Thread Bernhard Voelker
On 8/1/19 12:05 AM, Assaf Gordon wrote: > Happy to hear your opinion, +1 Including the full context about an error is essential: - what did the tool try to do (at that point)? - what was the problem? (e.g. ENOTEMPTY) - where was the problem: src or dst? Thanks & have a nice day, Berny

bug#36831: enhance 'directory not empty' message

2019-07-31 Thread Assaf Gordon
Hello Paul, On Mon, Jul 29, 2019 at 06:50:46PM -0500, Paul Eggert wrote: > On 7/29/19 1:28 AM, Assaf Gordon wrote: > > + if (rename_errno == ENOTEMPTY || rename_errno == EEXIST) > > +{ > > + error (0, 0, _("cannot move %s to %s: Target directory not > > empty"), > > +

bug#36831: enhance 'directory not empty' message

2019-07-29 Thread Paul Eggert
On 7/29/19 1:28 AM, Assaf Gordon wrote: + if (rename_errno == ENOTEMPTY || rename_errno == EEXIST) +{ + error (0, 0, _("cannot move %s to %s: Target directory not empty"), + quoteaf_n (0, src_name), quoteaf_n (1, dst_name)); Although this is an

bug#36831: enhance 'directory not empty' message

2019-07-29 Thread Jim Meyering
On Sun, Jul 28, 2019 at 11:29 PM Assaf Gordon wrote: ... > What do others think? If this is a desired improvement, I'll finish the > patch with news/tests/etc. ... > [PATCH] mv: improve ENOTEMPTY/EEXIST error message > > Suggested by Alex Mantel in > https://bugs.gnu.org/36831 . > > $ mkdir

bug#36831: enhance 'directory not empty' message

2019-07-29 Thread Assaf Gordon
Hello, On Sun, Jul 28, 2019 at 08:58:59PM +0200, Alex Mantel wrote: [...] > Ah, the target directory does exist! Hmm... But i'd like the message to be > like: > >    $ mv thing/ ../things >    mv: cannot move 'thing' to '../things/things': Targetdirectory not empty > >  

bug#36831: enhance 'directory not empty' message

2019-07-28 Thread Alex Mantel
i couldn't use move:     $ mv thing/ ../things     mv: cannot move 'thing' to '../things/things': Directory not empty An i can not move it. i do not understand why. I have to google and find at stackoverflow:     Though its man page doesn't document it, mv will refuse to rename a     directory