Re: [PATCH]: cp: make -a option preserve SELinux context and xattrs with reduced diagnostics

2009-03-11 Thread Ondřej Vašík
Hello, Jim Meyering wrote: Ondřej Vašík ova...@redhat.com wrote: Jim Meyering wrote: Ondřej Vašík ova...@redhat.com wrote: What about to split that into two patches? One for SELinux changes and one for xattr changes (commited after 7.1) - to make it more safe - and to give other

Re: [PATCH]: cp: make -a option preserve SELinux context and xattrs with reduced diagnostics

2009-03-11 Thread Jim Meyering
Ondřej Vašík wrote: I guess it's time to add the amended cp-a-xattr patch... attached It is indeed. Thanks! I've tweaked NEWS as below and eliminated a space/TAB-only hunk in copy.c. Other than that, I expect to push it very soon -- as soon as make distcheck completes. +++ b/NEWS @@ -35,6

Re: [PATCH]: cp: make -a option preserve SELinux context and xattrs with reduced diagnostics

2009-02-18 Thread Jim Meyering
Ondřej Vašík ova...@redhat.com wrote: Jim Meyering wrote: Ondřej Vašík ova...@redhat.com wrote: What about to split that into two patches? One for SELinux changes and one for xattr changes (commited after 7.1) - to make it more safe - and to give other distros more time to fix the leak...

Re: [PATCH]: cp: make -a option preserve SELinux context and xattrs with reduced diagnostics

2009-02-17 Thread Ondřej Vašík
Jim Meyering wrote: When will the libattr fix be in F10? Upstream report: http://oss.sgi.com/archives/xfs/2009-02/msg00331.html Talked with Fedora attr maintainer and he will do an update for F-10 and Rawhide in day or two - upon the upstream reaction. So it should be in F-10 early next week.

Re: [PATCH]: cp: make -a option preserve SELinux context and xattrs with reduced diagnostics

2009-02-17 Thread Jim Meyering
Ondřej Vašík ova...@redhat.com wrote: Jim Meyering wrote: When will the libattr fix be in F10? Upstream report: http://oss.sgi.com/archives/xfs/2009-02/msg00331.html Talked with Fedora attr maintainer and he will do an update for F-10 and Rawhide in day or two - upon the upstream reaction.

Re: [PATCH]: cp: make -a option preserve SELinux context and xattrs with reduced diagnostics

2009-02-17 Thread Ondřej Vašík
Jim Meyering wrote: Ondřej Vašík ova...@redhat.com wrote: What about to split that into two patches? One for SELinux changes and one for xattr changes (commited after 7.1) - to make it more safe - and to give other distros more time to fix the leak... That sounds even better. I see that

Re: [PATCH]: cp: make -a option preserve SELinux context and xattrs with reduced diagnostics

2009-02-17 Thread Jim Meyering
Ondřej Vašík ova...@redhat.com wrote: Jim Meyering wrote: Ondřej Vašík ova...@redhat.com wrote: What about to split that into two patches? One for SELinux changes and one for xattr changes (commited after 7.1) - to make it more safe - and to give other distros more time to fix the leak...

Re: [PATCH]: cp: make -a option preserve SELinux context and xattrs with reduced diagnostics

2009-02-16 Thread Ondřej Vašík
Jim Meyering wrote: Unfortunately, with this patch, make check fails the cp/link-heap test. Investigating why, I discovered that it introduces a huge leak into cp -a, at least on F10. 80MB worth in this case. I'll let you investigate that one ;-) Leak is in libattr - added by 2.4.43 (~8

Re: [PATCH]: cp: make -a option preserve SELinux context and xattrs with reduced diagnostics

2009-02-16 Thread Jim Meyering
Ondřej Vašík ova...@redhat.com wrote: Jim Meyering wrote: Unfortunately, with this patch, make check fails the cp/link-heap test. Investigating why, I discovered that it introduces a huge leak into cp -a, at least on F10. 80MB worth in this case. I'll let you investigate that one ;-) Leak

[PATCH]: cp: make -a option preserve SELinux context and xattrs with reduced diagnostics

2009-02-09 Thread Ondřej Vašík
Hello, I sent patch about cp -a and it's failure to preserve SELinux context in October 08. Meanwhile xattr support was added to cp. As described in info pages -a option means Preserve as much as possible of the structure and attributes of the original files. Therefore it should preserve xattr if

Re: [PATCH]: cp: make -a option preserve SELinux context and xattrs with reduced diagnostics

2009-02-09 Thread Pádraig Brady
Ondřej Vašík wrote: Hello, I sent patch about cp -a and it's failure to preserve SELinux context in October 08. I missed that. Meanwhile xattr support was added to cp. As described in info pages -a option means Preserve as much as possible of the structure and attributes of the original