Ondřej Vašík wrote:
> Thanks for word tweaks and other patch-amending. I spotted one error -
> initial value of access_changed was not changed to false when you
> changed the name and logic from access_unchanged
thanks Ondřej
Ondřej Vašík wrote:
> Jim Meyering wrote:
>> Ondřej Vašík wrote:
>> > Pádraig Brady wrote:
>> >> Yes I agree that the change is required.
>> >> I've tweaked it so that the geteuid() syscall is only called
>> >> if readonly files. Also I removed the error message on chmod failure
>> >> as the user
Jim Meyering wrote:
> Ondřej Vašík wrote:
> > Pádraig Brady wrote:
> >> Yes I agree that the change is required.
> >> I've tweaked it so that the geteuid() syscall is only called
> >> if readonly files. Also I removed the error message on chmod failure
> >> as the user will still get an error messa
Ondřej Vašík wrote:
> Pádraig Brady wrote:
>> Yes I agree that the change is required.
>> I've tweaked it so that the geteuid() syscall is only called
>> if readonly files. Also I removed the error message on chmod failure
>> as the user will still get an error message _if_ the copy_xattr fails.
>>
Pádraig Brady wrote:
> Yes I agree that the change is required.
> I've tweaked it so that the geteuid() syscall is only called
> if readonly files. Also I removed the error message on chmod failure
> as the user will still get an error message _if_ the copy_xattr fails.
> Also I ran it through inde
Pádraig Brady wrote:
> Ondřej Vašík wrote:
>> Pádraig Brady wrote:
>>> Since we're only doing u+rw, and we've already stat'd it's
>>> probably better to just (sb.mode & S_IWUSR) rather than access(...).
>>> Also a couple of the if statements are indented too far.
>>
>> Hopefully ok with the attach
Ondřej Vašík wrote:
> Pádraig Brady wrote:
>> Since we're only doing u+rw, and we've already stat'd it's
>> probably better to just (sb.mode & S_IWUSR) rather than access(...).
>> Also a couple of the if statements are indented too far.
>
> Hopefully ok with the attached patch.
>
>> This should
0 2001
From: =?utf-8?q?Ond=C5=99ej=20Va=C5=A1=C3=ADk?=
Date: Thu, 3 Sep 2009 16:10:21 +0200
Subject: [PATCH] cp,mv: do preserve extended attributes even for read-only source files
* src/copy.c (copy_reg): Set mode on file descriptor to 0600 for copying
extended attributes to prevent failures w
Ondřej Vašík wrote:
> Pádraig Brady wrote:
>> Ondřej Vašík wrote:
>>> Pádraig Brady wrote:
To minimize side affects perhaps we should only do the chmod(600)
if (geteuid () != 0 && !access (src_name, W_OK)) ?
>>> Good idea, it would reduce possibility of security leak, playing with
>>> acc
Sep 17 00:00:00 2001
From: =?utf-8?q?Ond=C5=99ej=20Va=C5=A1=C3=ADk?=
Date: Thu, 3 Sep 2009 16:10:21 +0200
Subject: [PATCH] cp,mv: do preserve extended attributes even for read-only source files
* src/copy.c (copy_reg): Set mode on file descriptor to 0600 for copying
extended attributes to pre
Ondřej Vašík wrote:
> Pádraig Brady wrote:
>> To minimize side affects perhaps we should only do the chmod(600)
>> if (geteuid () != 0 && !access (src_name, W_OK)) ?
>
> Good idea, it would reduce possibility of security leak, playing with
> access rights is always a bit dangerous (although here w
Pádraig Brady wrote:
> Ondřej Vašík wrote:
> > Ah, I knew I forgot to do something :). Thanks for spotting this.
> >
> > Restoring to dest_mode & ~omitted_permissions done in attached patch,
> > dropped redirections from the test as well. Additionally - I modified
> > the copy.c patch a bit - fail
Ondřej Vašík wrote:
> Ah, I knew I forgot to do something :). Thanks for spotting this.
>
> Restoring to dest_mode & ~omitted_permissions done in attached patch,
> dropped redirections from the test as well. Additionally - I modified
> the copy.c patch a bit - failure of mode change now doesn't mea
Ondřej Vašík wrote:
> Ah, I knew I forgot to do something :). Thanks for spotting this.
>
> Restoring to dest_mode & ~omitted_permissions done in attached patch,
> dropped redirections from the test as well. Additionally - I modified
> the copy.c patch a bit - failure of mode change now doesn't me
y
of solution will be found.
Ok with passing to 7.7, although with such small impact and relatively
low danger, it could maybe included to 7.6 (if more snapshots will be
before real release).
Greetings,
Ondřej
From 5fca1fbaf2e7594496c854f4c3eef60bd3013697 Mon Sep 17 00:00:00 2001
From: =?utf-8?
Pádraig Brady wrote:
> Ondřej Vašík wrote:
>> As reported in
>> http://lists.gnu.org/archive/html/bug-coreutils/2009-08/msg00342.html by
>> Ernest N. Mamikonyan, cp/mv fails to preserve extended attributes for
>> read-only source files.
>> Following patch fixes the issue for me, although maybe it's
Ondřej Vašík wrote:
> As reported in
> http://lists.gnu.org/archive/html/bug-coreutils/2009-08/msg00342.html by
> Ernest N. Mamikonyan, cp/mv fails to preserve extended attributes for
> read-only source files.
> Following patch fixes the issue for me, although maybe it's not perfect
> solution. But
better one at the moment.
Test included...
Greetings,
Ondřej Vašík
From cae691907fe50e2ab05198a7c647fe4140e3669e Mon Sep 17 00:00:00 2001
From: =?utf-8?q?Ond=C5=99ej=20Va=C5=A1=C3=ADk?=
Date: Thu, 3 Sep 2009 16:10:21 +0200
Subject: [PATCH] cp,mv: do preserve extended attributes even for
18 matches
Mail list logo
