Re: [PATCH] df: add `--total' option

2008-01-11 Thread Jim Meyering
Steven Schubiger [EMAIL PROTECTED] wrote: Given that the attached patch works, except that the SIZE argument specified to -B/--block-size parameter doesn't currently make it into the totals, I'd like to hear some opinions how you would make it happen (I have some ideas, but I'd certainly

Re: [PATCH] df: add `--total' option

2008-01-11 Thread Jim Meyering
Steven Schubiger [EMAIL PROTECTED] wrote: Jim Meyering [EMAIL PROTECTED] wrote: Thanks for the patch. However, I haven't even looked at it because there's another that's already gone through some review: Some people from Fujitsu revived a patch by Denis Smit, here: This is the link I meant

Re: [PATCH] df: add `--total' option

2008-01-11 Thread Steven Schubiger
Jim Meyering [EMAIL PROTECTED] wrote: Thanks for the patch. However, I haven't even looked at it because there's another that's already gone through some review: Some people from Fujitsu revived a patch by Denis Smit, here: http://thread.gmane.org/gmane.comp.gnu.coreutils.bugs/11955 I

Re: [PATCH] df: add `--total' option

2008-01-11 Thread Steven Schubiger
Jim Meyering [EMAIL PROTECTED] wrote: This is the link I meant to provide: http://thread.gmane.org/gmane.comp.gnu.coreutils.bugs/11965 From a first glance, this looks far more complete than my approach. Would it be worthwhile to mention such unapplied, yet stalled patches within the TODO

Re: [PATCH] df: add `--total' option

2008-01-11 Thread Jim Meyering
Steven Schubiger [EMAIL PROTECTED] wrote: Jim Meyering [EMAIL PROTECTED] wrote: This is the link I meant to provide: http://thread.gmane.org/gmane.comp.gnu.coreutils.bugs/11965 From a first glance, this looks far more complete than my approach. Would it be worthwhile to mention such

Re: [PATCH] df: add `--total' option

2008-01-11 Thread Steven Schubiger
Jim Meyering [EMAIL PROTECTED] wrote: Thanks for the patch. FTR (for the record), a second version which does some magic to obtain the block-size argument and append it to the output. I don't think, it'll be of much use now, but archiving doesn't hurt. Steven Schubiger diff --git a/src/df.c

[PATCH] df: add `--total' option

2008-01-10 Thread Steven Schubiger
Given that the attached patch works, except that the SIZE argument specified to -B/--block-size parameter doesn't currently make it into the totals, I'd like to hear some opinions how you would make it happen (I have some ideas, but I'd certainly prefer to have some peer- driven effort). Steven