bug#10317: PING - bug#10317: patch to su: -l and -p should not be used together

2012-05-04 Thread Jim Meyering
Rocky Bernstein wrote: Any word on this? Hi Rocky, Sorry about the extended delay. Changing su.c like this has really low priority. I've looked at your patch and see that it changes the semantics of su for those who use -l with (-m or -p). Before your patch, -l would lead to simulate_login

bug#10317: PING - bug#10317: patch to su: -l and -p should not be used together

2012-05-04 Thread Voelker, Bernhard
Jim Meyering wrote: I tried to use the su from coreutils (with or without your patch) and found that it does not work when it attempts to authenticate. E.g., it cannot su to any user on this Fedora 17 system. If su remains so broken that it does not work out-of-the-box on F17, then it's not

bug#10317: PING - bug#10317: patch to su: -l and -p should not be used together

2012-05-04 Thread Rocky Bernstein
On Fri, May 4, 2012 at 4:49 AM, Jim Meyering j...@meyering.net wrote: Rocky Bernstein wrote: Any word on this? Hi Rocky, Sorry about the extended delay. Changing su.c like this has really low priority. I've looked at your patch and see that it changes the semantics of su for those who

bug#10317: PING - bug#10317: patch to su: -l and -p should not be used together

2012-05-04 Thread Jim Meyering
Rocky Bernstein wrote: On Fri, May 4, 2012 at 4:49 AM, Jim Meyering j...@meyering.net wrote: Rocky Bernstein wrote: Any word on this? Hi Rocky, Sorry about the extended delay. Changing su.c like this has really low priority. I've looked at your patch and see

bug#10317: PING - bug#10317: patch to su: -l and -p should not be used together

2012-05-04 Thread Jim Meyering
Jim Meyering wrote: ... I tried to use the su from coreutils (with or without your patch) and found that it does not work when it attempts to authenticate. E.g., it cannot su to any user on this Fedora 17 system. I've just realized my (silly!) error. For su to do its job, it must be set-UID

bug#10317: PING - bug#10317: patch to su: -l and -p should not be used together

2012-05-04 Thread Voelker, Bernhard
Rocky Bernstein wrote: So perhaps for the delays, you or someone reading could make the stylistic changes that would take, what, maybe a few minutes? IMHO no. As Jim is the CU maintainer, he (or Padraig or someone else) will push changes to git. As it's always good to have someone else to

bug#10317: PING - bug#10317: patch to su: -l and -p should not be used together

2012-05-04 Thread Rocky Bernstein
On Fri, May 4, 2012 at 10:07 AM, Jim Meyering j...@meyering.net wrote: Rocky Bernstein wrote: On Fri, May 4, 2012 at 8:19 AM, Jim Meyering j...@meyering.net wrote: ... Please don't interpret my review delays or my misreading your patch as anything deliberately unfriendly. I

bug#10317: PING - bug#10317: patch to su: -l and -p should not be used together

2012-05-03 Thread Rocky Bernstein
Any word on this? On Thu, Apr 12, 2012 at 10:43 PM, Rocky Bernstein ro...@gnu.org wrote: On Sat, Apr 7, 2012 at 2:15 AM, Jim Meyering j...@meyering.net wrote: Rocky Bernstein wrote: Any progress or thoughts on the revised patch? Hi Rocky, Sorry about the delay. I haven't forgotten. I

bug#10317: PING - bug#10317: patch to su: -l and -p should not be used together

2012-04-12 Thread Rocky Bernstein
On Sat, Apr 7, 2012 at 2:15 AM, Jim Meyering j...@meyering.net wrote: Rocky Bernstein wrote: Any progress or thoughts on the revised patch? Hi Rocky, Sorry about the delay. I haven't forgotten. I noticed that your test requires typing a root password. Um, no. I don't know how you got

bug#10317: PING - bug#10317: patch to su: -l and -p should not be used together

2012-04-07 Thread Jim Meyering
Rocky Bernstein wrote: Any progress or thoughts on the revised patch? Hi Rocky, Sorry about the delay. I haven't forgotten. I noticed that your test requires typing a root password. We prefer to avoid that, so that the tests can be run non-interactively. That's why some tests are root-only.

bug#10317: PING - bug#10317: patch to su: -l and -p should not be used together

2012-03-31 Thread Rocky Bernstein
Any progress or thoughts on the revised patch? On Tue, Feb 14, 2012 at 10:53 PM, Rocky Bernstein ro...@gnu.org wrote: Attached should be a revised patch that addresses all of your suggestions. Cheers, rocky On Tue, Feb 14, 2012 at 5:49 AM, Jim Meyering j...@meyering.net wrote: Rocky

bug#10317: PING - bug#10317: patch to su: -l and -p should not be used together

2012-02-21 Thread Philipp Thomas
* Jim Meyering (j...@meyering.net) [20120214 11:49]: I see that Fedora still uses su from coreutils, too, so this is a worthwhile change. openSUSE and SLES are also using su from coreutils. Philipp

bug#10317: PING - bug#10317: patch to su: -l and -p should not be used together

2012-02-14 Thread Jim Meyering
Rocky Bernstein wrote: On Mon, Feb 13, 2012 at 4:19 AM, Jim Meyering j...@meyering.net wrote: Rocky Bernstein wrote: It's been a couple of months since I first sent this was sent without nary an ack. Comments? Hi Rocky, su is barely on life support in coreutils.

bug#10317: PING - bug#10317: patch to su: -l and -p should not be used together

2012-02-14 Thread Voelker, Bernhard
Jim Meyering wrote: I see that Fedora still uses su from coreutils, too, so this is a worthwhile change. So does OpenSuSE. As in coreutils.texi, -l and -p can be used together, although it's not very clear what will happen: @item -m @itemx -p @itemx --preserve-environment ... Parts

bug#10317: PING - bug#10317: patch to su: -l and -p should not be used together

2012-02-14 Thread Rocky Bernstein
Attached should be a revised patch that addresses all of your suggestions. Cheers, rocky On Tue, Feb 14, 2012 at 5:49 AM, Jim Meyering j...@meyering.net wrote: Rocky Bernstein wrote: On Mon, Feb 13, 2012 at 4:19 AM, Jim Meyering j...@meyering.net wrote: Rocky Bernstein wrote:

bug#10317: PING - bug#10317: patch to su: -l and -p should not be used together

2012-02-13 Thread Jim Meyering
Rocky Bernstein wrote: It's been a couple of months since I first sent this was sent without nary an ack. Comments? Hi Rocky, su is barely on life support in coreutils. Meaning that it's no longer really maintained. We stopped installing it (by default) back in the 2007-2008 time frame

bug#10317: PING - bug#10317: patch to su: -l and -p should not be used together

2012-02-13 Thread Rocky Bernstein
On Mon, Feb 13, 2012 at 4:19 AM, Jim Meyering j...@meyering.net wrote: Rocky Bernstein wrote: It's been a couple of months since I first sent this was sent without nary an ack. Comments? Hi Rocky, su is barely on life support in coreutils. Meaning that it's no longer really maintained.

bug#10317: PING - bug#10317: patch to su: -l and -p should not be used together

2012-02-12 Thread Rocky Bernstein
Hi - It's been a couple of months since I first sent this was sent without nary an ack. Comments?