bug#17010: Bug#739752: coreutils: ln segfaults when run with --relative and an empty target

2014-03-14 Thread Jim Meyering
On Fri, Mar 14, 2014 at 9:27 AM, Jim Meyering wrote: > On Fri, Mar 14, 2014 at 4:49 AM, Pádraig Brady wrote: > ... >> Hence since c_f_m() can validly fail even with CAN_MISSING, >> I agree your patch is correct. >> >> Please push. > > Done. Hmm... For the record, I also pushed (accidentally) two

bug#17010: Bug#739752: coreutils: ln segfaults when run with --relative and an empty target

2014-03-14 Thread Jim Meyering
On Fri, Mar 14, 2014 at 4:49 AM, Pádraig Brady wrote: ... > Hence since c_f_m() can validly fail even with CAN_MISSING, > I agree your patch is correct. > > Please push. Done.

bug#17010: Bug#739752: coreutils: ln segfaults when run with --relative and an empty target

2014-03-14 Thread Pádraig Brady
On 03/14/2014 03:44 AM, Jim Meyering wrote: > On Thu, Mar 13, 2014 at 7:22 PM, Pádraig Brady wrote: >> Interesting. So canonicalize_filename_mode() can fail in this case, >> even with CAN_MISSING. It's unexpected that c_f_m() sets errno=ENOENT >> when CAN_MISSING is set. I wonder should we change

bug#17010: Bug#739752: coreutils: ln segfaults when run with --relative and an empty target

2014-03-13 Thread Jim Meyering
On Thu, Mar 13, 2014 at 7:22 PM, Pádraig Brady wrote: > On 03/14/2014 01:42 AM, Jim Meyering wrote: >> From a6d2db8b6dfe15344aba4aefe9545eb3a4876d45 Mon Sep 17 00:00:00 2001 >> From: Jim Meyering >> Date: Thu, 13 Mar 2014 17:05:04 -0700 >> Subject: [PATCH] ln: with -sr, don't segfault for a TARGE

bug#17010: Bug#739752: coreutils: ln segfaults when run with --relative and an empty target

2014-03-13 Thread Pádraig Brady
On 03/14/2014 01:42 AM, Jim Meyering wrote: > From a6d2db8b6dfe15344aba4aefe9545eb3a4876d45 Mon Sep 17 00:00:00 2001 > From: Jim Meyering > Date: Thu, 13 Mar 2014 17:05:04 -0700 > Subject: [PATCH] ln: with -sr, don't segfault for a TARGET of '' > > Prior to this change, "ln -sr '' F" would segfau

bug#17010: Bug#739752: coreutils: ln segfaults when run with --relative and an empty target

2014-03-13 Thread Jim Meyering
On Sat, Feb 22, 2014 at 1:57 AM, Erik Bernstein wrote: > Package: coreutils > Version: 8.21-1 > Severity: normal > > Hi, > > when ln is run with --relative --symbolic and and empty string as the > target, it ungracefully dies with a segmentation fault. The memory > violation appears to happen in s