bug#51011: [GNU sort] Numerical sort with delimiter may be broken (bug)

2021-10-09 Thread Paul Eggert
On 10/9/21 5:00 AM, Pádraig Brady wrote: On 09/10/2021 04:48, Paul Eggert wrote: 'sort' could determine the group sizes from the locale, and reject digit strings that are formatted improperly according to the group-size rules. (Not that I plan to write the code to do that) Yes I agree

bug#51011: [GNU sort] Numerical sort with delimiter may be broken (bug)

2021-10-09 Thread Pádraig Brady
On 09/10/2021 04:48, Paul Eggert wrote: On 10/8/21 7:32 PM, Pádraig Brady wrote: it's not a thousands separator, rather a grouping character, and groups can be in 2, 3, 4, and even 5. Sure, but 'sort' could determine the group sizes from the locale, and reject digit strings that are formatted

bug#51011: [GNU sort] Numerical sort with delimiter may be broken (bug)

2021-10-08 Thread Paul Eggert
On 10/8/21 7:32 PM, Pádraig Brady wrote: it's not a thousands separator, rather a grouping character, and groups can be in 2, 3, 4, and even 5. Sure, but 'sort' could determine the group sizes from the locale, and reject digit strings that are formatted improperly according to the

bug#51011: [GNU sort] Numerical sort with delimiter may be broken (bug)

2021-10-08 Thread Pádraig Brady
On 08/10/2021 21:48, Paul Eggert wrote: On 10/8/21 6:37 AM, Pádraig Brady wrote: The difference here is due to ',' being treated as a thousands sep, not a decimal point. Oh, thanks. Of course! I should have figured that out myself. It is unfortunate that "," is treated as a thousands

bug#51011: [GNU sort] Numerical sort with delimiter may be broken (bug)

2021-10-08 Thread Paul Eggert
On 10/8/21 6:37 AM, Pádraig Brady wrote: The difference here is due to ',' being treated as a thousands sep, not a decimal point. Oh, thanks. Of course! I should have figured that out myself. It is unfortunate that "," is treated as a thousands seperator even though it's obviously not one

bug#51011: [GNU sort] Numerical sort with delimiter may be broken (bug)

2021-10-08 Thread Pádraig Brady
On 04/10/2021 21:01, Paul Eggert wrote: On 10/4/21 08:58, Pádraig Brady wrote: The --debug option points out the issue:   $ printf '%s\n' 1,a 0,9 | sort --debug -nk1 -t ,   sort: key 1 is numeric and spans multiple fields   1,a   _   ___   0,9   ___   ___ As Juncheng points

bug#51011: [GNU sort] Numerical sort with delimiter may be broken (bug)

2021-10-04 Thread Juncheng Yang
Thank you, Paul and Padraig! May I ask when it fails to sort numerically why 1,a comes before 0,9? I could not come up with an ordering that 1,a is smaller. Best, Jason > On Oct 4, 2021, at 4:01 PM, Paul Eggert wrote: > > On 10/4/21 08:58, Pádraig Brady wrote: >> The --debug option

bug#51011: [GNU sort] Numerical sort with delimiter may be broken (bug)

2021-10-04 Thread Paul Eggert
On 10/4/21 08:58, Pádraig Brady wrote: The --debug option points out the issue:   $ printf '%s\n' 1,a 0,9 | sort --debug -nk1 -t ,   sort: key 1 is numeric and spans multiple fields   1,a   _   ___   0,9   ___   ___ As Juncheng points out, it is a bit odd that -n and -g disagree here,

bug#51011: [GNU sort] Numerical sort with delimiter may be broken (bug)

2021-10-04 Thread Pádraig Brady
tag 51011 notabug close 51011 stop On 04/10/2021 15:36, Juncheng Yang wrote: Hi coreutils developers, I have encountered a bug in GNU sort in which sort produces incorrect results when numerical sort with delimiters. For example, sort -nk1 -t , file cannot sort the a file with the

bug#51011: [GNU sort] Numerical sort with delimiter may be broken (bug)

2021-10-04 Thread Davide Brini
On Mon, 4 Oct 2021 10:36:52 -0400, Juncheng Yang wrote: > Hi coreutils developers, > I have encountered a bug in GNU sort in which sort produces incorrect > results when numerical sort with delimiters. For example, sort -nk1 -t , > file cannot sort the a file with the following lines (sort

bug#51011: [GNU sort] Numerical sort with delimiter may be broken (bug)

2021-10-04 Thread Juncheng Yang
Hi coreutils developers, I have encountered a bug in GNU sort in which sort produces incorrect results when numerical sort with delimiters. For example, sort -nk1 -t , file cannot sort the a file with the following lines (sort by the first column numerically) 1,a 0,9 I have tried