bug#51311: [PATCH] echo: update --help to document edge cases

2021-10-22 Thread Florent Flament
Pádraig Brady writes: > Thanks for all the input. > I've now pushed the following to address this: > > https://git.sv.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=f60a3981c > > Notes: > - Brevity in --help and man pages is a feature > - I kept the existing NOTE: style in --help to avoid a

bug#51311: [PATCH] echo: update --help to document edge cases

2021-10-22 Thread Bernhard Voelker
On 10/22/21 16:21, Pádraig Brady wrote: > Thanks for all the input. > I've now pushed the following to address this: > > https://git.sv.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=f60a3981c > > Notes: > - Brevity in --help and man pages is a feature > - I kept the existing NOTE: style in

bug#51311: [PATCH] echo: update --help to document edge cases

2021-10-22 Thread Pádraig Brady
On 21/10/2021 21:54, Bernhard Voelker wrote: On 10/21/21 15:14, Florent Flament wrote: Pádraig Brady writes: +NOTE: printf(1) is a preferred alternative, with more standard option handling.\ I believe that it misses the point. It is still not clear that the echo command doesn't behave as

bug#51311: [PATCH] echo: update --help to document edge cases

2021-10-22 Thread Florent Flament
Bernhard Voelker writes: > On 10/21/21 15:14, Florent Flament wrote: >> NOTE: printf(1) is a preferred alternative, which doesn't share echo's >> inability to handle edge cases. > > I'm not sure that just mentioning "edge cases" will remind people either > that they are falling into such

bug#51311: [PATCH] echo: update --help to document edge cases

2021-10-21 Thread Bernhard Voelker
On 10/21/21 15:14, Florent Flament wrote: > Pádraig Brady writes: >> +NOTE: printf(1) is a preferred alternative, with more standard option >> handling.\ > I believe that it misses the point. It is still not clear that the echo > command doesn't behave as one would expect for a few edge cases.

bug#51311: [PATCH] echo: update --help to document edge cases

2021-10-21 Thread Florent Flament
Pádraig Brady writes: > BTW the env var is POSIXLY_CORRECT, not STRICTLY_POSIX. Nice catch ! > Anyway I don't think we should mention that in the man page anyway. > I'll push the attached later, which just says printf(1) is preferred. I think the man page should warn users about possible bad

bug#51311: [PATCH] echo: update --help to document edge cases

2021-10-21 Thread Pádraig Brady
On 20/10/2021 22:50, Florent Flament wrote: * src/echo.c (usage): Document edge cases when displaying arbitrary strings with the echo command. --- src/echo.c | 8 1 file changed, 8 insertions(+) diff --git a/src/echo.c b/src/echo.c index 18513398a..73b44660b 100644 --- a/src/echo.c

bug#51311: [PATCH] echo: update --help to document edge cases

2021-10-20 Thread Florent Flament
* src/echo.c (usage): Document edge cases when displaying arbitrary strings with the echo command. --- src/echo.c | 8 1 file changed, 8 insertions(+) diff --git a/src/echo.c b/src/echo.c index 18513398a..73b44660b 100644 --- a/src/echo.c +++ b/src/echo.c @@ -78,6 +78,14 @@ If -e is