Re: bugs in dirname module - coreutils portion

2005-11-30 Thread Jim Meyering
Eric Blake [EMAIL PROTECTED] wrote: ... OK, I will do better at not combining whitespace cleanup with real patches. And I agree with your comment that using diff -b as a crutch is not wise, so here is the updated patch with no whitespace filtering. Thanks for the big patch -- and for your

Re: bugs in dirname module - coreutils portion

2005-11-30 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Jim Meyering on 11/30/2005 6:47 AM: Thanks for the big patch -- and for your patience. I've been holding off because I don't want this to interfere with the pending patch to add ACL support. Fine with me. Besides, my copyright

Re: bugs in dirname module - coreutils portion

2005-11-26 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Eric Blake on 11/23/2005 2:04 PM: I normally run emacs with (add-hook 'before-save-hook 'whitespace-cleanup) That was the culprit. I guess I should file a bug with emacs that whitespace.el should not normalize spaces inside string

Re: bugs in dirname module - coreutils portion

2005-11-23 Thread Jim Meyering
Eric Blake [EMAIL PROTECTED] wrote: This is my patch to coreutils to match the dirname module updates thread on gnulib: http://lists.gnu.org/archive/html/bug-gnulib/2005-11/msg00071.html I've also fixed the two nits that Paul had with the latest version of my gnulib patch, mentioned in

Re: bugs in dirname module - coreutils portion

2005-11-23 Thread Paul Eggert
I took a very quick look and have one other comment: -components of the specified directories\n\ + components of the specified directories\n\ This isn't right: those should be leading spaces, without any tabs. Perhaps you put the source code through

Re: bugs in dirname module - coreutils portion

2005-11-23 Thread Eric Blake
Paul wrote: I took a very quick look and have one other comment: -components of the specified directories\n\ + components of the specified directories\n\ This isn't right: those should be leading spaces, without any tabs. Agreed, since it is