Re: coreutils-6.1: needs 'ls' patch (bug #15043)

2006-09-05 Thread mwoehlke
Eric Blake wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to mwoehlke on 8/31/2006 10:18 AM: Look more closely at the code. The reason linux was failing was because it was not doing enough work, because the d_type shortcut let it skip a stat where one was needed. Platforms

Re: coreutils-6.1: needs 'ls' patch (bug #15043)

2006-09-02 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to mwoehlke on 8/31/2006 10:18 AM: Look more closely at the code. The reason linux was failing was because it was not doing enough work, because the d_type shortcut let it skip a stat where one was needed. Platforms that did not have

Re: coreutils-6.1: needs 'ls' patch (bug #15043)

2006-08-31 Thread mwoehlke
Eric Blake wrote: According to mwoehlke on 8/28/2006 9:58 AM: I don't see why the behavior of 'ls' should depend on whether the Linux kernel is used. Shouldn't coreutils 'ls' behave the same way on FreeBSD or Solaris? The *old* behavior depends on the kernel. Although I can't vouch for

Re: coreutils-6.1: needs 'ls' patch (bug #15043)

2006-08-30 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to mwoehlke on 8/28/2006 9:58 AM: I don't see why the behavior of 'ls' should depend on whether the Linux kernel is used. Shouldn't coreutils 'ls' behave the same way on FreeBSD or Solaris? The *old* behavior depends on the kernel.

Re: coreutils-6.1: needs 'ls' patch (bug #15043)

2006-08-28 Thread mwoehlke
Mike Frysinger wrote: On Friday 25 August 2006 11:14, mwoehlke wrote: Ok, thanks. I a: wasn't sure of a macro that would be defined on Linux (is there a list of these things anywhere? echo | gcc -E -dD - -mike Thanks! Unfortunately it doesn't seem to work with all non-GNU compilers, but

Re: coreutils-6.1: needs 'ls' patch (bug #15043)

2006-08-28 Thread mwoehlke
Paul Eggert wrote: mwoehlke [EMAIL PROTECTED] writes: If #ifdef is OK, this should do it (works for me with 5.97 and 6.1): As I said, I don't really understand dircolors (but I'll go ahead and remark anyway :-). I don't see why the behavior of 'ls' should depend on whether the Linux kernel

Re: coreutils-6.1: needs 'ls' patch (bug #15043)

2006-08-26 Thread Jim Meyering
Jim Meyering [EMAIL PROTECTED] wrote: mwoehlke [EMAIL PROTECTED] wrote: Mike Frysinger wrote: On Thursday 24 August 2006 17:03, mwoehlke wrote: https://savannah.gnu.org/bugs/?func=detailitemitem_id=15043 Is this going to get fixed, or what? There is a trivial fix available, it just needs

Re: coreutils-6.1: needs 'ls' patch (bug #15043)

2006-08-26 Thread Jim Meyering
[EMAIL PROTECTED] (Bob Proulx) wrote: Jim Meyering wrote: I've checked this in on the trunk: * tests/ls/color-dtype-dir: New file. Test for the above fix. I am seeing this test failure. make[3]: Entering directory

Re: coreutils-6.1: needs 'ls' patch (bug #15043)

2006-08-26 Thread Jim Meyering
Jim Meyering [EMAIL PROTECTED] wrote: ... 2006-08-26 Jim Meyering [EMAIL PROTECTED] This test was failing in some environments. * tests/ls/color-dtype-dir: Don't rely on eval `dircolors -b` to set LS_COLORS in the environment. * tests/envvar-check: Instead, ensure

Re: coreutils-6.1: needs 'ls' patch (bug #15043)

2006-08-26 Thread Bob Proulx
Jim Meyering wrote: Thanks for the quick report! I wonder why I can't reproduce it here... I think you identified the problem as being associated with the LS_COLORS variable. I am running with 'env -i ...stuff...' and so LS_COLORS is not set in my build environment prior to building and

Re: coreutils-6.1: needs 'ls' patch (bug #15043)

2006-08-26 Thread Jim Meyering
[EMAIL PROTECTED] (Bob Proulx) wrote: Jim Meyering wrote: Thanks for the quick report! I wonder why I can't reproduce it here... I think you identified the problem as being associated with the LS_COLORS variable. I am running with 'env -i ...stuff...' and so Ah ha! With env -i, there

Re: coreutils-6.1: needs 'ls' patch (bug #15043)

2006-08-26 Thread Bob Proulx
Jim Meyering wrote: Bob Proulx wrote: I think you identified the problem as being associated with the LS_COLORS variable. I am running with 'env -i ...stuff...' and so Ah ha! With env -i, there would be no TERM setting, so dircolors -b would output this: LS_COLORS=''; export

Re: coreutils-6.1: needs 'ls' patch (bug #15043)

2006-08-25 Thread mwoehlke
Mike Frysinger wrote: On Thursday 24 August 2006 17:03, mwoehlke wrote: https://savannah.gnu.org/bugs/?func=detailitemitem_id=15043 Is this going to get fixed, or what? There is a trivial fix available, it just needs someone that knows how to make it 'Linux-only'. #if __linux__ foo #endif

Re: coreutils-6.1: needs 'ls' patch (bug #15043)

2006-08-25 Thread Jim Meyering
mwoehlke [EMAIL PROTECTED] wrote: Mike Frysinger wrote: On Thursday 24 August 2006 17:03, mwoehlke wrote: https://savannah.gnu.org/bugs/?func=detailitemitem_id=15043 Is this going to get fixed, or what? There is a trivial fix available, it just needs someone that knows how to make it

Re: coreutils-6.1: needs 'ls' patch (bug #15043)

2006-08-25 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Jim Meyering on 8/25/2006 11:18 AM: As usual, it requires an addition to the test suite. That is a little tricky, since the test will have to be skipped on a file system without d_type support. Why? The test is still valid on a

Re: coreutils-6.1: needs 'ls' patch (bug #15043)

2006-08-25 Thread Jim Meyering
Eric Blake [EMAIL PROTECTED] wrote: According to Jim Meyering on 8/25/2006 11:18 AM: As usual, it requires an addition to the test suite. That is a little tricky, since the test will have to be skipped on a file system without d_type support. Why? The test is still valid on a system without

Re: coreutils-6.1: needs 'ls' patch (bug #15043)

2006-08-25 Thread Mike Frysinger
On Friday 25 August 2006 11:14, mwoehlke wrote: Ok, thanks. I a: wasn't sure of a macro that would be defined on Linux (is there a list of these things anywhere? echo | gcc -E -dD - -mike pgpsAvif1veQB.pgp Description: PGP signature ___

coreutils-6.1: needs 'ls' patch (bug #15043)

2006-08-24 Thread mwoehlke
https://savannah.gnu.org/bugs/?func=detailitemitem_id=15043 Is this going to get fixed, or what? There is a trivial fix available, it just needs someone that knows how to make it 'Linux-only'. I've tested the fix against 5.97. -- Matthew We are Microsoft. You will be assimilated. Resistance

Re: coreutils-6.1: needs 'ls' patch (bug #15043)

2006-08-24 Thread Mike Frysinger
On Thursday 24 August 2006 17:03, mwoehlke wrote: https://savannah.gnu.org/bugs/?func=detailitemitem_id=15043 Is this going to get fixed, or what? There is a trivial fix available, it just needs someone that knows how to make it 'Linux-only'. #if __linux__ foo #endif -mike pgp9cw5GLHQjS.pgp

Re: coreutils-6.1: needs 'ls' patch (bug #15043)

2006-08-24 Thread Paul Eggert
mwoehlke [EMAIL PROTECTED] writes: https://savannah.gnu.org/bugs/?func=detailitemitem_id=15043 Is this going to get fixed, or what? I'm not the right guy to fix it, since I don't like to use 'ls' with colors and can't judge bug reports well in that area.