Re: testsuite portability nit

2005-04-20 Thread Paul Eggert
Jim Meyering [EMAIL PROTECTED] writes: I wouldn't have objected to the original patch, OK, then I installed the following, which I hope implements all the spirit of the original patch (though it differs in some unimportant details. there is precedent for using $BUILD_SRC_DIR. It shouldn't be

Re: testsuite portability nit

2005-04-19 Thread Jim Meyering
Paul Eggert [EMAIL PROTECTED] wrote: Eric Blake [EMAIL PROTECTED] writes: What was wrong with my proposed patch? I had some qualms with it, because it added coupling between the test cases and the rest of the code, by propagating BUILD_SRC_DIR and EXEEXT from the latter to the former.

Re: testsuite portability nit

2005-04-18 Thread Paul Eggert
I installed the following patch, in the hopes that it'd be relatively simple and easy to maintain. It skip the tests on the platforms with the contrary-to-POSIX glitches. 2005-04-17 Paul Eggert [EMAIL PROTECTED] Work around a couple of make check failures reported for Cygwin

Re: testsuite portability nit

2005-04-18 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Paul Eggert on 4/18/2005 12:39 AM: I installed the following patch, in the hopes that it'd be relatively simple and easy to maintain. It skip the tests on the platforms with the contrary-to-POSIX glitches. 2005-04-17 Paul Eggert

Re: testsuite portability nit

2005-04-18 Thread Paul Eggert
Eric Blake [EMAIL PROTECTED] writes: What was wrong with my proposed patch? I had some qualms with it, because it added coupling between the test cases and the rest of the code, by propagating BUILD_SRC_DIR and EXEEXT from the latter to the former. Coupling like that places extra constraints

testsuite portability nit

2005-04-17 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On cygwin, where /bin/sh is ash, trap '' CHLD doesn't work (ash only accepts signal numbers, not names): $ trap '' CHLD trap: bad signal CHLD But CHLD is not one of the portable signal numbers (it is 20 on cygwin, but other numbers on other

Re: testsuite portability nit

2005-04-17 Thread James Youngman
On Sat, Apr 16, 2005 at 04:35:39PM -0600, Eric Blake wrote: On cygwin, where /bin/sh is ash, trap '' CHLD doesn't work (ash only accepts signal numbers, not names): $ trap '' CHLD trap: bad signal CHLD But CHLD is not one of the portable signal numbers (it is 20 on cygwin, but other

Re: testsuite portability nit

2005-04-17 Thread Eric Blake
On cygwin, where /bin/sh is ash, trap '' CHLD doesn't work (ash only accepts signal numbers, not names): $ trap '' CHLD trap: bad signal CHLD But CHLD is not one of the portable signal numbers (it is 20 on cygwin, but other numbers on other platforms). Not all versions of