bug#41634: 'timeout' returning 124 and 133

2020-06-07 Thread Jonny Grant
On 07/06/2020 13:39, Bernhard Voelker wrote: On 2020-06-06 23:49, Jonny Grant wrote: Great patch. thanks, Padraig meanwhile further improved it. How about writing signal 9 by the name, ie $ kill -s KILL likewise $ kill -s TERM Where do you mean? Have a nice day, Berny Hi Berny

bug#41634: 'timeout' returning 124 and 133

2020-06-07 Thread Pádraig Brady
On 06/06/2020 00:37, Bernhard Voelker wrote: On 2020-06-01 10:01, Jonny Grant wrote: My mistake missing that. But could the 137 be listed explicitly? ie. "It may be necessary to use the KILL (9) signal, since this signal cannot be caught, in which case the exit status is 137 (128+9) rather

bug#41634: 'timeout' returning 124 and 133

2020-06-07 Thread Bernhard Voelker
On 2020-06-06 23:49, Jonny Grant wrote: > Great patch. thanks, Padraig meanwhile further improved it. > How about writing signal 9 by the name, ie $ kill -s KILL > likewise $ kill -s TERM Where do you mean? Have a nice day, Berny

bug#41634: 'timeout' returning 124 and 133

2020-06-07 Thread Bernhard Voelker
Hi Padraig, On 2020-06-07 14:13, Pádraig Brady wrote: > How about we add the exit code table to the man page also? > I've adjusted your patch to do that (along with some other tweaks) in the > attached. nice, especially also: > -124 if @var{command} times out > +124 if @var{command} times out,

bug#41634: 'timeout' returning 124 and 133

2020-06-07 Thread Pádraig Brady
On 07/06/2020 13:38, Bernhard Voelker wrote: Minor, grammar-related question: +Upon timeout send the TERM signal to COMMAND, if no other SIGNAL specified.\n\ ___^ s/timeout/&,/ ? I stumbled upon this sentence a couple of times - shouldn't there be a comma? The word 'timeout'

bug#41634: 'timeout' returning 124 and 133

2020-06-07 Thread Bernhard Voelker
On 2020-06-07 15:34, Pádraig Brady wrote: > [...] it is better to add the comma there [...] thanks, pushed with that change: https://git.savannah.gnu.org/cgit/coreutils.git/commit/?id=189776ff3b Marking this as done. Have a nice day, Berny