[PATCH] Replacement for the sigs_to_ignore hack in timeout.c

2008-10-06 Thread Giuseppe Scrivano
Hello, what do you think about the following way to remove the sigs_to_ignore hack in the timeout.c file? It ignores temporarily the signal inside the `send_sig' function instead of using the `sigs_to_ignore' array. Regards, Giuseppe Scrivano diff --git a/src/timeout.c b/src/timeout.c index

Re: [PATCH] Replacement for the sigs_to_ignore hack in timeout.c

2008-10-11 Thread Giuseppe Scrivano
and inform you if I will work on it. Regards, Giuseppe Scrivano ___ Bug-coreutils mailing list Bug-coreutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-coreutils

Re: [PATCH] Replacement for the sigs_to_ignore hack in timeout.c

2008-10-11 Thread Giuseppe Scrivano
Andreas Schwab [EMAIL PROTECTED] writes: + memset (sa, 0, sizeof sa); + sigemptyset (sa.sa_mask); I don't think you need the memset. and how reset the struct without a memset or using sa = {0,} as Pádraig suggested? Do you advise me to reset manually only members that really must be 0?

[bug #10384] chroot feature request: --user and --group parameters

2009-05-01 Thread Giuseppe Scrivano
Follow-up Comment #1, bug #10384 (project coreutils): In the attached patch I added the possibility to specify an user:group. `choot --userspec=user:group /foo/bar` The patch uses the gnulib userspec module. What do you think about it? (file #18071)

[bug #10384] chroot feature request: --user and --group parameters

2009-05-02 Thread Giuseppe Scrivano
Follow-up Comment #3, bug #10384 (project coreutils): what do you think about adding another argument --groups=g1,g2,...,gn? When it is specified supplementary groups are setted to the specified ones, if it is not specified then the original ones are kept.

[bug #10384] chroot feature request: --user and --group parameters

2009-05-02 Thread Giuseppe Scrivano
Follow-up Comment #5, bug #10384 (project coreutils): Here a new patch that adds the feature we discussed before. Now it is possible to specify a list of additional groups using -g/--groups. (file #18074) ___ Additional Item

Re: [PATCH] chroot specify user/group feature

2009-05-18 Thread Giuseppe Scrivano
Jim Meyering j...@meyering.net writes: In the future, please send patches by mail to the bug-coreutils list. Most of the people who will review them here prefer that. Sorry, I thought it was redundant to post both on the ML and on savannah. I'll send the next version to the bug-coreutils ML.

Re: [PATCH] chroot specify user/group feature

2009-05-20 Thread Giuseppe Scrivano
Pádraig Brady p...@draigbrady.com writes: +#ifndef MAXGID +# define MAXGID GID_T_MAX +#endif Why add the new MAXGID name? I took this code from the gnulib userspec.c file. I guess there are cases when MAXGID is defined and GID_T_MAX is not, and in such case it is better to use the real

Re: Human readable sort

2009-05-21 Thread Giuseppe Scrivano
Pádraig Brady p...@draigbrady.com writes: + Assume that numbers are properly abbreviated. + i.e. input will never have both 5000K and 6M. */ I think this is a too strong assumption. I wouldn't be surprised to find, for example, both 1M and 1500K in a data set. Are there problems to

Re: [PATCH] chroot specify user/group feature

2009-05-27 Thread Giuseppe Scrivano
Hi Eric, Eric Blake e...@byu.net writes: Would it be worth starting to patch the testsuite to replace 'setuidgid -g list usr cmd arg' with 'chroot --user usr --groups=list / cmd arg' in order to give this feature more exposure and reduce our dependence on uninstalled apps? IMHO, since

Re: [PATCH] chroot specify user/group feature

2009-05-28 Thread Giuseppe Scrivano
Hi Jim, Jim Meyering j...@meyering.net writes: setuidgid appears to be subsumed by chroot with the new options. If we can remove setuidgid.c, that code is no longer duplicated, so there's less (no?) motivation to move it into gnulib. If you want to remove setuidgid then I don't see any

Re: [PATCH] chroot specify user/group feature

2009-05-28 Thread Giuseppe Scrivano
Eric Blake e...@byu.net writes: The point is that setuidgid is not installed. It exists only for the purposes of the testsuite. If it were an installed app, then yes it would make sense to keep it around, although perhaps rewritten as a wrapper around the new chroot functionality.

Re: inotify back end for tail -f on linux

2009-05-30 Thread Giuseppe Scrivano
, Giuseppe From aa815abdd3cbf2ad15d769a1f4cb6100e3a975e5 Mon Sep 17 00:00:00 2001 From: Giuseppe Scrivano gscriv...@gnu.org Date: Sat, 30 May 2009 13:31:58 +0200 Subject: [PATCH] tail: Use inotify if it is available. * NEWS: Document the new feature * configure.ac: Check if inotify

Re: inotify back end for tail -f on linux

2009-05-30 Thread Giuseppe Scrivano
b5cad2d1e51781b18e53eac7b102922319909f5b Mon Sep 17 00:00:00 2001 From: Giuseppe Scrivano gscriv...@gnu.org Date: Sat, 30 May 2009 13:31:58 +0200 Subject: [PATCH] tail: Use inotify if it is available. * NEWS: Document the new feature * configure.ac: Check if inotify is present. * src/tail.c (main): Use the tail_forever

[PATCH] tail -- close fd on a fstat failure

2009-05-30 Thread Giuseppe Scrivano
Hi, I noticed that the fd is not closed properly if the fstat call fails. This trivial patch solves it. Giuseppe From 0f93ba2a0673a689bbeaf747b876f6f8c4bc6cae Mon Sep 17 00:00:00 2001 From: Giuseppe Scrivano gscriv...@gnu.org Date: Sat, 30 May 2009 21:41:26 +0200 Subject: [PATCH] tail: don't

Re: inotify back end for tail -f on linux

2009-06-02 Thread Giuseppe Scrivano
Mon Sep 17 00:00:00 2001 From: Giuseppe Scrivano gscriv...@gnu.org Date: Tue, 2 Jun 2009 08:28:23 +0200 Subject: [PATCH] tail: Use inotify if it is available. * NEWS: Document the new feature. * configure.ac: Check if inotify is present. * src/tail.c (tail_forever_inotify): New function. (main): Use

Re: inotify back end for tail -f on linux

2009-06-04 Thread Giuseppe Scrivano
) with additional tests for the --pid option. Regards, Giuseppe From f0824b8b79c1fb22e9a48cbf831a87433fc4d3e8 Mon Sep 17 00:00:00 2001 From: Giuseppe Scrivano gscriv...@gnu.org Date: Tue, 2 Jun 2009 08:28:23 +0200 Subject: [PATCH] tail: Use inotify if it is available. * NEWS: Document the new feature

Re: inotify back end for tail -f on linux

2009-06-06 Thread Giuseppe Scrivano
Hi Jim, Jim Meyering j...@meyering.net writes: Oh, and it'd be better to put that test in m4/jm-macros.m4, not in configure.ac. Ok, I'll move it. AC_CONFIG_FILES( Makefile doc/Makefile ... + if (len = evbuff_off) +{ + len = read (wd, evbuff, evlen);

Re: inotify back end for tail -f on linux

2009-06-06 Thread Giuseppe Scrivano
Jim Meyering j...@meyering.net writes: Actually, there may be a nice way to allow --pid=PID to integrate seamlessly with inotify support. I think you can add an IN_DELETE_SELF inotify watch on the /proc/PID directory. I suspect that every system with inotify support also has usable

Re: inotify back end for tail -f on linux

2009-06-06 Thread Giuseppe Scrivano
. Regards, Giuseppe From 529e1c2ba2a74168995de9ae7f8b9efa0d2d71c4 Mon Sep 17 00:00:00 2001 From: Giuseppe Scrivano gscriv...@gnu.org Date: Tue, 2 Jun 2009 08:28:23 +0200 Subject: [PATCH] tail: Use inotify if it is available. * NEWS: Document the new feature. * m4/jm-macros.m4: Check if inotify

Re: inotify back end for tail -f on linux

2009-06-07 Thread Giuseppe Scrivano
From: Giuseppe Scrivano gscriv...@gnu.org Date: Tue, 2 Jun 2009 08:28:23 +0200 Subject: [PATCH] tail: Use inotify if it is available. * NEWS: Document the new feature. * m4/jm-macros.m4: Check if inotify is present. * src/tail.c (tail_forever_inotify): New function. (main): Use the inotify-based

Re: inotify back end for tail -f on linux

2009-06-11 Thread Giuseppe Scrivano
28cc1f8e2582adb269babd5a6371fc5797f9ba52 Mon Sep 17 00:00:00 2001 From: Giuseppe Scrivano gscriv...@gnu.org Date: Tue, 2 Jun 2009 08:28:23 +0200 Subject: [PATCH] tail: Use inotify if it is available. * NEWS: Document the new feature. * m4/jm-macros.m4: Check if inotify is present. * src/tail.c (tail_forever_inotify): New function

Re: wc

2009-06-12 Thread Giuseppe Scrivano
Hello, if you need a specific wc output field, the words count in this case, you can use the command `wc -w FILE'. Is it what you want? Regards, Giuseppe Iram CHELLI iram.che...@loria.fr writes: Hello, i am using wc in shell scripts the exact command is: wc FILE | cut -d -f 2

Re: inotify back end for tail -f on linux

2009-06-14 Thread Giuseppe Scrivano
in that case. Oops, I was using a different events mask for re-added files. I added your test case to the tests suite now. Thanks, Giuseppe This is the new version: From 106b1d32a6956f902109bffdf87e7897210c0e04 Mon Sep 17 00:00:00 2001 From: Giuseppe Scrivano gscriv...@gnu.org Date: Tue, 2 Jun 2009

Re: Savannah report new bug link not obvious

2009-06-27 Thread Giuseppe Scrivano
Is https://savannah.gnu.org/bugs/?func=additemgroup=coreutils the page you are looking for? Giuseppe jida...@jidanni.org writes: Logged in to https://savannah.gnu.org/ the user cannot find the link to report a new bug. ___ Bug-coreutils mailing

Re: [PATCH] tail: add comments noting potential inotify-related problems

2009-07-02 Thread Giuseppe Scrivano
to be fixed before the upcoming release. From 8fbe1d2d1f666a0428f41d03831e18d4d1b56e89 Mon Sep 17 00:00:00 2001 From: Giuseppe Scrivano gscriv...@gnu.org Date: Thu, 2 Jul 2009 23:38:46 +0200 Subject: [PATCH 1/2] tail: avoid a problem for kernels prior to 2.6.21 * src/tail.c (tail_forever_inotify

Re: [PATCH] tail: add comments noting potential inotify-related problems

2009-07-03 Thread Giuseppe Scrivano
Hi Jim, Jim Meyering j...@meyering.net writes: I don't (yet?) see why a tree would be the preferred data structure. ... Because inotify doesn't add recursive watchers. For example, you want to follow by name `/var/foo/bar', and `/var/foo' doesn't exist yet. To catch the event for the `bar'

Re: [PATCH] tail: add comments noting potential inotify-related problems

2009-07-03 Thread Giuseppe Scrivano
Hi Jim, Jim Meyering j...@meyering.net writes: I'm not convinced that adding a lot of new code just to make tail -f handle a far-fetched case like that is worthwhile. But that's just my opinion, and if someone can present a use-case that makes it seem the additional code would be put to

Re: two new chroot bugs

2009-07-04 Thread Giuseppe Scrivano
; } -- 1.6.3.3 From e892d0d2155dab81ded428e0c0d04d91febe9b3c Mon Sep 17 00:00:00 2001 From: Giuseppe Scrivano gscriv...@gnu.org Date: Sat, 4 Jul 2009 10:25:03 +0200 Subject: [PATCH 2/2] tests: refactor code to use require_proc_pid_status_ * tests/tail-2/tail-n0f: Read the process status using

BTRFS file clone support for cp

2009-07-25 Thread Giuseppe Scrivano
0swaps $ env time ./cp foo baz 0.00user 0.00system 0:00.40elapsed 0%CPU (0avgtext+0avgdata 0maxresident)k 5744inputs+32outputs (1major+253minor)pagefaults 0swaps Cheers, Giuseppe From deea0ee0c2a521aae5a89d8613f937707d8f0e7b Mon Sep 17 00:00:00 2001 From: Giuseppe Scrivano gscriv...@gnu.org Date

Re: BTRFS file clone support for cp

2009-07-25 Thread Giuseppe Scrivano
Jim Meyering j...@meyering.net writes: Doesn't that constant, 1074041865, have a symbolic name? Maybe BTRFS_IOC_CLONE? Yes, it is exactly BTRFS_IOC_CLONE and it is defined in the fs/btrfs/ioctl.h file. Is there an easy and quick way to determine which file system is used by a file?

Re: BTRFS file clone support for cp

2009-07-25 Thread Giuseppe Scrivano
Hi Jim, Jim Meyering j...@meyering.net writes: However, but what about cp's --sparse option? btrfs supports sparse files, so this new code will have to honor that. The trouble is that there is currently no option to say preserve precisely and only whatever holes are present in src, which

Re: BTRFS file clone support for cp

2009-07-26 Thread Giuseppe Scrivano
From 747c96980acc25220cc436210403cdcaed6239c9 Mon Sep 17 00:00:00 2001 From: Giuseppe Scrivano gscriv...@gnu.org Date: Sat, 25 Jul 2009 16:35:27 +0200 Subject: [PATCH] cp: support the btrfs file system clone operation. * src/copy.c(copy_reg): Use the btrfs clone operation if it is possible

Re: tail -f: --pid *and* inotify

2009-07-26 Thread Giuseppe Scrivano
. Regards, Giuseppe From 862c9d934dc2ee188e9fe29985e463e2ec4d16ca Mon Sep 17 00:00:00 2001 From: Giuseppe Scrivano gscriv...@gnu.org Date: Sun, 26 Jul 2009 13:22:57 +0200 Subject: [PATCH] tail: use the inotify backend when a PID is specified. * src/tail.c (tail_forever_inotify): When a PID

Re: BTRFS file clone support for cp

2009-07-27 Thread Giuseppe Scrivano
Jim Meyering j...@meyering.net writes: Another possible issue with this I can think of is depending on the modification pattern of the COW files, the modification processes could fragment the file or more seriously be given ENOSPC errors. I hope btrfs takes care of this behind the scene.

Re: tail -f: --pid *and* inotify

2009-07-27 Thread Giuseppe Scrivano
times. What do you think? Regards, Giuseppe From 65f2737fa6e2519fbccbad7d285ca8923a893057 Mon Sep 17 00:00:00 2001 From: Giuseppe Scrivano gscriv...@gnu.org Date: Sun, 26 Jul 2009 13:22:57 +0200 Subject: [PATCH] tail: use the inotify backend when a PID is specified. * src/tail.c

Re: BTRFS file clone support for cp

2009-07-28 Thread Giuseppe Scrivano
Hi Pádraig, Pádraig Brady p...@draigbrady.com writes: How different exactly? OK I tried this myself on F11 with inconclusive results. I can't replicate it now, all tests I am doing report that blocks used before and after the clone are the same. Probably yesterday the difference I noticed

Re: BTRFS file clone support for cp

2009-07-30 Thread Giuseppe Scrivano
files instead of using dd. I am also considering the Jim's note doing the umount in the cleanup_ function. Cheers, Giuseppe From 7add4b337b7db0a63bca0dd0fe0f146f175163f8 Mon Sep 17 00:00:00 2001 From: Giuseppe Scrivano gscriv...@gnu.org Date: Wed, 29 Jul 2009 20:31:20 +0200 Subject: [PATCH] tests

Re: BTRFS file clone support for cp

2009-07-31 Thread Giuseppe Scrivano
Pádraig Brady p...@draigbrady.com writes: +#expensive_ That comment is just for testing I presume? Note you can run a single expensive test like: (cd tests make check TESTS=cp/file-clone VERBOSE=yes RUN_EXPENSIVE_TESTS=yes) sorry, yes I commented it out only for testing purpose. If you

Re: [RFC] fallocate utility

2009-07-31 Thread Giuseppe Scrivano
Hello, Pádraig Brady p...@draigbrady.com writes: Tilman Schmidt wrote: Pádraig Brady schrieb: I don't see a problem in extending the meaning of the truncate command. Now truncate isn't the best name for the command but that name already existed in BSD and so I thought it best to align with

Re: BTRFS file clone support for cp

2009-08-01 Thread Giuseppe Scrivano
Jim Meyering j...@meyering.net writes: I am now convinced that cp's new behavior belongs on a separate option, --reflink (i.e., it should not be the default). Giuseppe, do you feel like adding that option and adjusting your test accordingly? sure. Things to adjust, other than copy.c and

Re: BTRFS file clone support for cp

2009-08-01 Thread Giuseppe Scrivano
find a clear answer on the btrfs wiki to this question. Any comment? Thanks, Giuseppe From d110badaf7583acf957477bc7eda2e212b404343 Mon Sep 17 00:00:00 2001 From: Giuseppe Scrivano gscriv...@gnu.org Date: Sat, 1 Aug 2009 19:36:48 +0200 Subject: [PATCH 1/2] cp: accept the --reflink option

Re: BTRFS file clone support for cp

2009-08-03 Thread Giuseppe Scrivano
Mon Sep 17 00:00:00 2001 From: Giuseppe Scrivano gscriv...@gnu.org Date: Sat, 1 Aug 2009 19:36:48 +0200 Subject: [PATCH] cp: accept the --reflink option * NEWS: Mention it. * doc/coreutils.texi: Likewise. * src/copy.h (struct cp_options): New member reflink. * src/copy.c (usage): Likewise. (copy_reg

Re: BTRFS file clone support for cp

2009-08-04 Thread Giuseppe Scrivano
:) I included your notes in the following patch. Cheers, Giuseppe From 63c0a1840f236eebb9ba3a28d8f1e6242a7c5898 Mon Sep 17 00:00:00 2001 From: Giuseppe Scrivano gscriv...@gnu.org Date: Sat, 1 Aug 2009 19:36:48 +0200 Subject: [PATCH] cp: accept the --reflink option * NEWS: Mention it. * doc

Re: Linus' sha1 is much faster!

2009-08-16 Thread Giuseppe Scrivano
b975a5e0849eaa46e5cf410c5bf6e2308f044d61 Mon Sep 17 00:00:00 2001 From: Giuseppe Scrivano gscriv...@gnu.org Date: Sun, 16 Aug 2009 20:53:54 +0200 Subject: [PATCH] SHA1: use a lookup table for faster hashing * lib/sha1.c (struct sha1_pre): New member. * lib/sha1.c (sha1_process_block): Use the lookup table to quickly find indices to use

Re: Linus' sha1 is much faster!

2009-08-16 Thread Giuseppe Scrivano
Linus Torvalds torva...@linux-foundation.org writes: I pretty much can guarantee you that it improves things only because it makes gcc generate crap code, which then hides some of the P4 issues. I'd also suggest you try gcc-4.4, since that apparently fixes some of the oddest spill issues.

Re: Linus' sha1 is much faster!

2009-08-17 Thread Giuseppe Scrivano
Pádraig Brady p...@draigbrady.com writes: -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i586 -mtune=generic -fasynchronous-unwind-tables -D_GNU_SOURCE=1 thanks. I did again all tests on my machine using these same

Re: Linus' sha1 is much faster!

2009-08-17 Thread Giuseppe Scrivano
Hi, These are the results I reported (median of 5 plus an additional not considered first run) on the Steve Reid's SHA1 implementation using the same flags to the compiler that I used for previous tests. GCC 4.3.3: real0m2.627s GCC 4.4.1: real0m3.742s In both cases it showed

[PATCH]: nl: deprecate --page-increment in favour of --line-increment

2009-08-18 Thread Giuseppe Scrivano
Hello, --page-increment seems the wrong name for this option, --line-increment is clearer. what do you think of this change? Cheers, Giuseppe From e71bee2c6731fe65c07744ac95e1e4058eea773c Mon Sep 17 00:00:00 2001 From: Giuseppe Scrivano gscriv...@gnu.org Date: Tue, 18 Aug 2009 12:22:37 +0200

Re: [PATCH]: nl: deprecate --page-increment in favour of --line-increment

2009-08-18 Thread Giuseppe Scrivano
Thanks Kamil, yes, CHAR_MAX + 1 looks like a better choice. Are there other comments? Giuseppe Kamil Dudka kdu...@redhat.com writes: Hello Giuseppe, On Tue August 18 2009 12:47:06 Giuseppe Scrivano wrote: diff --git a/src/nl.c b/src/nl.c index 2deb314..ea7ebe6 100644 --- a/src/nl.c

Re: [PATCH]: nl: deprecate --page-increment in favour of --line-increment

2009-08-18 Thread Giuseppe Scrivano
From 8dc27341e8ed57e790a71d4b61df44e908bc73cd Mon Sep 17 00:00:00 2001 From: Giuseppe Scrivano gscriv...@gnu.org Date: Tue, 18 Aug 2009 12:22:37 +0200 Subject: [PATCH] nl: deprecate --page-increment in favour of --line-increment * NEWS: Mention the change. * doc/coreutils.texi: Document the --line

Re: Bug report

2009-09-02 Thread Giuseppe Scrivano
Hello, can you please tell us where is it documented to ask APT related questions to this mailing list? It is not the first time Ubuntu questions are directed here and in case this documentation should be fixed. Thanks, Giuseppe Gil Miller millgi...@yahoo.com writes: E: type 'sudo' is not

Re: Bug#545422: coreutils: tail -f - fails

2009-09-07 Thread Giuseppe Scrivano
Hi Jim, what do you think about the following solution? It avoids to revert to the old polling mechanism using /dev/stdin instead of - to inotify_add_watch. Cheers, Giuseppe diff --git a/src/tail.c b/src/tail.c index e3b9529..016b712 100644 --- a/src/tail.c +++ b/src/tail.c @@ -1152,6

Re: Bug#545422: coreutils: tail -f - fails

2009-09-07 Thread Giuseppe Scrivano
from inotify events, similar to what we are already doing when a --pid is specified. Regards, Giuseppe From f3010bebf9e25be9a83868b4ad9db2cc6cb6613f Mon Sep 17 00:00:00 2001 From: Giuseppe Scrivano gscriv...@gnu.org Date: Mon, 7 Sep 2009 16:35:16 +0200 Subject: [PATCH] tail: handle - properly

extend inotify to support file descriptors in addition to paths

2009-09-08 Thread Giuseppe Scrivano
, Giuseppe P.S. In the attached patch I changed the syscalls table only for x86. From 6f3340347fb5d26000bec3a0a9cd8ef59c710922 Mon Sep 17 00:00:00 2001 From: Giuseppe Scrivano gscriv...@gnu.org Date: Tue, 8 Sep 2009 23:40:03 +0200 Subject: [PATCH] Add new syscall \`inotify_add_watch_fd

Re: extend inotify to support file descriptors in addition to paths

2009-09-11 Thread Giuseppe Scrivano
Eric Paris epa...@parisplace.org writes: On Tue, Sep 8, 2009 at 8:21 PM, Giuseppe Scrivano gscriv...@gnu.org wrote: at the moment inotify permits to add new files to be watched using their path.  There are situations where the file path is not know but a descriptor is available.  It would

Re: Bug#545422: coreutils: tail -f - fails

2009-09-22 Thread Giuseppe Scrivano
Hi Jim, have you considered this patch for inclusion? I don't see a clearer way to avoid polling without inotify fd support. Regards, Giuseppe Giuseppe Scrivano gscriv...@gnu.org writes: This patch changes `tail' to handle stdin separately from inotify events, similar to what we

Re: Bug#545422: coreutils: tail -f - fails

2009-09-22 Thread Giuseppe Scrivano
Jim Meyering j...@meyering.net writes: Considering the amount of complexity it adds to already-dense code (in spite of the fact that some is just due to indentation changes), for so little gain (who will use tail -f on stdin and care whether tail is sleep-based or inotify-based?), I'm

Re: [PATCH] tail: fix a race condition

2009-10-13 Thread Giuseppe Scrivano
Hi Jim, Jim Meyering j...@meyering.net writes: I haven't reviewed this yet, but will do so today or tomorrow. I know triggering race conditions can be hard, but can you write a script that demonstrates the failure? This might be a good excuse to experiment with the now-usable-as-non-root

[PATCH] md5: accepts a new --threads option

2009-10-17 Thread Giuseppe Scrivano
: Giuseppe Scrivano gscriv...@gnu.org Date: Sun, 18 Oct 2009 00:19:25 +0200 Subject: [PATCH] md5: accepts a new --threads option * NEWS: Mention it. * bootstrap.conf: Use the `nproc' and `pthread' modules from gnulib. * doc/coreutils.texi: Document the new feature. * src/Makefile.am (md5sum, sha1sum

Re: [PATCH] md5: accepts a new --threads option

2009-10-17 Thread Giuseppe Scrivano
Hi Pádraig, How does it compare to: files_per_process=10 cpus=4 find files | xargs -n$files_per_process -P$cpus md5sum I would expect it to be a bit better as file_per_process could be very large, thus having less overhead in starting processes. Though is the benefit worth the extra

Re: [PATCH] md5: accepts a new --threads option

2009-10-18 Thread Giuseppe Scrivano
Jim Meyering j...@meyering.net writes: Hmm, I could see it being useful to specify NCPUs-1 also. I wonder is there a general external method to determine the number of CPUs. As far as I know, there is nothing portable. Want to add another program to coreutils? With what Bruno has just

Re: [PATCH] md5: accepts a new --threads option

2009-10-18 Thread Giuseppe Scrivano
Pádraig Brady p...@draigbrady.com writes: With -n4 only 1 process would be started. Could you repeat with -n1 please for comparison. One would only need to increase -n for large numbers of files. Sprry the mistake. In this case results are equal. $ time ./sha1sum --threads=2

Re: [PATCH] md5: accepts a new --threads option

2009-10-18 Thread Giuseppe Scrivano
Jim Meyering j...@meyering.net writes: What about a new switch to `arch'? Sorry, no. arch is not installed by default, for portability reasons. Does uname have the same problem? It already has a --processor option and IMHO it would be better to get similar information using the same tool.

Re: [PATCH] tail: fix a race condition

2009-10-20 Thread Giuseppe Scrivano
. Cheers, Giuseppe From e86c16342e856bec744ea01b8a2f8ab1b8695d63 Mon Sep 17 00:00:00 2001 From: Giuseppe Scrivano gscriv...@gnu.org Date: Tue, 20 Oct 2009 10:49:17 +0200 Subject: [PATCH] tests: add a new test that checks for a possible `tail' race. If new data is available between the initial read

Re: [PATCH] tail: fix a race condition

2009-10-20 Thread Giuseppe Scrivano
e5532992b1e7c018e5754c7082c2d9ac256cee3d Mon Sep 17 00:00:00 2001 From: Giuseppe Scrivano gscriv...@gnu.org Date: Tue, 20 Oct 2009 10:49:17 +0200 Subject: [PATCH] tests: add a new test that checks for a possible `tail' race. If new data is available between the initial read and tail registers the inotify watch descriptors

Re: [PATCH] tail: fix a race condition

2009-10-20 Thread Giuseppe Scrivano
Jim Meyering j...@meyering.net writes: Thanks again for your notes. I amended them into the patch. Cheers, Giuseppe From 3f0f5744899afc15e69554220be836f673b1dad3 Mon Sep 17 00:00:00 2001 From: Giuseppe Scrivano gscriv...@gnu.org Date: Tue, 20 Oct 2009 10:49:17 +0200 Subject: [PATCH] tests

Re: [PATCH] md5: accepts a new --threads option

2009-10-25 Thread Giuseppe Scrivano
Jim Meyering j...@meyering.net writes: As far as I know, there is nothing portable. Want to add another program to coreutils? With what Bruno has just added to gnulib's nproc module, we should have most platforms covered. If nobody is already working on it, I can start doing it. What about

[PATCH] core-count: A new program to count the number of cpu cores (was: [PATCH] md5: accepts a new --threads option)

2009-10-25 Thread Giuseppe Scrivano
e3bff6a4dd2fe9560c7922e877ab57081a083c58 Mon Sep 17 00:00:00 2001 From: Giuseppe Scrivano gscriv...@gnu.org Date: Sun, 25 Oct 2009 19:04:41 +0100 Subject: [PATCH] core-count: A new program to count the number of cpu cores * AUTHORS: Add my name. * NEWS: Mention it. * bootstrap.conf (gnulib_modules

Re: [PATCH] core-count: A new program to count the number of cpu cores

2009-10-25 Thread Giuseppe Scrivano
Bruno Haible br...@clisp.org writes: This program (and the underlying gnulib 'nproc' module) is IMO too simplistic. First of all, is the program meant to be a hardware inspection tool (like hwinfo --cpu)? Or is meant to be an auxiliary program for helping shell scripts that want to dispatch

Re: [PATCH] core-count: A new program to count the number of cpucores

2009-10-26 Thread Giuseppe Scrivano
Pádraig Brady p...@draigbrady.com writes: Hmm it's a bit surprising that min()/max() are not available as $((shell arithmetic)) or in `expr`. Consequently I agree that adding the option you suggest is useful. What will we call it though? I remember a recent discussion about adding min/max

Re: [PATCH] core-count: A new program to count the number of cpu cores

2009-10-27 Thread Giuseppe Scrivano
Hi Bruno, Bruno Haible br...@clisp.org writes: No, it should not be a hardware inspection tool but a portable tool to help shell scripts to have an idea of how many processes can be executed at the same time. If we get too much into details then we loose portability Good. This is

Re: [PATCH] core-count: A new program to count the number of cpu cores

2009-10-27 Thread Giuseppe Scrivano
Bruno Haible br...@clisp.org writes: Pádraig Brady wrote: Of course this should only apply if its effect is not externally observable; if I have a very small file B and a very large file A, and I can get $ md5sum --threads A B abcdabcdabcdabcdabcdabcdabcdabcd B

Re: [PATCH] core-count: A new program to count the number of cpu cores

2009-10-31 Thread Giuseppe Scrivano
--installed. Any comment? Cheers, Giuseppe From 4665e1801f73eeba98cad9988c5d5829bad03a37 Mon Sep 17 00:00:00 2001 From: Giuseppe Scrivano gscriv...@gnu.org Date: Sun, 25 Oct 2009 19:04:41 +0100 Subject: [PATCH] nproc: A new program to count the number of processors * AUTHORS: Add my name. * NEWS

Re: [PATCH] core-count: A new program to count the number of cpu cores

2009-10-31 Thread Giuseppe Scrivano
Hi Jim, thanks for your quick review. Jim Meyering j...@meyering.net writes: Giuseppe Scrivano wrote: I included what we have discussed into my patch. I renamed the new program to `nproc', now it accepts two options: --available and --installed. By default --available is used

Re: [PATCH] core-count: A new program to count the number of cpu cores

2009-10-31 Thread Giuseppe Scrivano
31b047ef9f0e83b7f6387bdd7e628cbb17f24079 Mon Sep 17 00:00:00 2001 From: Giuseppe Scrivano gscriv...@gnu.org Date: Sat, 31 Oct 2009 18:59:50 +0100 Subject: [PATCH] nproc: A new program to count the number of processors * AUTHORS: Add my name. * NEWS: Mention it. * README: Likewise. * bootstrap.conf

Re: [PATCH] core-count: A new program to count the number of cpu cores

2009-11-04 Thread Giuseppe Scrivano
the shorter forms $(nproc --c) and $(nproc --o). What do you think? Giuseppe From d07e645265b38c5648e47467a5ffd829bbe966f2 Mon Sep 17 00:00:00 2001 From: Giuseppe Scrivano gscriv...@gnu.org Date: Sat, 31 Oct 2009 18:59:50 +0100 Subject: [PATCH] nproc: A new program to count the number

Re: [PATCH] core-count: A new program to count the number of cpu cores

2009-11-05 Thread Giuseppe Scrivano
OK leave them as separate options. I'll hope to commit this soon. I amended this change and the bug in the texinfo documentation reported by Paolo. I hope it is fine now. Cheers, Giuseppe From 3e639852488e44c88c040d8b993dade4a3e81407 Mon Sep 17 00:00:00 2001 From: Giuseppe Scrivano gscriv

Re: [PATCH] core-count: A new program to count the number of cpu cores

2009-11-05 Thread Giuseppe Scrivano
Hello, Erik Auerswald auers...@unix-ag.uni-kl.de writes: Why have an option for the default operation at all? If --available is the same as specifying no option and the only other mode of operation is --all, only the --all option should be recognised. There is no need for --available. it is

Re: tail + inotify over nfs

2009-12-13 Thread Giuseppe Scrivano
Hello, Jim Meyering j...@meyering.net writes: Pádraig Brady wrote: I've just noticed that `tail -f` will not work over NFS as changes on the remote system will not go through the local VFS and so will not be noticed by inotify. So what to do? I suppose we could statfs(filename) Yes, I

Re: tail + inotify over nfs

2009-12-15 Thread Giuseppe Scrivano
Hello Pádraig, Pádraig Brady p...@draigbrady.com writes: It doesn't handle the above remount case though as if I mount the parent dir of a file or bind mount the file itself then there are no inotify notifications. This remounting issue is independent of nfs anyway. So can inotify handle

Re: tail aborts while following by name if using inotify

2009-12-29 Thread Giuseppe Scrivano
be applied after the three patches you have sent in another thread. Cheers, Giuseppe From e249f9ab639d318d709eed722b57bc232a7657c1 Mon Sep 17 00:00:00 2001 From: Giuseppe Scrivano gscriv...@gnu.org Date: Tue, 29 Dec 2009 14:59:24 +0100 Subject: [PATCH] tail: remove `fdspec' from the hash table

Re: tail aborts while following by name if using inotify

2009-12-29 Thread Giuseppe Scrivano
:-) This patch should fix the problem, other tests remain green. From f108dc01f86fb8df057172d2bafd8224759be884 Mon Sep 17 00:00:00 2001 From: Giuseppe Scrivano gscriv...@gnu.org Date: Wed, 30 Dec 2009 00:20:24 +0100 Subject: [PATCH] tail: ensure the wd is not already present in the hash table

Re: I: coreutils tests/misc/nproc-avail fails on GNU/Linux without /proc and /sys mounted

2010-01-09 Thread Giuseppe Scrivano
when --all fails for any reason, I think we should try with the number of available processing units, at least it is a more accurate value than return 1 (and document this behaviour). Bruno, Jim, what do you think? Cheers, Giuseppe Dmitry V. Levin l...@altlinux.org writes: Hi, The

Re: tee|tee|tee

2010-01-19 Thread Giuseppe Scrivano
jida...@jidanni.org writes: The tee(1) documents fail to say what happens when tee is given no arguments. Do say what is going on in $ echo o|tee|tee|tee The `tee' command copies standard input to standard output and also to any files given as arguments. it looks quite clear to me, if you

Re: Usage of !! , in Unix

2010-01-20 Thread Giuseppe Scrivano
it is a bash feature, you can find more information using `info bash'. Anyway, the proper place for bash related questions is the bug-b...@gnu.org mailing list. Cheers, Giuseppe Sameer Kumbhare smrkumbh...@gmail.com writes: Hi, I dont know whether to call this a bug, or a what. But.

Re: echo -n?

2010-02-14 Thread Giuseppe Scrivano
Hey Alfred, you can get it using: /bin/echo -e \\x2Dn Cheers, Giuseppe Alfred M. Szmidt a...@gnu.org writes: Here is a fun one, how does one output `-n' (literal string) (or any other option that echo accepts) using echo? $ /bin/echo --version|head -n1 echo (GNU coreutils) 8.4 $

Re: echo -n?

2010-02-15 Thread Giuseppe Scrivano
Alfred M. Szmidt a...@gnu.org writes: A friend came up with this hack `echo -n\ '; note the space. Which is a bit of a cheat. And `echo -e --\\bn', which alas is not POSIXly. POSIXly correct or not, '--\bn' is not the same as '-n'. Giuseppe

Re: coreutils patch to multithread md5sum for parallel hashing (ala the HP-UX days)

2010-03-25 Thread Giuseppe Scrivano
A similar patch was rejected some months ago: http://lists.gnu.org/archive/html/bug-coreutils/2009-10/msg00143.html As solution, Pádraig suggests to use find(1). You can take advantage of the new utility nproc(1), distributed with recent coreutils versions to get the number of processing

bug#5804: sort --human

2010-03-30 Thread Giuseppe Scrivano
sort supports --human-numeric-sort since coreutils 7.5. Cheers, Giuseppe Phil Dumont p...@solidstatescientific.com writes: It sure would be nice if the sort command had a --human option: du -s --human * | sort --human phil

bug#19681: [PATCH] sync: use syncfs(2) if any argument is specified

2015-01-27 Thread Giuseppe Scrivano
Pádraig Brady p...@draigbrady.com writes: thanks! Pádraig. Thanks for the review, I've amended the changes you suggested: From b2babc9838b52892e2cdc46bc4590fa852daa0eb Mon Sep 17 00:00:00 2001 From: Giuseppe Scrivano gscri...@redhat.com Date: Sun, 25 Jan 2015 01:33:45 +0100 Subject: [PATCH

bug#19681: [PATCH] sync: use syncfs(2) if any argument is specified

2015-01-24 Thread Giuseppe Scrivano
* configure.ac: Check if syncfs(2) is available. * NEWS: Mention the new feature. * doc/coreutils.texi (sync invocation): Document the new feature. * src/sync.c (usage): Describe that arguments are now accepted. (main): Use syncfs(2) to flush buffers for the file system which contain the specified

bug#19681: [PATCH] sync: use syncfs(2) if any argument is specified

2015-01-25 Thread Giuseppe Scrivano
* configure.ac: Check if syncfs(2) is available. * NEWS: Mention the new feature. * doc/coreutils.texi (sync invocation): Document the new feature. * src/sync.c (usage): Describe that arguments are now accepted. (main): Use syncfs(2) to flush buffers for the file system which contain the specified

bug#19681: [PATCH] sync: use syncfs(2) if any argument is specified

2015-01-25 Thread Giuseppe Scrivano
Paul Eggert egg...@cs.ucla.edu writes: If we're adding this sort of option, shouldn't we also give users the ability to invoke fsync and fdatasync on a single file, as opposed to syncfs on an entire file system? Good point. Should we instead add something like --file-system and --data-only,

bug#19681: [PATCH] sync: use syncfs(2) if any argument is specified

2015-01-26 Thread Giuseppe Scrivano
Pádraig Brady p...@draigbrady.com writes: On 25/01/15 18:05, Bernhard Voelker wrote: On 01/25/2015 06:41 PM, Pádraig Brady wrote: So we have: fdatasync fsync syncfs sync referring to:: file data, file data + metadata, file system, all file systems [...] I'd be incline to go with

bug#19681: [PATCH] sync: use syncfs(2) if any argument is specified

2015-01-26 Thread Giuseppe Scrivano
Pádraig Brady p...@draigbrady.com writes: On 26/01/15 08:36, Giuseppe Scrivano wrote: Pádraig Brady p...@draigbrady.com writes: On 25/01/15 18:05, Bernhard Voelker wrote: On 01/25/2015 06:41 PM, Pádraig Brady wrote: So we have: fdatasync fsync syncfs sync referring to:: file data, file

bug#20029: 'yes' surprisingly slow

2015-03-09 Thread Giuseppe Scrivano
Pádraig Brady p...@draigbrady.com writes: The attached should make things more efficient here. thanks, Pádraig. From 7959bbf19307705e98f08cfa32a9dcf67672590c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?P=C3=A1draig=20Brady?= p...@draigbrady.com Date: Mon, 9 Mar 2015 19:27:32 + Subject:

bug#34672: [RFC] id --numeric

2019-02-28 Thread Giuseppe Scrivano
Hi Bernhard, Bernhard Voelker writes: > Thanks for the patch. > > What is the use case? I mean, if one wants only the numeric numbers, > then this is usually in a script for automatic processing, and then > I thinks it's clearer to have uid and group/groups separated: > > $ id -u > 1000 >

bug#34672: [RFC] id --numeric

2019-02-26 Thread Giuseppe Scrivano
Hi, there are cases where I'd like to see only the numeric values in the `id` output. I could get this information separately, but having a new option and just one command simplifies the task. Are you fine with a change like the following? If you have nothing against it, I will clean it up and