Re: [PATCH]: ls: do not show long iso time format for en_* locales

2009-09-29 Thread Paul Eggert
Jim Meyering j...@meyering.net writes: However, I'm a little reluctant to change back. Let's wait a day or two, in case Paul Eggert has an objection. Here are some objections to the change, under the assumption that we're in a poorly-configured environment (as the behavior is unaffected in

Re: [PATCH]: ls: do not show long iso time format for en_* locales

2009-09-28 Thread Pádraig Brady
Pádraig Brady wrote: Jim Meyering wrote: The only advantage is that my patch uses the existing framework, rather than adding special case code in ls.c proper. Whether that is worth the apparent complexity... If you prefer his patch and want to adjust it and handle the rest, I have no

Re: [PATCH]: ls: do not show long iso time format for en_* locales

2009-09-28 Thread Pádraig Brady
Pádraig Brady wrote: Pádraig Brady wrote: Jim Meyering wrote: The only advantage is that my patch uses the existing framework, rather than adding special case code in ls.c proper. Whether that is worth the apparent complexity... If you prefer his patch and want to adjust it and handle the

Re: [PATCH]: ls: do not show long iso time format for en_* locales

2009-09-28 Thread Jim Meyering
Pádraig Brady wrote: The full patch is attached. ... That looks fine. Thanks. However, I'm a little reluctant to change back. Let's wait a day or two, in case Paul Eggert has an objection. Would you please add a test to exercise this, perhaps based on the one from Ondřej? From

Re: [PATCH]: ls: do not show long iso time format for en_* locales

2009-09-27 Thread Pádraig Brady
Jim Meyering wrote: Pádraig Brady wrote: Paul Eggert wrote: Ondřej Vašík ova...@redhat.com writes: as reported in https://bugzilla.redhat.com/show_bug.cgi?id=525134 by Daniel Qarras, ls -l shows iso long format for en_* locales. I just now read that Bugzilla report, and the diagnosis and

Re: [PATCH]: ls: do not show long iso time format for en_* locales

2009-09-27 Thread Jim Meyering
Pádraig Brady wrote: ... So that will apply generate an en.po with the traditional unix format to apply to en_* for e.g. Right. $ locale -a | sed -n 's/\(en_..\).*/\1/p' | sort -u | while read LANG; do echo $LANG $(locale territory); done en_AG Antigua and Barbuda en_AU Australia en_BW

Re: [PATCH]: ls: do not show long iso time format for en_* locales

2009-09-27 Thread Pádraig Brady
Jim Meyering wrote: The only advantage is that my patch uses the existing framework, rather than adding special case code in ls.c proper. Whether that is worth the apparent complexity... If you prefer his patch and want to adjust it and handle the rest, I have no objection. Yes it's

Re: [PATCH]: ls: do not show long iso time format for en_* locales

2009-09-26 Thread Jim Meyering
Pádraig Brady wrote: Paul Eggert wrote: Ondřej Vašík ova...@redhat.com writes: as reported in https://bugzilla.redhat.com/show_bug.cgi?id=525134 by Daniel Qarras, ls -l shows iso long format for en_* locales. I just now read that Bugzilla report, and the diagnosis and the patch do not

Re: [PATCH]: ls: do not show long iso time format for en_* locales

2009-09-26 Thread Ondřej Vašík
Paul Eggert wrote: Ondřej Vašík ova...@redhat.com writes: as reported in https://bugzilla.redhat.com/show_bug.cgi?id=525134 by Daniel Qarras, ls -l shows iso long format for en_* locales. I just now read that Bugzilla report, and the diagnosis and the patch do not seem correct. The

Re: [PATCH]: ls: do not show long iso time format for en_* locales

2009-09-26 Thread Ondřej Vašík
Jim Meyering wrote: Here's an incomplete patch. It needs a test and a NEWS entry. Ondřej, can you adjust your test to work (or skip) if there is no en* locale? Maybe something like that (attachment)? It's checking for existence of locale binary and en_US locale and performing the test only if

Re: [PATCH]: ls: do not show long iso time format for en_* locales

2009-09-25 Thread Paul Eggert
Ondřej Vašík ova...@redhat.com writes: as reported in https://bugzilla.redhat.com/show_bug.cgi?id=525134 by Daniel Qarras, ls -l shows iso long format for en_* locales. I just now read that Bugzilla report, and the diagnosis and the patch do not seem correct. The diagnosis says: In ls.c

Re: [PATCH]: ls: do not show long iso time format for en_* locales

2009-09-25 Thread Pádraig Brady
Paul Eggert wrote: Ondřej Vašík ova...@redhat.com writes: as reported in https://bugzilla.redhat.com/show_bug.cgi?id=525134 by Daniel Qarras, ls -l shows iso long format for en_* locales. I just now read that Bugzilla report, and the diagnosis and the patch do not seem correct. The