Re: more 5.3.0 issues on cygwin

[Jim Meyering]

Eric Blake [EMAIL PROTECTED] wrote:
...
 However, the Makefile.am patches are still important to allow the
 tests/help-version script to succeed without filling the disk (otherwise,
 you eval `args=$yes.exe_args', then run `yes.exe .exe_args' which runs
 away, rather than the intended `yes --version').  Likewise, the system.h
 patch is necessary for df (NTFS uses 1k blocks as captured in S_BLKSIZE,
 but without the patch, ST_NBLOCKSIZE defaults to 512, so sizes were 50% of
 their correct value).

Thanks.  I've applied those.

 2005-01-17  Eric Blake  [EMAIL PROTECTED]  (tiny change)

   * src/Makefile.am (all_programs.list): Strip $(EXEEXT) and remove
   duplicates.
   * man/Makefile.am (all_programs): Revert previous patch; updated
   all_programs.list fixes this.
   (.x.1): No need to add $(EXEEXT).

 2005-01-03  Corinna Vinschen  [EMAIL PROTECTED]  (tiny change)

 * src/system.h: Use S_BLKSIZE value for ST_NBLOCKSIZE where
   available.


___
Bug-coreutils mailing list
Bug-coreutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-coreutils

Re: more 5.3.0 issues on cygwin

[Jim Meyering]

Eric Blake [EMAIL PROTECTED] wrote:
...
 * src/od.c (OPENMODE): New macro.
 (open_next_file): Use OPENMODE in fopen call.
...
 Index: src/od.c
 ===
 RCS file: /cvsroot/coreutils/coreutils/src/od.c,v
 retrieving revision 1.152
 diff -u -p -r1.152 od.c
 --- src/od.c  28 Sep 2004 01:09:03 -  1.152
 +++ src/od.c  17 Jan 2005 13:09:07 -
 @@ -70,6 +70,12 @@ typedef unsigned long long int ulonglong
  typedef unsigned long int ulonglong_t;
  #endif

 +#ifdef O_BINARY
 +# define OPENMODE rb
 +#else
 +# define OPENMODE r
 +#endif
 +
  enum size_spec
{
  NO_SIZE,
 @@ -906,7 +912,7 @@ open_next_file (void)
   }
else
   {
 -   in_stream = fopen (input_filename, r);
 +   in_stream = fopen (input_filename, OPENMODE);
 if (in_stream == NULL)
   {
 error (0, errno, %s, input_filename);

Why is that needed?
od.c already does this:

  SET_BINARY (fileno (in_stream));

where that macro is defined in system.h:

#if O_BINARY
# ifndef __DJGPP__
#  define setmode _setmode
#  define fileno(_fp) _fileno (_fp)
# endif /* not DJGPP */
# define SET_MODE(_f, _m) setmode (_f, _m)
# define SET_BINARY(_f) do {if (!isatty(_f)) setmode (_f, O_BINARY);} while (0)

Maybe those #if directives don't work on your system?


___
Bug-coreutils mailing list
Bug-coreutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-coreutils