Re: history and val-tags locks.

2005-05-17 Thread Mark D. Baushke
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Derek Price <[EMAIL PROTECTED]> writes: > Derek Price wrote: > > >Derek Price wrote: > > > >>I see your point. What about `cvs server'? I > >>can see both setups being useful... an admin > >>who allowed users access to the CVS repository > >>would pr

Re: Feature Branch Windows Build Broken - New GNULIB glob module

2005-05-17 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Conrad T. Pino wrote: >I saw you're involved with Paul Eggert on a "New GNULIB module" topic >and assumed we had done another GNULib import which has often broken >the Windows build. Well, basically. I created the glob module myself and added it to

Re: [bug-gnulib] New GNULIB glob module?

2005-05-17 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Paul Eggert wrote: >First, already we have something bogus: that __BEGIN_DECLS. It must >be protected by "#ifdef _LIBC", since random C environments don't have >it. Similarly for __END_DECLS. Done. >The simplest fix would be to do something like th

Re: history and val-tags locks.

2005-05-17 Thread Derek Price
Derek Price wrote: >Derek Price wrote: > > > >>I see your point. What about `cvs server'? I can see both setups being >>useful... an admin who allowed users access to the CVS repository would >>probably prefer not to allow the config file to be specified whereas an >>admin who restriced the c

Re: history and val-tags locks.

2005-05-17 Thread Derek Price
Patch actually attached this time. Cheers, Derek Derek Price wrote: >I've implemented this as an option to server & pserver. Installing as a >global option would have create problems in multiroot mode anyhow. > >Preliminary patch against 1.11.x attached. The final version will go >into featu

RE: Feature Branch Windows Build Broken - New GNULIB glob module

2005-05-17 Thread Conrad T. Pino
Hi Derek, > From: Derek Price [mailto:[EMAIL PROTECTED] > > Well, basically. I created the glob module myself and added it to CVS > and Paul has been reviewing it and I've been correcting it in ways to > make it compatible with GNULIB & GLIBC. Cool. Another budding published author in our midst

RE: Feature Branch Windows Build Broken - New GNULIB glob module

2005-05-17 Thread Conrad T. Pino
Hi Derek, > From: Derek Price [mailto:[EMAIL PROTECTED] > > I'm going to suggest something a little more general to the GNULIB > maintainers: > > #ifndef __BEGIN_DECLS > # define __BEGIN_DECLS > #endif > #ifndef __END_DECLS > # define __END_DECLS > #endif > #ifndef __const > # define __const con

Re: [bug-gnulib] New GNULIB glob module?

2005-05-17 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Paul Eggert wrote: >Derek Price <[EMAIL PROTECTED]> writes: > >>Are you sure? You asked me to restore similar parens around bit-ands >>back at several other locations despite other work that changed the >>lines, in an earlier email. Not that I disagre

Re: [bug-gnulib] New GNULIB glob module?

2005-05-17 Thread Derek Price
Paul Eggert wrote: >Now for commentary on glob.h. > >Derek Price <[EMAIL PROTECTED]> writes: > > > >>--- ../glibc-2.3.5/posix/glob.h 2004-09-16 20:55:15.0 -0400 >>+++ lib/glob_.h 2005-05-13 12:21:39.0 -0400 >>@@ -19,29 +19,48 @@ >> #ifndef _GLOB_H >> #define

Feature Branch Windows Build Broken - New GNULIB glob module

2005-05-17 Thread Conrad T. Pino
The following patch lets me get this far in the Windows IDE build: Configuration: libcvs - Win32 Debug Compiling... glob.c H:\Conrad\Projects\cvs-1.12\lib\glob.c(253) : warning C4028: formal parameter 1 different from declaration H:\Conrad\Projects\cvs-1.12\

Re: [bug-gnulib] New GNULIB glob module?

2005-05-17 Thread Paul Eggert
Derek Price <[EMAIL PROTECTED]> writes: >>This seems a bit brittle. Why not simply try to compile this program? >> >> #include >> char a[_GNU_GLOB_INTERFACE_VERSION == 1 ? 1 : -1]; > > Because I like to avoid runtime tests if I can avoid it, since they > cannot be used when cross-compiling. T

RE: Feature Branch Windows Build Broken - New GNULIB glob module

2005-05-17 Thread Conrad T. Pino
The previous patch to "lib/libcvs.dsp" doesn't contain fix for the "Win32 Release" configuration so please don't commit this patch. I have a corrected patch which I plan to commit if that's what is indicated and will supply it if requested but haven't done so because it adds nothing to the debuggi

Re: [bug-gnulib] New GNULIB glob module?

2005-05-17 Thread Derek Price
Paul Eggert wrote: >Derek Price <[EMAIL PROTECTED]> writes: > > > >> /* Enable GNU extensions in glob.h. */ >>-#ifndef _GNU_SOURCE >>+#if defined _LIBC && !defined _GNU_SOURCE >> # define _GNU_SOURCE 1 >> #endif >> >> > >I just checked the glibc source file include/libc-symbols.h, and it >d

Re: Feature Branch Windows Build Broken - New GNULIB glob module

2005-05-17 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Conrad T. Pino wrote: >The following patch lets me get this far in the Windows IDE build: >Configuration: libcvs - Win32 Debug >Compiling... >glob.c >H:\Conrad\Projects\cvs-1.12\lib\glob.c(253) : warning C4028:

Re: [bug-gnulib] New GNULIB glob module?

2005-05-17 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Thanks for the latest round. I'm going to be out of the office today, but I should get to it by tomorrow. Regards, Derek -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.0 (Cygwin) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

CVS Stable - checkout alias module exclusion failure with -d option

2005-05-17 Thread Conrad T. Pino
Hi All, I'm seeking a quick answer from whatever you might know at the moment. If in depth research is needed I plan to follow through with it. Using a version 1.11.20 client with a 1.11.17 server I see an alias module directory exclusion fail when check out is used with -d option. The CVSROOT=

Re: [bug-gnulib] New GNULIB glob module?

2005-05-17 Thread Paul Eggert
Derek Price <[EMAIL PROTECTED]> writes: >>Why do we need to include here? All we need is size_t, >>right? And stddef.h gives us that. > > If I don't, I get the following error: > > In file included from glob.c:23: > glob.h:107: error: syntax error before "struct" > In file included from /usr/in