Re: Feature Branch Solaris Build Broken - lib/glob.c errors

2005-05-21 Thread Derek Price 
Conrad T. Pino wrote:

>1. #include  within glob_.h file.
>  
>

This would be the way to go.  You may commit this if you wish.

>2. Move #include  below #include  in glob.c file.
>  
>

This is incorrect.  The GNULIB convention is to include a module's
header immediately following the include of  in its associated
source file (i.e. glob.c first including config.h then immediately
including glob.h) to test the module's interface.

Regards,

Derek



___
Bug-cvs mailing list
Bug-cvs@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-cvs

Re: Feature Branch Solaris Build Broken - lib/glob.c errors

2005-05-21 Thread Derek Price 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Conrad T. Pino wrote:

>Excuse me for perhaps being slow but why is configure choosing to
>use "lib/glob.h" when the platform has "/usr/include/glob.h" whose
>contents follow?


Partly because the GNU glob semantics are more extensive than the POSIX
spec, partly because Mark Baushke reported that even glob functions that
are supposed to meet the POSIX spec often don't, the new glob module
only uses a system glob when it appears to be GNU glob.  I can't tell
for sure without reviewing your configure.log, but the specific reason
configure noticed that your glob.h doesn't work is probably the lack of
a  defining the _GNU_GLOB_INTERFACE_VERSION macro.

Cheers,

Derek
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.0 (Cygwin)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFCj7VRLD1OTBfyMaQRAjPjAKDIQrjsR+KcEDO+I1s5VvDLoq1uKgCg6zB2
TbTb97b7MY0vBc5ksWkTY6U=
=FvX6
-END PGP SIGNATURE-




___
Bug-cvs mailing list
Bug-cvs@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-cvs