Re: OpenBSD 3.6 sparc64 Build Failure on TRUNK

2005-06-15 Thread Derek Price
Alexander Taler wrote:

> case "$1" in
> --run)
>   # Try to run requested program, and just exit if it succeeds.
>   run=
>   shift
>   "$@" && exit 0
>
> Where do you suppose that check should be?


Actually, `missing' only `exit 0's when the program exited with a
success code.  Otherwise it will fall through and perform various
actions depending on the argument to --run.

One of the things it does is verify that the requested executable exists
and that it is a GNU application.  This is what caught us - the script
was assuming that any GNU program is good and therefore that its failure
meant a real failure.  I added a new bison wrapper based on missing to
handle the version check.  Let me know if it doesn't work for you.

This problem should go away when we start using Automake 1.10 since it
won't allow Yacc targets to be built without the
--enable-maintainer-mode argument to configure.

Regards,

Derek



___
Bug-cvs mailing list
Bug-cvs@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-cvs


Re: OpenBSD 3.6 sparc64 Build Failure on TRUNK

2005-06-15 Thread Alexander Taler
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Wed, 15 Jun 2005 12:37:29 EDT
Wed, 15 Jun 2005 12:37:18 EDT

  >> Alexander Taler wrote:

  >> $ make
  >> make all-recursive
  >> Making all in lib
  >> cp ./alloca_.h alloca.h-t
  >> mv alloca.h-t alloca.h
  >> /bin/sh ../build-aux/ylwrap getdate.y y.tab.c getdate.c y.tab.h \
  >> getdate.h y.output getdate.output \
  >>   -- /bin/sh \
  >> /home/dissent/prj/libcvs/var/ccvs-1.12/build-aux/missing --run bison -y
  >> /home/dissent/prj/libcvs/var/ccvs-1.12/build-aux/missing --run bison -y
  >> /home/dissent/prj/libcvs/var/ccvs-1.12/lib/getdate.y:202:
  >> unrecognized: %parse-param
  >> /home/dissent/prj/libcvs/var/ccvs-1.12/lib/getdate.y:202: Skipping to next
  >> % /home/dissent/prj/libcvs/var/ccvs-1.12/lib/getdate.y:203:
  >> unrecognized: %lex-param
  >> /home/dissent/prj/libcvs/var/ccvs-1.12/lib/getdate.y:203: Skipping to next
  >> %
  >> *** Error code 1


  Derek> There are a few issues here:

  Derek> 1. getdate.y from GNULIB requires at least Bison 1.875.

My version 1.35 is the default for OpenBSD.  I'll try and avoid
upgrading.

  Derek> 2. getdate.y shouldn't be recompiled unless it has changed, but
  Derek>   sometimes the timestamps can get munged when checking out of
  Derek>   CVS.

It seems it hasn't changed: 

$ ls -l lib/getdate.*
- -rw---  1 dissent  dissent  79572 Jun 14 07:57 lib/getdate.c
- -rw---  1 dissent  dissent995 Jun 14 07:57 lib/getdate.h
- -rw---  1 dissent  dissent  38432 Jun 14 07:57 lib/getdate.y


  Derek> 3. When either of the above two problems are not avoided, the
  Derek>   build-aux/missing script is supposed to just update the
  Derek>   timestamps, print a warning message, and exit with a success
  Derek>   code.  This may not happen if your lib/getdate.c file is
  Derek>   actually missing, for instance if you ran a `make
  Derek>   maintainerclean'.

It's not missing as above.  I ran `make realclean', but I
followed it with a `cvs up -d'.

  Derek> If your `missing' script is failing for any reason other than a bad
  Derek> bison AND a missing lib/getdate.c, then I would like to get to the
  Derek> bottom of it.

Well it seems that it's failing for another reason.  I took a
look through missing (and ylwrap) and couldn't find anything that
looked like the date check that you mentioned.  In fact, it seems
missing is being called with --run, which trys to run the command
with no checks at all:

case "$1" in
--run)
  # Try to run requested program, and just exit if it succeeds.
  run=
  shift
  "$@" && exit 0

Where do you suppose that check should be?

  Derek> Otherwise, your solution should be to update to a more
  Derek> recent Bison (which we assume for anyone willing to run `make
  Derek> maintainerclean'), or pull the current lib/getdate.c from CVS and
  Derek> avoid the rebuild.

I'll try and avoid an upgrade, and I'll be sure not to `make
maintainerclean'.

  Derek> I have documented the Bison 1.875 requirement in HACKING.

Cool.

Alex

- -- 
https://savannah.gnu.org/projects/libcvs-specAccess CVS through a library.
PGP:  ID: 0x23DC453B  FPR: 42D0 66C2 9FF8 553A 373A  B819 4C34 93BA 23DC 453B
convince your customer that pserver access to a CVS server is, if not
*actually* the work of the devil, then pretty similar -- Derek Price
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.2.2 (OpenBSD)
Comment: Processed by Mailcrypt 3.5.8 

iD8DBQFCsFlRTDSTuiPcRTsRAsZrAJ9vw8D7zXciufAtEolC4lV84a6OnQCgiZL1
apiywyQ/JvgCM8Z65RoW8I4=
=hoIz
-END PGP SIGNATURE-


___
Bug-cvs mailing list
Bug-cvs@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-cvs


Re: OpenBSD 3.6 sparc64 Build Failure on TRUNK

2005-06-15 Thread Derek Price
Alexander Taler wrote:

> $ make
> make  all-recursive
> Making all in lib
> cp ./alloca_.h alloca.h-t
> mv alloca.h-t alloca.h
> /bin/sh ../build-aux/ylwrap getdate.y y.tab.c getdate.c y.tab.h
> getdate.h y.output getdate.output -- /bin/sh
> /home/dissent/prj/libcvs/var/ccvs-1.12/build-aux/missing --run bison -y
> /home/dissent/prj/libcvs/var/ccvs-1.12/lib/getdate.y:202:
> unrecognized: %parse-param
> /home/dissent/prj/libcvs/var/ccvs-1.12/lib/getdate.y:202:Skipping
> to next %
> /home/dissent/prj/libcvs/var/ccvs-1.12/lib/getdate.y:203:
> unrecognized: %lex-param
> /home/dissent/prj/libcvs/var/ccvs-1.12/lib/getdate.y:203:Skipping
> to next %
> *** Error code 1


There are a few issues here:

   1. getdate.y from GNULIB requires at least Bison 1.875.
   2. getdate.y shouldn't be recompiled unless it has changed, but
  sometimes the timestamps can get munged when checking out of CVS.
   3. When either of the above two problems are not avoided, the
  build-aux/missing script is supposed to just update the
  timestamps, print a warning message, and exit with a success
  code.  This may not happen if your lib/getdate.c file is actually
  missing, for instance if you ran a `make maintainerclean'.


If your `missing' script is failing for any reason other than a bad
bison AND a missing lib/getdate.c, then I would like to get to the
bottom of it.  Otherwise, your solution should be to update to a more
recent Bison (which we assume for anyone willing to run `make
maintainerclean'), or pull the current lib/getdate.c from CVS and avoid
the rebuild.

I have documented the Bison 1.875 requirement in HACKING.

Regards,

Derek



___
Bug-cvs mailing list
Bug-cvs@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-cvs


OpenBSD 3.6 sparc64 Build Failure on TRUNK

2005-06-15 Thread Alexander Taler
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Tue, 14 Jun 2005 09:32:06 EDT

Hi, I'm having a build failure for the feature version of CVS on
OpenBSD 3.6 sparc64.  It appears to be a problem with bison, and
I'm not really sure what the next steps are.

Alex

$ make
make  all-recursive
Making all in lib
cp ./alloca_.h alloca.h-t
mv alloca.h-t alloca.h
/bin/sh ../build-aux/ylwrap getdate.y y.tab.c getdate.c y.tab.h getdate.h 
y.output getdate.output -- /bin/sh 
/home/dissent/prj/libcvs/var/ccvs-1.12/build-aux/missing --run bison -y  
/home/dissent/prj/libcvs/var/ccvs-1.12/lib/getdate.y:202: unrecognized: 
%parse-param
/home/dissent/prj/libcvs/var/ccvs-1.12/lib/getdate.y:202:Skipping to next %
/home/dissent/prj/libcvs/var/ccvs-1.12/lib/getdate.y:203: unrecognized: 
%lex-param
/home/dissent/prj/libcvs/var/ccvs-1.12/lib/getdate.y:203:Skipping to next %
*** Error code 1

Stop in /home/dissent/prj/libcvs/var/ccvs-1.12/lib.
*** Error code 1

Stop in /home/dissent/prj/libcvs/var/ccvs-1.12 (line 413 of Makefile).
*** Error code 1

Stop in /home/dissent/prj/libcvs/var/ccvs-1.12 (line 321 of Makefile).


$ bison --version
bison (GNU Bison) 1.35

Copyright 1984, 1986, 1989, 1992, 2000, 2001, 2002
Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

- -- 
https://savannah.gnu.org/projects/libcvs-specAccess CVS through a library.
PGP:  ID: 0x23DC453B  FPR: 42D0 66C2 9FF8 553A 373A  B819 4C34 93BA 23DC 453B
convince your customer that pserver access to a CVS server is, if not
*actually* the work of the devil, then pretty similar -- Derek Price
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.2.2 (OpenBSD)
Comment: Processed by Mailcrypt 3.5.8 

iD8DBQFCrtxfTDSTuiPcRTsRAus7AJ9LHO72rDwLfHOu13v0zk/zuwpm1wCfX5l4
hC+lcy/W/Icx+5lfXR+E8cY=
=xBra
-END PGP SIGNATURE-


___
Bug-cvs mailing list
Bug-cvs@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-cvs