Re: history and val-tags locks.

2005-04-27 Thread Derek Price
Mark D. Baushke wrote: Derek Price [EMAIL PROTECTED] writes: I'm getting ready to make two changes, possibly on stable. The first would be to add file locking for the CVSROOT/history and CVSROOT/val-tags files. I have some reports of massively corrupted history files in large repositories

Re: history and val-tags locks.

2005-04-27 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Mark D. Baushke wrote: An associated change I was putting off talking about was adding a global `-c config_file' option to cause CVS to look elsewhere for its configuration file. I worry about the security implications of this one. I don't

Re: history and val-tags locks.

2005-04-27 Thread Derek Price
Derek Price wrote: I see your point. What about `cvs server'? I can see both setups being useful... an admin who allowed users access to the CVS repository would probably prefer not to allow the config file to be specified whereas an admin who restriced the command that SSH users could run

Re: Patch for preserving edit on files when checking out

2005-04-21 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Mark D. Baushke wrote: Derek Price [EMAIL PROTECTED] writes: Darren Bowles wrote: Please find attached my cvs patch, with test added to sanity.sh. As requested, the format is cvs diff -u ... That said, it looks like it will probably work

Re: Patch for preserving edit on files when checking out

2005-04-20 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 You really don't need to send things twice to this mailing list. PLEASE allow up to 24 hours before you assume there is a problem in the mailing system. Sometimes mail gets delayed waiting for the automated spam filter when there is other heavy

Re: ylwrap should be included for any Yacc compilations.

2005-04-19 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Alexandre Duret-Lutz wrote: Hi Derek, Sorry for the long delay. No problem, I understand. :) Using ylwrap in all cases is already planed for automake-1.10 for other reasons, so I guess that will be OK with you. Yep. That'll do. I had

Re: FW: Patch for preserving edit on files when checking out

2005-04-19 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Darren Bowles wrote: I've had a few people asking me for my patch, so maybe the previous one never made it to the list; I know I had attachment problems before. Please find enclosed the patch (as text) from the previous email. Patches will not

Re: some files are missed in importing

2005-04-19 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Pierre Asselin wrote: Or, if it's not too late, delete the .cvsignore files and repeat the import, using exactly the same release tag. Although, if the tarball you are importing from includes a .cvsignore that instructs CVS to ignore certain

Re: FW: Patch for preserving edit on files when checking out

2005-04-19 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Ian Abbott wrote: On 18/04/05 14:54, Darren Bowles wrote: I've had a few people asking me for my patch, so maybe the previous one never made it to the list; I know I had attachment problems before. Please find enclosed the patch (as text) from

Re: FW: Patch for preserving edit on files when checking out

2005-04-19 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Ian Abbott wrote: I've looked in my sent mail folder and Thunderbird gave it a MIME type of text/x-diff, possibly based on the file extension .patch. I'll try renaming it to .txt and see if that works. Seems reasonable enough. Done. Cheers,

Re: FW: Patch for preserving edit on files when checking out

2005-04-19 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Derek Price wrote: possible) and documentation (when necessary). Also, please send patches in universal (`cvs diff -u') I've been corrected - that should be unified, as opposed to universal, diff format, above. But it's still `cvs diff -u

Re: FW: Patch for preserving edit on files when checking out

2005-04-19 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Derek Price wrote: Ian Abbott wrote: I've looked in my sent mail folder and Thunderbird gave it a MIME type of text/x-diff, possibly based on the file extension .patch. I'll try renaming it to .txt and see if that works. Seems reasonable

Re: newtags

2005-04-19 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Frank Hemer wrote: I'd like to see my latest patch from 2005-04-08 18:03 beeing commited to the newtags branch so I can continue working on it ... Sorry. I ran the tests and saw them pass the other day but I had been having a hard time finding

Re: newtags

2005-04-19 Thread Derek Price
Oh, if you hadn't gathered, I committed your latest patch to the `newtags' branch. Cheers, Derek Derek Price wrote: Frank Hemer wrote: I'd like to see my latest patch from 2005-04-08 18:03 beeing commited to the newtags branch so I can continue working on it ... Sorry. I ran

Stable CVS Version 1.11.20 Released! strongSecurity Update/strong

2005-04-18 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Stable CVS 1.11.20 has been released. Stable releases contain only bug fixes from previous versions of CVS. This version fixes many minor security issues in the CVS server executable including a potentially serious buffer overflow vulnerability with

Re: CVS Feature Version 1.12.12 Released! * Security Update *

2005-04-18 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Derek Price wrote: We recommend this upgrade for all CVS servers! Cut and paste error. Should have read: We recommend this upgrade for all CVS clients and servers already running the feature release and for those who simply like to stay

CVS Feature Version 1.12.12 Released! * Security Update *

2005-04-18 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Feature CVS 1.12.12 has been released. Feature releases contain new features as well as all the bug fixes from the stable releases. This version fixes many minor security issues in the CVS server executable including a potentially serious buffer

Re: get_date returning false

2005-04-15 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Mark D. Baushke wrote: [EMAIL PROTECTED] mdb]$ export TZ=Asia/Calcutta [EMAIL PROTECTED] mdb]$ date Fri Apr 15 07:01:59 2005 ... [EMAIL PROTECTED] mdb]$ TZ=Pacific/Honolulu date Fri Apr 15 07:07:12 2005 [EMAIL PROTECTED] mdb]$ That said, I

Re: get_date returning false

2005-04-15 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Mark D. Baushke wrote: So, for unrecognized zones, three spaces are produced for the timezone on the CRAY Y-MP system. Hrm. `date +%Z' returns `GMT' on my NetBSD 1.6.1. I think this will not be easy, especially as one of the timezones suggested

Re: write proxies and pserver vs ext

2005-04-11 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Harald Dunkel wrote: | Hi folks, | | Is there any chance to get rid of the ext-only restriction for | PrimaryServer? I surely would not like to give every developer and | his mom an account on our central CVS server. You can take a look at it.

Re: get_date returning false

2005-04-08 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Ian Abbott wrote: | If you want to try and reproduce it, you'll probably need to set | the TZ environment variable. Mine is set to Europe/London, but if | your libc doesn't understand that format, you can try | GMT0BST,M3.5.0,M10.5.0 or GMT0BST

Re: get_date returning false

2005-04-08 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Ian Abbott wrote: | On 08/04/2005 16:05, Derek Price wrote: | | -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 | | Ian Abbott wrote: | | | If you want to try and reproduce it, you'll probably need to | set | the TZ environment variable. Mine is set

Re: get_date returning false

2005-04-08 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Ian Abbott wrote: | Hi Derek, | | I've tried building getdate in cvs-1.12.11 and in ccvs from the | repository. I got the same result in both cases. | | If you want to try and reproduce it, you'll probably need to set | the TZ environment variable.

Re: get_date returning false

2005-04-08 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Ian Abbott wrote: | Hi Derek, | | On 08/04/05 19:05, you wrote: | | Is there some simple, cross-platform test I could use to fall | back on GMT0BST,M3.5.0,M10.5.0 if the Europe/London timezone | isn't defined or skip the tests entirely if neither zone

Re: [Issue 244] New - Empty ALLOCA causing build error on HPUX

2005-04-07 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Nicolas Raoul wrote: | Hello, | | The bug seems to be fixed, from what I have seen through the | BrowseSource interface. I can NOT confirm that the CVS head builds | properly by now, but I will be able to check as soon as I receive | the observer role

Re: Feature request/ideas - final patch

2005-04-07 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Frank Hemer wrote: | I have adapted most of the broken code, so again all tests pass. | Unfortunately RCS_tag2rev() needs a special handling because it is | responsible for adding rev. numbers (with magic) to the RCS file. I | also had to fix part of

Re: get_date returning false

2005-04-07 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 The correct place to report bugs in the getdate library would be [EMAIL PROTECTED], but could you please verify that you can reproduce your problem with the version of CVS available from the CVS repository on cvshome.org before you bother them? Also,

Re: PAM in cvs 1.11

2005-04-07 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Yves Dorfsman wrote: | Hi, | | I am on a site where they are changing the way the OS is | authenticating users, moving away from NIS to LDAP. My | understanding is that the only way to get CVS working in pserver | mode in that case is to use PAM. | |

Re: Feature request/ideas - final patch

2005-04-06 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Frank Hemer wrote: | Frank, | | I've committed a few new changes and the tests are passing again, | including your new tag-ext tests. | | I also added a FIXME comment or two. Please take a look, | especially at the one in RCS_getprevious. | | | Well,

Re: [Issue 244] New - Empty ALLOCA causing build error on HPUX

2005-04-05 Thread Derek Price
Hey Larry, why aren't you seeing this on your nightly HPUX testing? HPUX B11.00 A 9000/785 looks pretty close to HPUX B11.00 U 9000/785 to my naive eyes. Are you using GNU Make and Nicolas isn't? Derek [EMAIL PROTECTED] wrote: https://ccvs.cvshome.org/issues/show_bug.cgi?id=244

Re: [Issue 244] New - Empty ALLOCA causing build error on HPUX

2005-04-05 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Larry Jones wrote: | Derek Price writes: | | Hey Larry, why aren't you seeing this on your nightly HPUX | testing? | | | Well, at least one reason is because lib/Makefile.in hasn't look | like that since we switched to the newer version of Automake

Re: ylwrap should be included for any Yacc compilations.

2005-04-04 Thread Derek Price
compiling even a single yacc source. If this is not sufficient to reproduce the problem, Larry Jones (CC'd) can probably provide more details about his environment. He encountered this in the first place. Cheers, Derek Alexandre Duret-Lutz wrote: | Derek == Derek Price [EMAIL PROTECTED] writes

Re: ylwrap should be included for any Yacc compilations.

2005-04-04 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Alexandre Duret-Lutz wrote: | Derek == Derek Price [EMAIL PROTECTED] writes: | | | Derek ylwrap appears to take care of the problem that Yacc | compilers like to Derek generate #line directives in generated C | sources with complete paths Derek

ylwrap should be included for any Yacc compilations. (was Re: CVS 1-11-x-branch testing results (SUN Solaris))

2005-03-23 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 ylwrap appears to take care of the problem that Yacc compilers like to generate #line directives in generated C sources with complete paths to source files. Aparrently, this is needed on some systems because the C compilers there will add paths in

Re: Patch for preserving edit on files when checking out

2005-03-22 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Mark D. Baushke wrote: | The patch was not found as bug-cvs@gnu.org strips attachments. That's not strictly true. It strips attachments that don't have a type of text/plain. My mail client (previously Netscape Mail, now Thunderbird in its new

Re: Problem with compiling sighandle.c on CVS 1.11.19 with GCC 3.2.2 on Solaris 9

2005-03-22 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 mac a cody wrote: | Greetings, | | I trying to compile cvs 1.11.19 on a Sun workstation running | Solaris 9 with GCC 3.2.2. After performing configure as follows... | | | ./configure --prefix=/products/cvs-1.11.19/local |

Re: Problem with compiling sighandle.c on CVS 1.11.19 with GCC 3.2.2 on Solaris 9

2005-03-22 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 mac a cody wrote: | I notice in the output of my configure that the result of checking | for sys/stat.h is no. Could this be an indication of a problem | with stat.h? configure is detecting that a very simple program including the line, #include

Re: Feature request/ideas - final patch

2005-03-20 Thread Derek Price
Derek Price wrote: Frank Hemer wrote: | I have finally finished my patch, tests and alike are contained: I've checked this in on the newtags branch in the main repository and started with some simplification and cleanup. If you are going to do any further work on this, please work and create

Re: Feature request/ideas - final patch

2005-03-19 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Frank Hemer wrote: | I have finally finished my patch, tests and alike are contained: I've checked this in on the newtags branch in the main repository and started with some simplification and cleanup. If you are going to do any further work on this,

Re: CVS Sources Using Automake 1.9.5.

2005-03-17 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jim.Hyslop wrote: | Derek Price wrote: | | I've restandardized on the latest Automake version for | convenience re the earlier discussion: | http://lists.gnu.org/archive/html/bug-cvs/2005-03/msg00048.html. | Please regenerate build files with Automake

CVS Sources Using Automake 1.9.5.

2005-03-16 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hey Developers, I've restandardized on the latest Automake version for convenience re the earlier discussion: http://lists.gnu.org/archive/html/bug-cvs/2005-03/msg00048.html. Please regenerate build files with Automake 1.9.5 before committing changes

Re: A problem, a fix and a request

2005-03-14 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Gregg Leichtman wrote: | The fix is to replace the atomic rename operation with a | non-atomic copy and unlink. Since this is happening inside the | user's sandbox, | | I don't think an atomic operation is needed. I could be wrong. | | rename_file

Re: Feature request/ideas

2005-03-11 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Frank Hemer wrote: | Also, .commitid.next as currently defined should be nonsense in | almost all cases. Only .commitid .commitid.prev are | meaningful. | | | Thats right. However it would require extra code to prevent this, | and I don't really

Re: lines modified in newly-added files

2005-03-11 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Neil Conway wrote: | Derek Price wrote: | | You're welcome. I'm looking forward to seeing a patch! | | | Ok, I finally had a chance to look this at. Below is a WIP patch. | Example output: | | [neilc:/home/neilc/cvs_test]% ~/cvs-1.12.11/src/cvs log

Re: Feature request/ideas

2005-03-10 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Mark D. Baushke wrote: | Derek Price [EMAIL PROTECTED] writes: | | Frank Hemer wrote: | | | a revision on BRANCH's parent. This makes sense when speaking | | about individual files, but use of .origin with multiple | files | probably deserves some

Re: Feature request/ideas

2005-03-10 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Frank Hemer wrote: | Hold on ... it seems I have found a workaround for this: | | /* If a file was added on the trunk, and it is added on * a branch | in a second step, the '1.1.2.1' revision is * dead, and timestamp | of 1.1 and 1.1.2.1 are equal. *

Re: [bug-gnulib] GNULIB wait-process module.

2005-03-09 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Bruno Haible wrote: | Thanks for explaining. Your objective is clear now. | | But how would you want this to work on Woe32? I assume that you | would want this debugging feature also on Windows. How do you | implement it there? Actually, the CVS server

Re: Feature request/ideas

2005-03-09 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Frank Hemer wrote: | Here is a more detailed description of the tag-extensions: Mostly this sounds great, with the few questions/exceptions that I have noted. Could you write the final version up as a patch to doc/cvs.texinfo? | '.origin': Will always

Re: Feature request/ideas

2005-03-09 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Frank Hemer wrote: | On Wednesday 09 March 2005 15:50, Derek Price wrote: | | Frank Hemer wrote: | Here is a more detailed description of the | tag-extensions: | | Mostly this sounds great, with the few questions/exceptions that | I have noted

Re: windows-NT/mkconfig.pl windows-NT/fix-msvc-mak.pl change

2005-03-09 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Conrad T. Pino wrote: | Previously I wasn't aware of the existence of the intermediates on | UNIX and of course they don't exist on Windows. The commands I ran | on both Windows and UNIX are: | | cd ccvs perl windows-NT/fix-msvc-mak.pl cd windows-NT

Re: Feature request/ideas

2005-03-09 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Frank Hemer wrote: | a revision on BRANCH's parent. This makes sense when speaking | about individual files, but use of .origin with multiple files | probably deserves some sort of warning to the user that what they | asked for may not make sense. | |

Re: GNULib save-cwd.c on Windows Visual Studio 6.0

2005-03-08 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jim.Hyslop wrote: | Jim Meyering wrote: | | Is it an option to use a more modern/POSIX-compliant development | environment on Windows? I know that Cygwin now has fchdir and it | looks like MKS has support for it, too. | | | If you opt to continue

Re: GNULib save-cwd.c on Windows Visual Studio 6.0

2005-03-08 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jim Meyering wrote: | Derek Price [EMAIL PROTECTED] wrote: | | I'm afraid I have to agree with Jim Hyslop. Whatever Microsoft's | flaws, I still believe that some of our mutual user base is at | least relatively innocent and should still be catered

Re: cvs is slooooooow with large directories

2005-03-08 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Larry Jones wrote: | Andrew Morton writes: | | On a dual 2.7GHz power4, the cvs client has racked up an hour of | CPU time so far. There's something in there which is quadratic | (or worse) in the number of files in a directory. | | | Yes, the fix for

Re: lib/stdint.h intermediate file

2005-03-08 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Conrad T. Pino wrote: | The build process on Solaris 8 Intel Edition seems to generate | lib/stdint.h as an intermediate build product. | | Is there any objection to adding stdint.h to the lib/.cvsignore | file? None whatsoever. :) Regards, Derek

Re: [bug-gnulib] GNULIB wait-process module.

2005-03-08 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Any further thoughts on this patch? | 2005-03-04 Derek R. Price [EMAIL PROTECTED] | | * lib/wait-process.h (wait_subprocess): Accept a new exitsignal | argument. * lib/wait-process.c (wait_subprocess): Always set | *exitsignal to 0 when present and

Re: windows-NT/mkconfig.pl windows-NT/fix-msvc-mak.pl change

2005-03-08 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Conrad T. Pino wrote: | | Hi Derek, | | From: Derek Price [mailto:[EMAIL PROTECTED] | | I've attached the diff. Conrad or somebody, would you mind | verifying that after applying this patch (on WOE32, only the two | named files will be relevant

Re: [bug-gnulib] valloc()?

2005-03-04 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Bruno Haible wrote: | So the only thing I consider possible is the appended patch. Ok. Regards, Derek -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.0 (Cygwin) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

Re: [bug-gnulib] valloc()?

2005-03-04 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Derek Price wrote: | Re my earlier questions about efficiency, here's the patch using | the new pagealign_alloc module which is currently passing `make | remotecheck' here. It also contains a few modification to the new | GNULIB pagealign_alloc module

Re: Feature request/ideas

2005-03-04 Thread Derek Price
Derek Price wrote: Mark D. Baushke wrote: | Therefore, I suppose that there could be a need for .origin to be | the first revision on TRUNK This would seldom mean much across multiple files, so I still think .origin should not be used. The case Frank cited, where he is basically trying to diff

Re: Feature request/ideas

2005-03-03 Thread Derek Price
Derek Price wrote: | | So probably the expression used should connote this. After some | | consideration, I would vote for '.origin' here. I disagree | with | being meaningless. I often export a project state into a | local | repository, work on it, and when I'm done, move the files | back

Re: `cvs up -p FILE' does not detect write failure

2005-03-03 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jim Meyering wrote: | Here's a complete patch, minus the parts that are regenerated via | autoreconf (which I'll check in, too, being careful to use | automake-1.9.3, which is what generated the current Makefile.in | files -- unless we can upgrade to

Re: Feature request/ideas

2005-03-03 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Mark D. Baushke wrote: | Derek Price [EMAIL PROTECTED] writes: | | Derek Price wrote: | | | | So probably the expression used should connote this. After | some | | consideration, I would vote for '.origin' here. I | disagree | with | being meaningless

Re: Feature request/ideas

2005-03-03 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Mark D. Baushke wrote: | Larry Jones [EMAIL PROTECTED] writes: | | Mark D. Baushke writes: | | I have no objections to .origin being used for the very first | revision of the mainline. | | Why bother with a special name? Just use .trunk.root. | | |

Re: Feature request/ideas

2005-03-03 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Mark D. Baushke wrote: | Derek Price [EMAIL PROTECTED] writes: | | I thought Mark was just saying earlier in this thread that | .trunk.root, by virtue of .root normally specifying a revision on | the parent branch, should refer to the `0' revision

Re: [bug-gnulib] valloc()?

2005-03-03 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Bruno Haible wrote: | Do you still see some nits that could be improved? | | | Oops, there was one more nit: The error messages were not | internationalized. I did this: [snip] | *** *** 129,135 { fd = open (/dev/zero, | O_RDONLY,

Re: [bug-gnulib] valloc()?

2005-03-03 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Re my earlier questions about efficiency, here's the patch using the new pagealign_alloc module which is currently passing `make remotecheck' here. It also contains a few modification to the new GNULIB pagealign_alloc module because I haven't

Re: Feature request/ideas

2005-03-03 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Mark D. Baushke wrote: | Therefore, I suppose that there could be a need for .origin to be | the first revision on TRUNK This would seldom mean much across multiple files, so I still think .origin should not be used. The case Frank cited, where he is

Re: [bug-gnulib] valloc()?

2005-03-03 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Bruno Haible wrote: | Derek Price wrote: | | Should this error still be exiting (EXIT_FAILURE) when this | function is defined to return NULL on failure? | | | In this case the error is not memory exhausted, it is cannot | open /dev/zero. This can

GNULIB wait-process module.

2005-03-03 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hello. I was looking at removing CVS's internal waitpid substitute in favor of the GNULIB wait-process module, but it's missing one feature I need. CVS needs to detect core dumps in the child of the server so that the parent knows not to clean up the

Re: [bug-gnulib] valloc()?

2005-03-03 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Bruno Haible wrote: | Derek Price wrote: | | It could print the error message with error (0, errno, ...) and | then return NULL. The caller could then decide if that error | should be fatal or not, as I presume they might wish to if they | are calling

Re: [bug-gnulib] valloc()?

2005-03-02 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Bruno Haible wrote: | Is this all worth it? For what purpose do you need the memory to be | page-aligned? That's a good question, as the original isn't my code. I was just assuming that whoever wrote it originally knew what they were doing. There is

Re: Feature request/ideas

2005-03-02 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Frank Hemer wrote: | On Wednesday 02 March 2005 08:11, Mark D. Baushke wrote: | | Hi Frank, | | I am looking forward to your feature... | | | :-) I'm looking forward to this too. I just have one quibble, with your usage of .root. The CVS manual and

Re: Feature request/ideas

2005-03-02 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Frank Hemer wrote: | Not a problem, its just a #define. However I didn't have a better | idea. Using .base instead can be similar miss-interpreted since | there is BASE. How about replacing '.root' with '.tail', and | replacing '.origin' with '.root'?

Re: [bug-gnulib] valloc()?

2005-03-02 Thread Derek Price
really need is the valloc() module, though it might be nice to default to posix_memalign() (or mmap()?) instead, when one can be found, simply to avoid the wasted space before the page.) Regards, Derek Derek Price wrote: | Bruno Haible wrote: | | | Is this all worth it? For what purpose do you need

Re: Feature request/ideas

2005-03-02 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Mark D. Baushke wrote: | Frank Hemer [EMAIL PROTECTED] writes: | | However I didn't have a better idea. Using .base instead can be | similar | miss-interpreted since there is BASE. How about replacing '.root' | with '.tail', and replacing '.origin'

Re: Feature request/ideas

2005-03-02 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Frank Hemer wrote: | Hi Derek, | | Mark D. Baushke wrote: | Frank Hemer [EMAIL PROTECTED] writes: | | However I didn't have a better idea. Using .base instead can be | | | similar | | miss-interpreted since there is BASE. How about | replacing '.root'

Re: Feature request/ideas

2005-02-28 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Frank Hemer wrote: | On Saturday 26 February 2005 21:06, Derek Price wrote: | | Frank Hemer wrote: | On Saturday 26 February 2005 00:27, Derek | Price wrote: | Frank Hemer wrote: | I was just glancing at that | patch and I | think I can implement

Re: Feature request/ideas

2005-02-28 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Frank Hemer wrote: | The patch looks pretty good. It's pretty close to what I am | doing, except I am splitting tags with operators (.word) on the | `.' and then processing the resulting list an element at a time. | Thus .prev can be implemented for

Re: Feature request/ideas

2005-02-28 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Frank Hemer wrote: | | If tags with '@' at the begining are used they're added in | the | cvsnt way (I remember I wrote cvsnt wouldn't cache them | but I was | wrong). If the .commitid is used, they're cached as | | '.commitid.xxx', but this could be

Re: Feature request/ideas

2005-02-28 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Frank Hemer wrote: | | Ooops, I think I'm too fast;-) I have just finished adding | '.trunk' | as a trunk-branch substitution, 'cause I happened to | note that this | fits perfectly into my patch. I have already | used the above | mentioned splitting -

Re: Feature request/ideas

2005-02-26 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Frank Hemer wrote: | On Saturday 26 February 2005 00:27, Derek Price wrote: | | Frank Hemer wrote: | I was just glancing at that patch and I | think I can implement | what Steve did much more succinctly, so | I'm going to take a shot | at it. The most

Re: Feature request/ideas

2005-02-25 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Frank Hemer wrote: | On Thursday 24 February 2005 17:03, Derek Price wrote: | | Frank Hemer wrote: | I have added support for the commitid in | about the same manner as | it is implemented in cvsnt, so this | shouldn't be a compatibility | issue

Re: Feature request/ideas

2005-02-25 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Mark D. Baushke wrote: | FYI... | | I think I have been able to reconstruct the original patch without | linewrap... I don't know if I'll have time to really test it this | week, so Derek may feel free to commit it if he thinks it is ready | to go

Re: Feature request/ideas

2005-02-24 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Frank Hemer wrote: | If your second part, above, were abstracted out such that the new | revision-1 tag could be used anywhere CVS accepts two revision | options (basically, diff update/commit -j), then this format | could also be used to concisely

Re: Feature request/ideas

2005-02-24 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Frank Hemer wrote: | I have added support for the commitid in about the same manner as | it is implemented in cvsnt, so this shouldn't be a compatibility | issue. However, the commitid is as well added to the 1.1 and | 1.1.1.1 revisions at the initial

Re: 'cvs watch on' patch (was: Changing passwords for CVS Users (pserver protocol)]

2005-02-24 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jim Hyslop wrote: | Derek Price wrote: | | The patch does what you said it would on stable, but something | else is wrong on feature. The new watch6-2 test fails - | basically, the previous watch add appears to be failing without | reporting the error

Re: --disable-proxy configure option cause CVS build failure

2005-02-24 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jim Salter wrote: | Configure option: --disable-proxy | | server.c: In function `isSamePath': server.c:512: error: structure | has no member named `PrimaryServer' I've fixed this in the dev tree for all possible combinations of - --disable-client,

Re: FAQ-O-Matic pserver protocol

2005-02-22 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Larry Jones wrote: | Guus Leeuw jr. writes: | | I take this as a veto for no switches, but merely cvs passwd | which would run only: a) if pserver protocol b) the user in | questo is listed in CVSROOT/passwd on the pserver | | | I don't even like the

Re: CVS Feature Branch - Windows Build Broken - run_add_arg, run_piped

2005-02-22 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Conrad T. Pino wrote: | The following patch fixes all build errors. | | I don't claim it works and I don't claim it doesn't work. | | It's a good guess and I'd appreciate feedback before committing. It looked good and I committed it. Thanks for

Re: CVS Feature Branch - Windows Build Broken - run_add_arg, run_piped

2005-02-22 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Derek Price wrote: | Thanks for noticing strtok is unneeded. I'm installing that in src | too. Er, I thought I saw that there was an extra strtok decl in src too, but I guess not. Thanks regardless. Cheers, Derek -BEGIN PGP SIGNATURE- Version

Re: lines modified in newly-added files

2005-02-22 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Neil Conway wrote: | Derek Price wrote: | | You will need to count the total number of lines in the HEAD | revision and keep it up to date as added and deleted lines for | other revisions are processed. Later, in `cvs log', these new | fields should

Re: FAQ-O-Matic pserver protocol

2005-02-22 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Brian Murphy wrote: | Derek Price wrote: | | -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 | | Larry Jones wrote: | | | Guus Leeuw jr. writes: | | I take this as a veto for no | switches, but merely cvs passwd | which would run only: a) if | pserver

Re: lines modified in newly-added files

2005-02-21 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Neil Conway wrote: | On Tue, 2005-02-15 at 12:41 +1100, Neil Conway wrote: | | I would like to see lines: +3 0 associated with revision 1.1. | It is possible to get the number of lines modified via a kludge | (fetch the 1.1 revision of the file and

Re: :ext: with ssh failure on w2k - patch

2005-02-20 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Frank Hemer wrote: | The basic problem, as Frank Hemer has described it, is that there | are some conditions where the Windows client can expect to be in | non-blocking mode yet fail to really be in non-blocking mode, | causing a hang. Frank has yet

Re: :ext: with ssh failure on w2k - patch

2005-02-19 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Frank Hemer wrote: | It seems I have tracked down the failure - Find below a patch that | fixes this issue: I don't like this patch. It must be in the wrong direction. I refuse to believe that there is really no way to set non-blocking mode on a file

Re: 'Dying gasps received from client.' with CVS 1.12.11

2005-02-14 Thread Derek Price
Jörg Bullmann wrote: Both imports worked fine with 1.12.11.1. I double checked them against a 1.12.10 CVS where they both failed and caused MacCVSClient to wait and wait and wait... So, I'd say you nailed it! Good detective work. ;-) And sorry for the delay in testing this. Jörg, Thanks for

Re: CVS-1_11_19/18 and VMS

2005-02-08 Thread Derek Price
Piet, Thanks for the suggestions. I took a few of them literally and did what I thought was right for the rest. Basically, vms/config.h is being autogenerated on other platforms (with a reall, current version number in PACKAGE_STRING) like for windows-NT/config.h. I also have VMS falling

<    1   2