Re: [PATCH] pagealign_alloc: don't loop endlessly
Derek Price dixit: >>Yes, that's why I was suggesting to print the error message to stderr >>so at least the client gets an idea about what happened and can slap >>the server administrator. CVS does this for quite some occasions, for >>example no space available in the server's temporary directory. > >Could you point me at the code that does this? Not out of the blue, I had to check. But it happens frequently when e.g. the OpenBSD anoncvs servers are overloaded. >How much good would sending the message to stderr really do? This >problem can only occur on the server, where sending to stderr, at best, >can only be reported to the client as an unrecognized protocol response, >if reported at all, once the network buffers are disabled (the network >buffer code is what is calling pagealign_alloc() here). No, it's actually displayed by the client (with my first diff). bye, //mirabile -- > Hi, does anyone sell openbsd stickers by themselves and not packaged > with other products? No, the only way I've seen them sold is for $40 with a free OpenBSD CD. -- Haroon Khalid and Steve Shockley in gmane.os.openbsd.misc ___ Bug-cvs mailing list Bug-cvs@gnu.org http://lists.gnu.org/mailman/listinfo/bug-cvs
Re: [PATCH] pagealign_alloc: don't loop endlessly
Derek Price dixit: >Does the attached, more general, patch do the trick for you? It does, but I do not get a diagnostic, neither on stderr (CVS output) nor in syslog on server or client. This is probably because the CVS server is running in a chroot. I suggest a diagnostics on stderr, plus - in this case - the actual solution is to add a device node into the chroot, and from a "recursion error" nobody would get the idea. //mirabile -- > Hi, does anyone sell openbsd stickers by themselves and not packaged > with other products? No, the only way I've seen them sold is for $40 with a free OpenBSD CD. -- Haroon Khalid and Steve Shockley in gmane.os.openbsd.misc ___ Bug-cvs mailing list Bug-cvs@gnu.org http://lists.gnu.org/mailman/listinfo/bug-cvs
Re: [PATCH] pagealign_alloc: don't loop endlessly
Derek Price dixit: >Can you provide me with a test case that reproduces this behavior? Sorry, not at the moment, at least not without a great effort. I will do as soon as I've reinstalled my boxen. I could do a temporary test scenario, but we needed to be in sync for that. Join irc.oftc.net and /msg mira if you're interested. //mirabile -- > Hi, does anyone sell openbsd stickers by themselves and not packaged > with other products? No, the only way I've seen them sold is for $40 with a free OpenBSD CD. -- Haroon Khalid and Steve Shockley in gmane.os.openbsd.misc ___ Bug-cvs mailing list Bug-cvs@gnu.org http://lists.gnu.org/mailman/listinfo/bug-cvs
Re: [PATCH] pagealign_alloc: don't loop endlessly
Derek Price dixit: >My patch logs the actual error message to the syslog too (via the >vsyslog() call), but if your chroot is preventing access to the syslog, >that wouldn't help anyhow. Yes, that's why I was suggesting to print the error message to stderr so at least the client gets an idea about what happened and can slap the server administrator. CVS does this for quite some occasions, for example no space available in the server's temporary directory. //mirabile -- > Hi, does anyone sell openbsd stickers by themselves and not packaged > with other products? No, the only way I've seen them sold is for $40 with a free OpenBSD CD. -- Haroon Khalid and Steve Shockley in gmane.os.openbsd.misc ___ Bug-cvs mailing list Bug-cvs@gnu.org http://lists.gnu.org/mailman/listinfo/bug-cvs
