Re: Unable to install CVS Server on Windows OS

2005-07-07 Thread Derek Price
[EMAIL PROTECTED] wrote: So, My requirement is to install CVS Server one machine and CVS Client on other machine for Windows OS Network which configuration is given below:- Operating System: Microsoft Windows 2000 Professional (32-bit) The GNU CVS project does not run as a server by default

Re: CVS problem with ssh

2005-07-07 Thread Derek Price
Richard M. Stallman wrote: I wrote the code, checking the specs, and got it to compile correctly. I don't have any easy way to test it--Emacs is not well suited to that purpose. Could you test it? You neglected to include a wrapper for at least fflush(). subst_fwrite (buffer, 1,

Re: CVS problem with ssh

2005-07-06 Thread Derek Price
Larry Jones wrote: Richard M. Stallman writes: If this is what it takes for you to fix the bug, I will do this. Instead of spending large amounts of effort on half-assed workarounds, why don't you make a concerted effort to explain the problem to the OpenSSH developers and encourage

Re: CVS problem with ssh

2005-07-06 Thread Derek Price
Richard M. Stallman wrote: Not exactly. If a solution like this were to go into GLIBC, then it becomes much more likely that it can be shared with GNULIB, which means that the infrastructure for it is already in CVS and that supporting it won't rely exclusively on the extremely

Re: CVS problem with ssh

2005-07-05 Thread Derek Price
Richard M. Stallman wrote: Why not have glibc incorporate the moral equivalent of the unlocked stdio routines (fwrite_unlocked, printf_unlocked, etc.), like fwrite_block? I am not sure what unlocked means, I'm referring to the non-thread-safe stdio variants exported by glibc and

Re: CVS problem with ssh

2005-06-29 Thread Derek Price
Why not have glibc incorporate the moral equivalent of the unlocked stdio routines (fwrite_unlocked, printf_unlocked, etc.), like fwrite_block? Similarly for printf_block, fprintf_block, etc. Most of the stdio code would not need to be reimplemented since it is already present in glibc and

Re: Terminated with fatal signal 11

2005-06-28 Thread Derek Price
it sleeps, after starting it via Tortoise or whatever. Good luck, Derek Gary Wake wrote: Love to but we don't have a 'core' file anywhere on the system Derek Price wrote: Gary Wake wrote: Terminated with fatal signal 11 Error, CVS operation failed Can you find the server core

Re: CVS problem with ssh

2005-06-28 Thread Derek Price
Richard M. Stallman wrote: Currently CVS does a single select on the stdout fileno before dumping as much data as it last received from the network to stdout via fwrite. There is *no looping or checking for EAGAIN returns*, which I believe you advocated but, I am informed by

Re: Terminated with fatal signal 11

2005-06-27 Thread Derek Price
Gary Wake wrote: Terminated with fatal signal 11 Error, CVS operation failed Can you find the server core dump and get us a stack trace from the debugger? Regards, Derek ___ Bug-cvs mailing list Bug-cvs@gnu.org

Re: CVS problem with ssh

2005-06-27 Thread Derek Price
Richard M. Stallman wrote: The code currently works by making the assumption that network reads will always return chunks of data small enough to be written to stdout in a single call to fwrite after a single select on fileno (stdout). What would make some data too long? The nmemb

Re: CVS problem with ssh

2005-06-23 Thread Derek Price
Richard M. Stallman wrote: It's possible that this fix is a full and correct solution. If the descriptor has room for at least one byte, `write' won't return EAGAIN; it will write at least one byte. It may write less than the whole buffer that was specified. If the stdio code handles that case

Re: CVS problem with ssh

2005-06-22 Thread Derek Price
Richard M. Stallman wrote: Couldn't this be fixed easily by changing cvs to handle EAGAIN in a simple way when outputting to stdout? If it just sleeps for a second and tries again, that ought to fix the problem. Mark Baushke installed Frank Hemer's partial work-around for this problem some

Re: Core dump during CVS Commit

2005-06-16 Thread Derek Price
Smruti wrote: Hi Dreek, Thanks for the mail. Could you update me how shall I take stack trace from core? Using the GNU debugger (gdb), the command is `bt' (for backtrace). Thus, assuming that you were using /usr/bin/cvs and that your core dump created a file named core.1234 (where 1234

Re: OpenBSD 3.6 sparc64 Build Failure on TRUNK

2005-06-15 Thread Derek Price
Alexander Taler wrote: $ make make all-recursive Making all in lib cp ./alloca_.h alloca.h-t mv alloca.h-t alloca.h /bin/sh ../build-aux/ylwrap getdate.y y.tab.c getdate.c y.tab.h getdate.h y.output getdate.output -- /bin/sh /home/dissent/prj/libcvs/var/ccvs-1.12/build-aux/missing --run

Re: OpenBSD 3.6 sparc64 Build Failure on TRUNK

2005-06-15 Thread Derek Price
Alexander Taler wrote: case $1 in --run) # Try to run requested program, and just exit if it succeeds. run= shift $@ exit 0 Where do you suppose that check should be? Actually, `missing' only `exit 0's when the program exited with a success code.

Re: Conditional/Comment Error? lib/canonicalize.c

2005-06-14 Thread Derek Price
Conrad T. Pino wrote: Can someone suggest which one of the following 2 changes (if any) is the best one to commit? Neither. Apparently we have been breaking the GNU commenting conventions for #ifdefs and GNULIB has it right: http://www.gnu.org/prep/standards/standards.html#Comments, though

Re: CVS update: /ccvs/lib/

2005-06-14 Thread Derek Price
Conrad T. Pino wrote: I added lib/lstat.c because linker didn't have definition for external symbol _rpl_lstat and a grep found only 1 definition. I had seen this commit to windows-NT/config.h files: https://ccvs.cvshome.org/servlets/ReadMsg?list=cvsmsgNo=3881 which I assume meant the reference

Re: CVS update: /ccvs/lib/

2005-06-13 Thread Derek Price
[EMAIL PROTECTED] wrote: Log: * libcvs.dsp: Add files filenamecat.h and lstat.c to project. Your change to filenamecat.h is correct - that's a rename of the path-concat module from GNULIB, but I don't think you want lib/lstat.h lib/lstat.c on Windows. lib/lstat.c contains a wrapper for

Re: patch: implement %{t} for loginfo

2005-06-10 Thread Derek Price
Todd Vierling wrote: NetBSD, among other projects, has used a change similar to this for many years, to allow the tag name to be passed to loginfo scripts. This allows the popular log_accum script to supply the tag name in the Subject line. Below is a diff against 1.12.12, and is really very

Re: GZip level restriction

2005-06-03 Thread Derek Price
Derek Price wrote: Derek Price wrote: On the other hand, it would be nice if there were a way to specify a default compression level or range of levels (both for the server and the client) that could be used in the absence of any explicit specification by the user. Of course, reconciling

Re: CVS update: /ccvs/windows-NT/

2005-06-01 Thread Derek Price
Conrad T. Pino wrote: The timer code in lib/nanosleep.c looks very good but I'm uncomfortable making a commitment to making the change because: * I don't understand UNIX style signal behavior well. Basically, signals normally cause a process to exit unless a handler is installed. *

Re: windows-NT/pwd.c - struct passwd - Home Directory

2005-06-01 Thread Derek Price
Conrad T. Pino wrote: My ideas for the API are UNIX/POSIX specifications are non-negotiable and internal APIs below that are discardable upon discovery of the better way. Basically. In theory, you could take up desired changes with the POSIX spec with IEEE. Of course, if you did get some

Re: CVS update: /ccvs/windows-NT/sys/

2005-06-01 Thread Derek Price
Conrad T. Pino wrote: Hi Derek, From: Derek Price I think renaming this file sys_types.h, starting it with `#include sys/types.h', then defining what else you need would be an easier interface to maintain. Are you implying changing all #include sys/types.h in CVS? I assume

Re: [bug-gnulib] New GNULIB glob module?

2005-06-01 Thread Derek Price
Paul Eggert wrote: Derek Price [EMAIL PROTECTED] writes: 1. Corrects an incorrect check for a successful return from getlogin_r to assume only 0 means success, per the POSIX2 spec: http://www.opengroup.org/onlinepubs/009695399/functions/getlogin_r.html. 2. Moves the check

Re: GZip level restriction

2005-06-01 Thread Derek Price
Derek Price wrote: On the other hand, it would be nice if there were a way to specify a default compression level or range of levels (both for the server and the client) that could be used in the absence of any explicit specification by the user. Of course, reconciling conflicting defaults

Re: windows-NT/pwd.c - struct passwd - Home Directory

2005-05-31 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Conrad T. Pino wrote: What I don't understand is why . is a reasonable home directory according to the getpwuid implementation: static char *home_dir = .; /* we feel (no|every)where at home */ I don't agree that it is. I think it was a poor,

Re: Feature Branch - windows-NT/pwd.h windows-NT/unistd.h

2005-05-31 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Conrad T. Pino wrote: Hi Derek, File windows-NT/pwd.h declares several functions that are declared in unistd.h according to the NetBSD man pages. Since I created windows-NT/unistd.c do you object in principle to migrations from pwd.c to unistd.c?

Re: Windows 2000 - HOMEDRIVE,HOMEPATH vs. USERPROFILE

2005-05-31 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 It sounds to me like we probably want to ignore USERPROFILE, then, and just use the home dir settings. How does the home directory get set to something other than undefined in your examples? Is there an API to read it from the system or must all

Re: CVS update: /ccvs/windows-NT/sys/

2005-05-31 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 [EMAIL PROTECTED] wrote: #ifdef _MSC_VER #pragma once /* Compatable with Visual C++ 6.0 - cl.exe 12.00 */ #if _MSC_VER != 1200 #pragma message ( Please email Microsoft's sys/types.h ) #pragma message ( file to [EMAIL PROTECTED] ) #endif /* _MSC_VER

Re: CVS update: /ccvs/windows-NT/

2005-05-31 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 [EMAIL PROTECTED] wrote: Log: * unistd.c, unistd.c: Add new usleep function using my_usleep logic taken from woe32.c file. * woe32.c, woe32.h: Add new (woe32_home_dir,woe32_shell) functions. * woe32.c: Modify woe32_nanosleep to use unistd.h

Re: OpenBSD 3.6 sparc64 stable crash

2005-05-31 Thread Derek Price
Alexander Taler wrote: +2005-05-31 Alexander Taler [EMAIL PROTECTED] + + * rcscmds.c: Change type of call_diff_argc_allocated from int to + size_t, to match the prototype of run_add_arg_p(). This fixes a + bus error in OpenBSD 3.6 sparc64. Makes sense. int size_t probably

Re: Module run.c Interface Standardized - Feature To Stable Branch

2005-05-30 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Conrad T. Pino wrote: I'll implement at least Option 2 by Wednesday. Do you have any preferred language or points you'd want covered in the FIXME note? Nothing in particular. Have at it. Cheers, Derek -BEGIN PGP SIGNATURE- Version: GnuPG

Re: Feature Branch Windows Build Broken - lib/glob.c WINDOWS32

2005-05-30 Thread Derek Price
Conrad T. Pino wrote: I suggest using %USERPROFILE% only as the next fall back for cases where any of %HOMEDRIVE%%HOMEPATH% are missing. I suggest some more research may be in order here first. Make sure that setting %USERPROFILE% isn't the perscribed method for overriding

Re: CVS update [cvs1-11-x-branch]: /ccvs/windows-NT/

2005-05-29 Thread Derek Price
Conrad T. Pino wrote: Hi Derek, From: Derek Price There is an xnrealloc function in lib/xmalloc.c. Isn't that being compiled on Windows? No, stable branch Windows build omits it because it doesn't exist. My tests (see below) say lib/xmalloc.c is on feature branch only. Ah, okay

Re: Module run.c Interface Standardized - Feature To Stable Branch

2005-05-29 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Conrad T. Pino wrote: 1. Who is able to run the OS/2 feature and stable builds? I don't know. Ocassionally, someone pokes their head in and sends us a patch to get it up and running, but I think it's been at least a year since that has happened.

Re: Feature Branch Windows Build Broken - lib/glob.c WINDOWS32

2005-05-28 Thread Derek Price
Conrad T. Pino wrote: I propose we do both, I'll edit and test, you coach: Sure. I'm OK with leaving WINDOWS32 undefined in our project. I'd like to see an improvement in the WINDOWS32 code for the benefit of other projects if for no other reason than saying thank you to GLib and GNULib by

Patch to protect spaces in diff arguments.

2005-05-27 Thread Derek Price
1.692.2.209 retrieving revision 1.692.2.210 diff -u -p -r1.692.2.209 -r1.692.2.210 --- ChangeLog 4 May 2005 02:35:14 - 1.692.2.209 +++ ChangeLog 27 May 2005 16:25:41 - 1.692.2.210 @@ -1,3 +1,8 @@ +2005-05-27 Derek Price [EMAIL PROTECTED] + + * NEWS: Note diff space split fix

Re: Feature Branch Windows Build Broken - lib/glob.c WINDOWS32

2005-05-26 Thread Derek Price
Conrad T. Pino wrote: Yes, the Windows build completes. Can you explain what home_dir value will be in the WINDOWS32 undefined logic? It looks like it would call, basically, getpwnam (getlogin()). There are substitutes for both in windows-NT/pwd.c, though it doesn't look like they are

Re: [bug-gnulib] New GNULIB glob module?

2005-05-26 Thread Derek Price
Paul Eggert wrote: Derek Price [EMAIL PROTECTED] writes: I chose the _SYS_CDEFS_H route since it seemed simplest to me, though I chose to name the macro `MISSING_SYS_CDEFS_H'. Sorry, that's not right, since it fails in the following scenario: #define MISSING_SYS_CDEFS_H 27

extensions.m4 patch (was Re: [bug-gnulib] New GNULIB glob module?)

2005-05-26 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Paul Eggert wrote: --- extensions.m4.~1.6.~ 2005-02-23 05:49:36 -0800 +++ extensions.m4 2005-05-24 12:35:48 -0700 @@ -21,6 +21,10 @@ AC_DEFUN([gl_USE_SYSTEM_EXTENSIONS], [ [/* Enable extensions on Solaris. */ #ifndef __EXTENSIONS__ # undef

Re: Feature Branch Windows Build Broken - lib/canonicalize.c - ELOOP lstat

2005-05-25 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Conrad T. Pino wrote: Hi Derek, Here's a rough draft of a patch that allows Windows build to complete. The draft includes edited files only and ignores generated files and Windows build projects files are also omitted. Briefly the plan is:

Re: Feature Branch Solaris Build Broken - lib/glob.c errors

2005-05-25 Thread Derek Price
Conrad T. Pino wrote: Hi Derek, From: Conrad T. Pino From: Derek Price Perhaps the problem is in your GCC installation or usage? A gcc upgrade sure helps. I installed gcc 3.4.2 binary from SunFreeWare.\ I brought up changes to the GNULIB stat module up on bug-gnulib

Re: [bug-gnulib] New GNULIB glob module?

2005-05-25 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Paul Eggert wrote: Derek Price [EMAIL PROTECTED] writes: +# ifdef HAVE___POSIX_GETPWNAM_R + /* Solaris. */ +# define getpwnam_r(name, bufp, buf, len, res) \ + __posix_getpwnam_r (name, bufp, buf, len, res) +# endif I don't see why this is needed

Re: [bug-gnulib] New GNULIB glob module?

2005-05-25 Thread Derek Price
Larry Jones wrote: Derek Price writes: Larry, can you tell us if defining _POSIX_PTHREAD_SEMANTICS would work to get the POSIX version of getpwnam_r on Solaris? It looks like it. I've committed Paul's patch to the CVS CVS tree, as well as removing the associated glob.c changes

Re: Feature Branch Solaris Build Broken - lib/glob.c errors

2005-05-25 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Conrad T. Pino wrote: I loaded the gcc 2.95 compiler for the sole purpose of compiling CVS on this platform since previously CVS Home didn't offer a binary for this platform. I loaded the gcc 3.4 compiler for the sole purpose of fixing the CVS

Re: Feature Branch Windows Build Broken - lib/glob.c WINDOWS32

2005-05-25 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Conrad T. Pino wrote: Oops, I forgot the error message which follows. Compiling... glob.c h:\conrad\projects\cvs-1.12\lib\glob.c(535) : warning C4013: 'sysconf' undefined; assuming extern returning int h:\conrad\projects\cvs-1.12\lib\glob.c(535) :

Re: Feature Branch Windows Build - lib/dup-safer.c dup

2005-05-25 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Conrad T. Pino wrote: Hi All, The dup function call in lib/dup-safer.c has no prototype included. Windows Visual C 6.0 does NOT implement dup but does implement _dup as: int _dup( int handle ); I've added #define dup _dup to config.h chain but

Re: Feature Branch Solaris Build Broken - lib/glob.c errors

2005-05-24 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Conrad T. Pino wrote: Hi Derek, We have a new lib/glob.c error today which I hope to understand before committing #include sys/stat.h addition to lib/glob_.h you suggested. Adding #include sys/stat.h to glob_.h doesn't help with this new error? I

Re: Feature Branch Solaris Build Broken - lib/glob.c errors

2005-05-24 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 It looks like your header is using some sort of #pragma to redefine the function names, which I would hope would make them look less like macros and actually remap the functions, allowing us to use the macros in glob.c as they stand. You are still

Re: Feature Branch Solaris Build Broken - lib/glob.c errors

2005-05-24 Thread Derek Price
Conrad T. Pino wrote: Hi Derek, From: Derek Price 1. #include sys/stat.h within glob_.h file. This would be the way to go. You may commit this if you wish. I committed an inclusion immediately before struct stat forward declaration to assure the Solaris stat macro

Re: Feature Branch Solaris Build Broken - lib/glob.c errors

2005-05-24 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Conrad T. Pino wrote: Defining macro __PRAGMA_REDEFINE_EXTNAME on the command line stops all errors and warnings in lib/glob.c compile. (For those new to this thread, this is because the Solaris headers #define stat stat64 when the

Re: Feature Branch Solaris Build Broken - lib/glob.c errors

2005-05-21 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Conrad T. Pino wrote: Excuse me for perhaps being slow but why is configure choosing to use lib/glob.h when the platform has /usr/include/glob.h whose contents follow? Partly because the GNU glob semantics are more extensive than the POSIX spec,

Re: Feature Branch Solaris Build Broken - lib/glob.c errors

2005-05-21 Thread Derek Price
Conrad T. Pino wrote: 1. #include sys/stat.h within glob_.h file. This would be the way to go. You may commit this if you wish. 2. Move #include glob.h below #include sys/stat.h in glob.c file. This is incorrect. The GNULIB convention is to include a module's header immediately

Re: Feature Branch Solaris Build Broken - lib/glob.c errors

2005-05-20 Thread Derek Price
Conrad T. Pino wrote: From: Derek Price [mailto:[EMAIL PROTECTED] I think I just checked in fixes for both Solaris compile problems, this one and one with getpwnam_r. Could you let me know if they work? I have no way to test here. The compile completes but we have warnings (see below

GZip level restriction

2005-05-20 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hey all, I discussed adding a compression level restriction on the server as a work-around for another bug that has since been fixed a few months back. I can't find the email, but I believe Mark Baushke suggested a restriction format like:

Re: GZip level restriction

2005-05-20 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Larry Jones wrote: Derek Price writes: I discussed adding a compression level restriction on the server as a work-around for another bug that has since been fixed a few months back. I don't think hard restrictions are a good idea. The best

Re: [bug-gnulib] New GNULIB glob module?

2005-05-20 Thread Derek Price
Paul Eggert wrote: There is one change I know I made that might have an effect. I added the !defined _LIBC to the following block because I was unsure what __REDIRECT_NTH was supposed to be doing I think that one's OK. Larry Jones on the CVS team just made a comment that makes me

Re: Feature Branch Solaris Build Broken - lib/glob.c errors

2005-05-19 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Conrad T. Pino wrote: The Solaris function declaration from /usr/include/unistd.h:850: previous declaration of `getlogin_r' looks like: extern char *getlogin_r(char *, int); and lib/glob.c line 194 looks like: extern int getlogin_r (char *,

Re: [bug-gnulib] New GNULIB glob module?

2005-05-18 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Paul Eggert wrote: Answering my own question: yes it will, in general, because perhaps the gnulib version fixes a bug that's in the glibc version, and the user wants the gnulib version. So we should worry about this. And (as far as I can see) the

Re: Feature Branch Windows Build Broken - New GNULIB glob module

2005-05-18 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Conrad T. Pino wrote: I updated with the recent commit of the glob module and we have a new warning on line 1184 of lib/glob.c file (see below) Let's revisit this after you provide definitions for the following macros in windows-NT/config.h.in.in:

Re: history and val-tags locks.

2005-05-18 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Mark D. Baushke wrote: For pserver, the administrator has full control over the command line. For server, if the administrator is using a restricted shell for users, they may or may not be able to restrict command-line arguments (it depends on

Re: [bug-gnulib] New GNULIB glob module?

2005-05-17 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Thanks for the latest round. I'm going to be out of the office today, but I should get to it by tomorrow. Regards, Derek -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.0 (Cygwin) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

Re: Feature Branch Windows Build Broken - New GNULIB glob module

2005-05-17 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Conrad T. Pino wrote: The following patch lets me get this far in the Windows IDE build: Configuration: libcvs - Win32 Debug Compiling... glob.c H:\Conrad\Projects\cvs-1.12\lib\glob.c(253) : warning C4028:

Re: [bug-gnulib] New GNULIB glob module?

2005-05-17 Thread Derek Price
Paul Eggert wrote: Derek Price [EMAIL PROTECTED] writes: /* Enable GNU extensions in glob.h. */ -#ifndef _GNU_SOURCE +#if defined _LIBC !defined _GNU_SOURCE # define _GNU_SOURCE 1 #endif I just checked the glibc source file include/libc-symbols.h, and it defines both _LIBC

Re: [bug-gnulib] New GNULIB glob module?

2005-05-17 Thread Derek Price
Paul Eggert wrote: Now for commentary on glob.h. Derek Price [EMAIL PROTECTED] writes: --- ../glibc-2.3.5/posix/glob.h 2004-09-16 20:55:15.0 -0400 +++ lib/glob_.h 2005-05-13 12:21:39.0 -0400 @@ -19,29 +19,48 @@ #ifndef _GLOB_H #define _GLOB_H 1

Re: [bug-gnulib] New GNULIB glob module?

2005-05-17 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Paul Eggert wrote: Derek Price [EMAIL PROTECTED] writes: Are you sure? You asked me to restore similar parens around bit-ands back at several other locations despite other work that changed the lines, in an earlier email. Not that I disagree now. I

Re: history and val-tags locks.

2005-05-17 Thread Derek Price
Patch actually attached this time. Cheers, Derek Derek Price wrote: I've implemented this as an option to server pserver. Installing as a global option would have create problems in multiroot mode anyhow. Preliminary patch against 1.11.x attached. The final version will go into feature

Re: history and val-tags locks.

2005-05-17 Thread Derek Price
Derek Price wrote: Derek Price wrote: I see your point. What about `cvs server'? I can see both setups being useful... an admin who allowed users access to the CVS repository would probably prefer not to allow the config file to be specified whereas an admin who restriced the command

Re: [bug-gnulib] New GNULIB glob module?

2005-05-17 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Paul Eggert wrote: First, already we have something bogus: that __BEGIN_DECLS. It must be protected by #ifdef _LIBC, since random C environments don't have it. Similarly for __END_DECLS. Done. The simplest fix would be to do something like this:

Re: Feature Branch Windows Build Broken - New GNULIB glob module

2005-05-17 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Conrad T. Pino wrote: I saw you're involved with Paul Eggert on a New GNULIB module topic and assumed we had done another GNULib import which has often broken the Windows build. Well, basically. I created the glob module myself and added it to CVS

Re: NEWS file needs update?

2005-05-12 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jim Hyslop wrote: According to this message, http://lists.gnu.org/archive/html/info-cvs/2004-10/msg00252.html, the Protocol error: uncounted data discarded error was scheduled to be fixed in 1.11.18, but there is no mention of that error in the NEWS

Re: [bug-gnulib] New GNULIB glob module?

2005-05-11 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Karl Berry wrote: Subject: [bug-gnulib] New GNULIB glob module? Would it be possible to simply use the libc code as-is? I guess I mean, with whatever changes are needed sent back to libc. So much stuff in gnulib is 95% the same as libc. It doesn't

Re: [bug-gnulib] New GNULIB glob module?

2005-05-11 Thread Derek Price
Most of this looks good, but one quick question as I get to this: I assume from the following that I can expect _LIBC to be defined iff the file is being compiled as part of glibc? I wasn't sure... Cheers, Derek Paul Eggert wrote: -#ifdef _LIBC -# include alloca.h -# undef strdup -# define

Re: [bug-gnulib] Re: getopt and Solaris 10

2005-05-10 Thread Derek Price
Paul Eggert wrote: Derek Price [EMAIL PROTECTED] writes: + myargv[[0]] = conftest; + myargv[[1]] = -+; This doesn't null-terminate myargv. But I still don't get why the change is needed. It sounds like you're assuming Solaris 11 getopt might get fixed? Yes, I

Re: [bug-gnulib] Re: getopt and Solaris 10

2005-05-10 Thread Derek Price
Paul Eggert wrote: Derek Price [EMAIL PROTECTED] writes: + myargv[[0]] = conftest; + myargv[[1]] = -+; This doesn't null-terminate myargv. Okay, looking at that in C89 now, but just out of curiosity, if argv needs to be NULL terminated, what's the point of argc

Re: [bug-gnulib] Re: getopt and Solaris 10

2005-05-10 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Matthias Kurz wrote: I'm running out of time. I have to quit. Thanks very much for your effords. When there is something to test, i'll still try to help. No problem. Thanks for your help, Matthias. Regards, Derek -BEGIN PGP SIGNATURE-

Re: lockinfo

2005-05-10 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Mark D. Baushke wrote: I honestly don't know if it is a good idea to introduce this patch to feature in this way at this time. What do the other maintainers think of this kind of extension? I don't have a strong opinion either way. Some

Re: [bug-gnulib] Re: getopt and Solaris 10

2005-05-10 Thread Derek Price
Paul Eggert wrote: Derek Price [EMAIL PROTECTED] writes: Revised patch attached. Thanks; I installed the following slightly-different patch. Works for me. Thanks Paul. Derek ___ Bug-cvs mailing list Bug-cvs@gnu.org http

Re: [bug-gnulib] Re: getopt and Solaris 10

2005-05-10 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Karl Berry wrote: GNU getopt tries to do too much when it reorders the commandline and therefor needs the + as a workaround. I don't suppose it matters at this point, but I fail to see the connection here. You can tell GNU getopt to REQUIRE_ORDER

Re: [bug-gnulib] Re: getopt and Solaris 10

2005-05-09 Thread Derek Price
Matthias Kurz wrote: On Thu, May 05, 2005, Paul Eggert wrote: Derek Price [EMAIL PROTECTED] writes: I prefer door #2. Trivial patch attached: Thanks, but I'd rather use AC_CHECK_DECL, so I installed this instead, into both coreutils and gnulib. Does it work? 2005-05-05

Re: [bug-gnulib] Re: getopt and Solaris 10

2005-05-09 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Matthias Kurz wrote: I do not think that this is a Solaris _bug_. - From the point of view of the GNULIB getopt.m4 tests, if it doesn't behave like GNU getopt, that is a bug. :) I'd bet that every system that does not use GNU getopt will suffer

Re: [bug-gnulib] Re: getopt and Solaris 10

2005-05-09 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Matthias Kurz wrote: Hi. One more clarification. Maybe one or the other missed my last comments on https://ccvs.cvshome.org/issues/show_bug.cgi?id=248. It was me, who introduced the '+' myth. Well, it is not a myth. I studied the test program and

Re: [bug-gnulib] Re: getopt and Solaris 10

2005-05-09 Thread Derek Price
know of), I don't think this is properly considered a Solaris bug, but a CVS bug. At least, it would be a CVS bug if we didn't have to use the GNU getopt on Solaris due to the + problem anyhow. Cheers, Derek Derek Price wrote: Matthias Kurz wrote: Hi. One more clarification. Maybe one

Re: [bug-gnulib] Re: getopt and Solaris 10

2005-05-09 Thread Derek Price
]points to the string - | /getopt/() returns -1 without changing /optind./ Cheers, Derek Derek Price wrote: Regardless, since using an optind = 0 is not specified as supported by POSIX, whereas optind = 1 is, and since using optind = 1 in place of optind = 0 in CVS would avoid

Re: [bug-gnulib] Re: getopt and Solaris 10

2005-05-09 Thread Derek Price
Derek Price wrote: 2005-05-05 Paul Eggert [EMAIL PROTECTED] * lib/getopt.m4 (gl_GETOPT): Check for Solaris 10 getopt, and avoid needless checks. Yes, this also works for me. Okay, one more revision, to actually check if the -+ registers as an option

Re: history and val-tags locks.

2005-05-06 Thread Derek Price
Mark D. Baushke wrote: I believe that most modern glob() implementations may indeed internally be implemented using fnmatch(), but not all of them are. If you are considering using an internal glob() instead of relying on a library version from the system, then I don't have as much of a

Re: history and val-tags locks.

2005-05-05 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Mark D. Baushke wrote: Note that HistoryFile has an argument that would basically be run through strftime, to enable log rotation. Also see the HistorySearch, which would be used as a file glob to locate history files to be read for executions of

getopt and Solaris 10

2005-05-05 Thread Derek Price
Apparently Solaris 10 includes a getopt.h and appears to be GNU getopt by all the tests in getopt.m4. Unfortunately, it doesn't support + as the first character of the option string. The original report is here: https://ccvs.cvshome.org/issues/show_bug.cgi?id=248. I'm assuming that GNULIB is

Re: [bug-gnulib] getopt and Solaris 10

2005-05-05 Thread Derek Price
James Youngman wrote: On Thu, May 05, 2005 at 01:34:24PM -0400, Derek Price wrote: Apparently Solaris 10 includes a getopt.h and appears to be GNU getopt by all the tests in getopt.m4. Unfortunately, it doesn't support + as the first character of the option string. But surely we

Re: getopt and Solaris 10

2005-05-05 Thread Derek Price
Derek Price wrote: Apparently Solaris 10 includes a getopt.h and appears to be GNU getopt by all the tests in getopt.m4. Unfortunately, it doesn't support + as the first character of the option string. The original report is here: https://ccvs.cvshome.org/issues/show_bug.cgi?id=248

Re: [bug-gnulib] Re: getopt and Solaris 10

2005-05-05 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Derek Price wrote: 2005-05-05 Derek Price [EMAIL PROTECTED] * m4/getopt.m4 (gl_GETOPT): Use GNULIB getopt on Solaris 10. Matthias reports that this patch does The Right Thing (tm) on Solaris 10: https://ccvs.cvshome.org/issues/show_bug.cgi?id=248

Re: PAM session support documentation

2005-05-04 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Brian Murphy wrote: Hi Guys, I would like to commit the attached patch. It documents in the example files the necessary session lines in the PAM configuration file. I/we seem to have missed this when the session support was added. The manual

Re: MacOS X 10.3.7 Build Problem After CVS CheckOut

2005-05-04 Thread Derek Price
This is a well-known problem. The workaround is to use a build directory. i.e.: cvs co ccvs cd ccvs mkdir build cd build ../configure make I never thought it was worth coming up with a more automated solution, but you're welcome to try. I would argue against changing the

Re: MacOS X 10.3.7 Build Problem After CVS CheckOut

2005-05-04 Thread Derek Price
Incidentally, I thought this was documented somewhere other than the email list, but I don't see it. I've added a note to INSTALL on stable and INSTALL-CVSon feature. Cheers, Derek Derek Price wrote: This is a well-known problem. The workaround is to use a build directory. i.e.: cvs co

Re: MacOS X 10.3.7 Build Problem After CVS CheckOut

2005-05-04 Thread Derek Price
Conrad T. Pino wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Derek, From: Derek Price [mailto:[EMAIL PROTECTED] I never thought it was worth coming up with a more automated solution, but you're welcome to try. I would argue against changing the name of the executable though

Re: [PATCH] pagealign_alloc: don't loop endlessly

2005-05-04 Thread Derek Price
Does the attached, more general, patch do the trick for you? I think the problem is deeper - error() really needs a way to bypass the memory allocation of the buffer routines, but this should work around the problem for now. Cheers, Derek Thorsten Glaser wrote: Hello! Please apply the

Re: [PATCH] pagealign_alloc: don't loop endlessly

2005-05-04 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Thorsten Glaser wrote: Derek Price dixit: Yes, that's why I was suggesting to print the error message to stderr so at least the client gets an idea about what happened and can slap the server administrator. CVS does this for quite some occasions

Re: [PATCH] pagealign_alloc: don't loop endlessly

2005-05-04 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Thorsten Glaser wrote: Derek Price dixit: Does the attached, more general, patch do the trick for you? It does, but I do not get a diagnostic, neither on stderr (CVS output) nor in syslog on server or client. This is probably because the CVS

Re: [PATCH] pagealign_alloc: don't loop endlessly

2005-05-04 Thread Derek Price
/ChangeLog,v retrieving revision 1.3186 diff -u -p -r1.3186 ChangeLog --- src/ChangeLog 4 May 2005 02:48:16 - 1.3186 +++ src/ChangeLog 4 May 2005 20:14:40 - @@ -1,3 +1,7 @@ +2005-05-04 Derek Price [EMAIL PROTECTED] + + * error.c (error): Avoid recursion and syslog

Re: history and val-tags locks.

2005-05-02 Thread Derek Price
Derek Price wrote: HistoryFile=$CVSROOT/CVSROOT/logs/history/%Y%m%d So, if the history file path were configurable and run through strftime(), I can either (1) cache the history file name the first time it is determined and gaurantee that all the operations from the same server execution

  1   2   3   >